All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux PM list <linux-pm@vger.kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"'Daniel Lezcano'" <daniel.lezcano@linaro.org>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH 0/2] cpuidle: Avoid returning a disabled C-state from menu governor
Date: Sun, 27 Apr 2014 14:53:09 +0200	[thread overview]
Message-ID: <2471963.urOyfY8mOG@vostro.rjw.lan> (raw)

Hi,

The cpuidle menu governor has a problem that it returns 0 when it can't find
a suitable C-state, but on some systems in some situations 0 may be the
CPUIDLE_DRIVER_STATE_START index and it shouldn't be returned if the corresponding
C-state has been disabled, for example.

The following two patches avoid this issue by modifying the menu governor to
return an error code rather than 0 in those situations.

[1/2] Combine cpuidle_enabled() with cpuidle_select(), because [2/2] makes
      the latter return negative error codes sometimes, so keeping them separate
      is not useful any more.

[2/2] Modify the menu governor to return an error code if the extra "poll" state
      is not available.

Thanks!


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

             reply	other threads:[~2014-04-27 12:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-27 12:53 Rafael J. Wysocki [this message]
2014-04-27 12:54 ` [PATCH 1/2] cpuidle: Combine cpuidle_enabled() with cpuidle_select() Rafael J. Wysocki
2014-04-27 12:55 ` [PATCH 2/2] cpuidle / menu: Return error code if there are no suitable states Rafael J. Wysocki
2014-04-28 11:14   ` Daniel Lezcano
2014-04-28 23:28     ` Rafael J. Wysocki
2014-04-29 23:16       ` Rafael J. Wysocki
2014-05-02  8:47         ` Daniel Lezcano
2014-05-02 12:20           ` Rafael J. Wysocki
2014-05-02 13:19             ` Daniel Lezcano
2014-05-04 22:39               ` Rafael J. Wysocki
2014-04-30 12:40       ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2471963.urOyfY8mOG@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.