From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=fuzziesquirrel.com (client-ip=173.167.31.197; helo=bajor.fuzziesquirrel.com; envelope-from=bradleyb@fuzziesquirrel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=fuzziesquirrel.com Received: from bajor.fuzziesquirrel.com (mail.fuzziesquirrel.com [173.167.31.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46dBbh0m0GzDqc1 for ; Wed, 25 Sep 2019 05:49:35 +1000 (AEST) X-Virus-Scanned: amavisd-new at fuzziesquirrel.com Received: from [192.168.253.30] (unknown [192.168.253.30]) by bajor.fuzziesquirrel.com (Postfix) with ESMTPSA id D3FB81483A; Tue, 24 Sep 2019 15:49:32 -0400 (EDT) Content-Type: text/plain; charset=utf-8; delsp=yes; format=flowed Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [PATCH v2 linux dev-5.3 1/4] dt-bindings: lpc: add aspeed-g6 compatible strings From: Brad Bishop In-Reply-To: Date: Tue, 24 Sep 2019 15:49:32 -0400 Cc: Eddie James , Joel Stanley , openbmc@lists.ozlabs.org Message-Id: <247461E8-9B9B-4CE0-9FF9-43049A3224A3@fuzziesquirrel.com> References: <20190919152340.23133-1-bradleyb@fuzziesquirrel.com> <20190919152340.23133-7-bradleyb@fuzziesquirrel.com> To: Andrew Jeffery X-Mailer: Apple Mail (2.3445.104.11) Content-Transfer-Encoding: quoted-printable X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Sep 2019 19:49:36 -0000 at 2:30 AM, Andrew Jeffery wrote: Thanks Andrew, Eddie for the review. > > > On Fri, 20 Sep 2019, at 01:55, Eddie James wrote: >> On 9/19/19 10:23 AM, Brad Bishop wrote: >>> Assume The AST2600 SoCs contain the same LPC devices as the AST2500. > > Has anyone validated the assumption? They have the same register set in the LPC space. This is about as far a= s =20 I=E2=80=99ve gotten. > >> Reviewed-by: Eddie James >> >> >>> Signed-off-by: Brad Bishop >>> --- >>> .../devicetree/bindings/ipmi/aspeed,ast2400-ibt-bmc.txt | 3 ++- >>> Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 8 +++++= ++- > > This should be split in two for upstream as the IPMI changes will need = to =20 > go > via Corey while the MFD changes go through Lee. Split in two in v3.