All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <t.figa@samsung.com>
To: Vikas Sajjan <vikas.sajjan@linaro.org>
Cc: linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
	devicetree@vger.kernel.org, patches@linaro.org,
	linaro-kernel@lists.linaro.org
Subject: Re: [PATCH v5 1/3] ARM: dts: Fix the RTC DT node name for Exynos5250 SoC
Date: Thu, 22 Aug 2013 14:27:04 +0200	[thread overview]
Message-ID: <2478737.HBqGSWXzHv@amdc1227> (raw)
In-Reply-To: <1377171208-23515-2-git-send-email-vikas.sajjan@linaro.org>

Hi Vikas,

On Thursday 22 of August 2013 17:03:26 Vikas Sajjan wrote:
> Fixes the RTC DT node name for Exynos5250 SoC as per the DT node naming
> convention.
> 
> Signed-off-by: Vikas Sajjan <vikas.sajjan@linaro.org>
> ---
>  arch/arm/boot/dts/exynos5.dtsi    |    2 +-
>  arch/arm/boot/dts/exynos5250.dtsi |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5.dtsi
> b/arch/arm/boot/dts/exynos5.dtsi index 6afa57d..074739d 100644
> --- a/arch/arm/boot/dts/exynos5.dtsi
> +++ b/arch/arm/boot/dts/exynos5.dtsi
> @@ -95,7 +95,7 @@
>  		interrupts = <0 54 0>;
>  	};
> 
> -	rtc {
> +	rtc@101E0000 {
>  		compatible = "samsung,s3c6410-rtc";
>  		reg = <0x101E0000 0x100>;
>  		interrupts = <0 43 0>, <0 44 0>;
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi index 1eec646..b278b00 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -180,7 +180,7 @@
>  		clock-names = "mfc";
>  	};
> 
> -	rtc {
> +	rtc@101E0000 {
>  		clocks = <&clock 337>;
>  		clock-names = "rtc";
>  	};

This patch should also rename any other occurencies of rtc node in board 
dts files, because otherwise it breaks RTC support in bisections.

Otherwise the whole series looks fine to me.

Best regards,
Tomasz

  reply	other threads:[~2013-08-22 12:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-22 11:33 [PATCH v5 0/3] Add RTC DT node to Exynos5420 SoC and Fix RTC DT node name for 5250 Soc Vikas Sajjan
2013-08-22 11:33 ` [PATCH v5 1/3] ARM: dts: Fix the RTC DT node name for Exynos5250 SoC Vikas Sajjan
2013-08-22 12:27   ` Tomasz Figa [this message]
2013-08-22 11:33 ` [PATCH v5 2/3] ARM: dts: Update the "status" property of RTC DT node " Vikas Sajjan
2013-08-22 11:33 ` [PATCH v5 3/3] ARM: dts: Add RTC DT node to Exynos5420 SoC Vikas Sajjan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2478737.HBqGSWXzHv@amdc1227 \
    --to=t.figa@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kgene.kim@samsung.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=vikas.sajjan@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.