Re: [PATCH net-next] veth: report NEWLINK event when moving the peer device in a new namespace

From: David Ahern <dsahern@gmail.com>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Network Development <netdev@vger.kernel.org>,
	Thomas Haller <thaller@redhat.com>
Subject: Re: [PATCH net-next] veth: report NEWLINK event when moving the peer device in a new namespace
Date: Sat, 1 Sep 2018 17:45:57 -0600	[thread overview]
Message-ID: <247de7c5-5046-81f4-d0b9-f6fcd505e8e8@gmail.com> (raw)
In-Reply-To: <CAJ0CqmV5+qG_L57UC47cUfAuvrnDesk0uhYbsEYy8F7zJ0869A@mail.gmail.com>

On 9/1/18 3:05 AM, Lorenzo Bianconi wrote:
> 
> I was thinking about the commit 38e01b30563a and then I realized I
> misread the code
> yesterday. The commit 38e01b30563a provides all relevant info but it
> emits the event
> for veth1 (the device moved in the new namespace).
> An userspace application will not receive that message if it filters
> events for just
> a specific device (veth0 in this case) despite that some device
> properties have changed
> (since veth0 and veth1 are paired devices). To fix that behavior in
> veth_notify routine
> I emits a RTM_NEWLINK event for veth0.

Userspace is managing a veth a pair. It moves one of them to a new
namespace and decides to filter messages related to that device before
the move. If it did not filter the DELLINK message it would get the
information you want. That to me is a userspace problem. What am I missing?

Fundamentally, your proposal means 3 messages when moving a device to a
new namespace which is what I think is unnecessary.