From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40314C43381 for ; Thu, 21 Mar 2019 17:27:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 11B8921874 for ; Thu, 21 Mar 2019 17:27:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728625AbfCUR1q (ORCPT ); Thu, 21 Mar 2019 13:27:46 -0400 Received: from foss.arm.com ([217.140.101.70]:60482 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728138AbfCUR1p (ORCPT ); Thu, 21 Mar 2019 13:27:45 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D574D374; Thu, 21 Mar 2019 10:27:44 -0700 (PDT) Received: from [10.37.12.130] (unknown [10.37.12.130]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5C0CC3F614; Thu, 21 Mar 2019 10:27:42 -0700 (PDT) Subject: Re: [PATCH RFC 01/14] arm64/mm: Introduce asid_info structure and move asid_generation/asid_map to it To: Suzuki K Poulose , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu Cc: christoffer.dall@arm.com, james.morse@arm.com, marc.zyngier@arm.com, julien.thierry@arm.com, catalin.marinas@arm.com, will.deacon@arm.com References: <20190321163623.20219-1-julien.grall@arm.com> <20190321163623.20219-2-julien.grall@arm.com> From: Julien Grall Message-ID: <247efb35-2082-289a-43cf-3342b586b1d8@arm.com> Date: Thu, 21 Mar 2019 17:27:40 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/21/19 5:03 PM, Suzuki K Poulose wrote: > Hi Julien, Hi Suzuki, > On 21/03/2019 16:36, Julien Grall wrote: >> In an attempt to make the ASID allocator generic, create a new structure >> asid_info to store all the information necessary for the allocator. >> >> For now, move the variables asid_generation and asid_map to the new >> structure >> asid_info. Follow-up patches will move more variables. >> >> Note to avoid more renaming aftwards, a local variable 'info' has been >> created and is a pointer to the ASID allocator structure. >> >> Signed-off-by: Julien Grall >> --- >>   arch/arm64/mm/context.c | 46 >> ++++++++++++++++++++++++++-------------------- >>   1 file changed, 26 insertions(+), 20 deletions(-) >> >> diff --git a/arch/arm64/mm/context.c b/arch/arm64/mm/context.c >> index 1f0ea2facf24..34db54f1a39a 100644 >> --- a/arch/arm64/mm/context.c >> +++ b/arch/arm64/mm/context.c >> @@ -30,8 +30,11 @@ >>   static u32 asid_bits; >>   static DEFINE_RAW_SPINLOCK(cpu_asid_lock); >> -static atomic64_t asid_generation; >> -static unsigned long *asid_map; >> +struct asid_info >> +{ >> +    atomic64_t    generation; >> +    unsigned long    *map; >> +} asid_info; > > Shouldn't this be static ? Rest looks fine. Yes it should be static. I have updated my code. Thank you for the review! Cheers, > > Cheers > Suzuki -- Julien Grall From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4851FC43381 for ; Thu, 21 Mar 2019 17:27:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A1E621874 for ; Thu, 21 Mar 2019 17:27:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JzcKbgh0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A1E621874 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J/BctJ2vC67+ndWWIrbLmx1YF+T/HTTXonNqlWwGxr4=; b=JzcKbgh0YVvuE8NMd7O8fozeb yB3Cd5rh0Z0zHfAJH3Dsx6SrUyyyohH+L6mBmfO0HkY3xUAHVt9t0Dvpj96DKEqvPRwNOMFd0+Gk2 T2zMP4+oPlCY62A0cPNVBlsCPf/hfp7oQxQhq6UnlKWXlt06PGTWf6OoTLRFn+gzMB5CNSWBFUBua LBaiS7htWyPbB8MGWXMeCphEyvm1Ms4emxmRs5Gcdy8YyFk1qKbZvLTrwPaOfsyWgRXJt98rbyhrZ Abemce+1dVen9mZnq4joD8AJquJ0bjefMzQSvmQ0GYGmKP7E3ycE4BhK7zZShBK4wie3rqy4To5Yw 4mTQxc0KQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h71To-0001tN-PC; Thu, 21 Mar 2019 17:27:48 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h71Tm-0001t0-7A for linux-arm-kernel@lists.infradead.org; Thu, 21 Mar 2019 17:27:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D574D374; Thu, 21 Mar 2019 10:27:44 -0700 (PDT) Received: from [10.37.12.130] (unknown [10.37.12.130]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5C0CC3F614; Thu, 21 Mar 2019 10:27:42 -0700 (PDT) Subject: Re: [PATCH RFC 01/14] arm64/mm: Introduce asid_info structure and move asid_generation/asid_map to it To: Suzuki K Poulose , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu References: <20190321163623.20219-1-julien.grall@arm.com> <20190321163623.20219-2-julien.grall@arm.com> From: Julien Grall Message-ID: <247efb35-2082-289a-43cf-3342b586b1d8@arm.com> Date: Thu, 21 Mar 2019 17:27:40 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190321_102746_262136_38FEA571 X-CRM114-Status: GOOD ( 13.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: julien.thierry@arm.com, marc.zyngier@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, christoffer.dall@arm.com, james.morse@arm.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMy8yMS8xOSA1OjAzIFBNLCBTdXp1a2kgSyBQb3Vsb3NlIHdyb3RlOgo+IEhpIEp1bGllbiwK CkhpIFN1enVraSwKCj4gT24gMjEvMDMvMjAxOSAxNjozNiwgSnVsaWVuIEdyYWxsIHdyb3RlOgo+ PiBJbiBhbiBhdHRlbXB0IHRvIG1ha2UgdGhlIEFTSUQgYWxsb2NhdG9yIGdlbmVyaWMsIGNyZWF0 ZSBhIG5ldyBzdHJ1Y3R1cmUKPj4gYXNpZF9pbmZvIHRvIHN0b3JlIGFsbCB0aGUgaW5mb3JtYXRp b24gbmVjZXNzYXJ5IGZvciB0aGUgYWxsb2NhdG9yLgo+Pgo+PiBGb3Igbm93LCBtb3ZlIHRoZSB2 YXJpYWJsZXMgYXNpZF9nZW5lcmF0aW9uIGFuZCBhc2lkX21hcCB0byB0aGUgbmV3IAo+PiBzdHJ1 Y3R1cmUKPj4gYXNpZF9pbmZvLiBGb2xsb3ctdXAgcGF0Y2hlcyB3aWxsIG1vdmUgbW9yZSB2YXJp YWJsZXMuCj4+Cj4+IE5vdGUgdG8gYXZvaWQgbW9yZSByZW5hbWluZyBhZnR3YXJkcywgYSBsb2Nh bCB2YXJpYWJsZSAnaW5mbycgaGFzIGJlZW4KPj4gY3JlYXRlZCBhbmQgaXMgYSBwb2ludGVyIHRv IHRoZSBBU0lEIGFsbG9jYXRvciBzdHJ1Y3R1cmUuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IEp1bGll biBHcmFsbCA8anVsaWVuLmdyYWxsQGFybS5jb20+Cj4+IC0tLQo+PiDCoCBhcmNoL2FybTY0L21t L2NvbnRleHQuYyB8IDQ2IAo+PiArKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0t LS0tLS0tLS0tCj4+IMKgIDEgZmlsZSBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCAyMCBkZWxl dGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvbW0vY29udGV4dC5jIGIvYXJj aC9hcm02NC9tbS9jb250ZXh0LmMKPj4gaW5kZXggMWYwZWEyZmFjZjI0Li4zNGRiNTRmMWEzOWEg MTAwNjQ0Cj4+IC0tLSBhL2FyY2gvYXJtNjQvbW0vY29udGV4dC5jCj4+ICsrKyBiL2FyY2gvYXJt NjQvbW0vY29udGV4dC5jCj4+IEBAIC0zMCw4ICszMCwxMSBAQAo+PiDCoCBzdGF0aWMgdTMyIGFz aWRfYml0czsKPj4gwqAgc3RhdGljIERFRklORV9SQVdfU1BJTkxPQ0soY3B1X2FzaWRfbG9jayk7 Cj4+IC1zdGF0aWMgYXRvbWljNjRfdCBhc2lkX2dlbmVyYXRpb247Cj4+IC1zdGF0aWMgdW5zaWdu ZWQgbG9uZyAqYXNpZF9tYXA7Cj4+ICtzdHJ1Y3QgYXNpZF9pbmZvCj4+ICt7Cj4+ICvCoMKgwqAg YXRvbWljNjRfdMKgwqDCoCBnZW5lcmF0aW9uOwo+PiArwqDCoMKgIHVuc2lnbmVkIGxvbmfCoMKg wqAgKm1hcDsKPj4gK30gYXNpZF9pbmZvOwo+IAo+IFNob3VsZG4ndCB0aGlzIGJlIHN0YXRpYyA/ IFJlc3QgbG9va3MgZmluZS4KClllcyBpdCBzaG91bGQgYmUgc3RhdGljLiBJIGhhdmUgdXBkYXRl ZCBteSBjb2RlLgoKVGhhbmsgeW91IGZvciB0aGUgcmV2aWV3IQoKQ2hlZXJzLAoKPiAKPiBDaGVl cnMKPiBTdXp1a2kKCi0tIApKdWxpZW4gR3JhbGwKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK