From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93250C12002 for ; Wed, 21 Jul 2021 14:03:51 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48D1061244 for ; Wed, 21 Jul 2021 14:03:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48D1061244 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.159366.293141 (Exim 4.92) (envelope-from ) id 1m6Coq-00029q-MU; Wed, 21 Jul 2021 14:03:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 159366.293141; Wed, 21 Jul 2021 14:03:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6Coq-00029j-JJ; Wed, 21 Jul 2021 14:03:28 +0000 Received: by outflank-mailman (input) for mailman id 159366; Wed, 21 Jul 2021 14:03:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6Coo-00029d-Tv for xen-devel@lists.xenproject.org; Wed, 21 Jul 2021 14:03:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m6Coo-0003XB-F4 for xen-devel@lists.xenproject.org; Wed, 21 Jul 2021 14:03:26 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1m6Coo-0007Wk-EC for xen-devel@lists.xenproject.org; Wed, 21 Jul 2021 14:03:26 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1m6Coj-0001Ui-HQ; Wed, 21 Jul 2021 15:03:21 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=CW7zwAK/qcfVNqJmdIur31yUxgPn6nf6WmEcYPDzBzo=; b=UDMskzl51QBMD0wc798QltGcG+ 1GbWUYhXla+fOOz3fW6KUdZ+aVepKaKVW3j8iJr0H97bIJJG8G816TIA4S2FhKkLSn4jIwgkH1heq 5L3uXzUH4SVBknMNkcuu8YfeLqgRbXB0Wh3gkS44aIpbFu0H2Pp/63su8OgPcAbOhOK4=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24824.10537.336687.898547@mariner.uk.xensource.com> Date: Wed, 21 Jul 2021 15:03:21 +0100 To: Jason Andryuk Cc: Scott Davis , xen-devel , Scott Davis , Wei Liu , George Dunlap , Nick Rosbrook , Anthony PERARD , Juergen Gross Subject: Re: [PATCH] tools/xl: Add stubdomain_cmdline option to xl.cfg In-Reply-To: References: <6562806d7430431dc154af2c6e4a5232725fc136.1626800539.git.scott.davis@starlab.io> <24824.6179.909691.713305@mariner.uk.xensource.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jason Andryuk writes ("Re: [PATCH] tools/xl: Add stubdomain_cmdline option to xl.cfg"): > Yes, they can both be useful. Append is sufficient until you want to > override or remove an option that is already included. Set can be > tedious since you have to copy the existing options before appending > your new one. > > Anyway, I just wanted the documentation to match the implementation. Yes. I am happy with either approach. Given the name I think override is probably better; then we can do append with _extra later if we like. So in summary I agree with your suggested change to this patch. > Looks like xl.cfg.5.pod.in says Append for cmdline/root/extra, so > Scott was repeating that. Looking around, aside from concatenating > root and extra in xl_parse.c:parse_cmdline(), libxl doesn't seem to > calculate command lines. If libxl is reserving the right to calculate > cmdline in the future, then keeping Append is fine by me. Thanks for the investigation. Ian.