From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] memory: make eal_get_virtual_area() aware of base-virtaddr alignment Date: Fri, 13 Jul 2018 00:01:22 +0200 Message-ID: <2482839.cxCvJVhnrX@xps> References: <20180615122448.28118-1-darek.stojaczyk@gmail.com> <20180615151304.32032-1-darek.stojaczyk@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Dariusz Stojaczyk , Anatoly Burakov , stable@dpdk.org To: Dariusz Stojaczyk Return-path: In-Reply-To: <20180615151304.32032-1-darek.stojaczyk@gmail.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/06/2018 17:13, Dariusz Stojaczyk: > From: Dariusz Stojaczyk > > Whenever a calculated base-virtaddr offset had to be > manually aligned to requested page_sz, we did not take > account of that alignment in incrementing the base-virtaddr > offset further. The next requested virtual area could print > a warning "hint [...] not respected!" and let the system > pick an address instead. As a result, this breaks secondary > process support on many system configurations. > > Fixes: b7cc54187ea4 ("mem: move virtual area function in common directory") > Cc: anatoly.burakov@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Dariusz Stojaczyk > Acked-by: Anatoly Burakov Applied, thanks