From: Thomas Monjalon <thomas@monjalon.net>
To: Xueming Li <xuemingl@mellanox.com>
Cc: dev@dpdk.org, Gaetan Rivet <gaetan.rivet@6wind.com>,
Wiles Keith <keith.wiles@intel.com>
Subject: Re: [PATCH v2] eal: add config option to enable asserts
Date: Mon, 09 Oct 2017 23:01:35 +0200 [thread overview]
Message-ID: <2483187.uH7VH6KlI1@xps> (raw)
In-Reply-To: <20170824082310.87485-1-xuemingl@mellanox.com>
24/08/2017 10:23, Xueming Li:
> Currently, enabling assertion have to set CONFIG_RTE_LOG_LEVEL to
> RTE_LOG_DEBUG. CONFIG_RTE_LOG_LEVEL is the default log level of control
> path, RTE_LOG_DP_LEVEL is the log level of data path. It's a little bit
> hard to understand literally that assertion is decided by control path
> LOG_LEVEL, especially assertion used on data path.
>
> On the other hand, DPDK need an assertion enabling switch w/o impacting
> log output level, assuming "--log-level" not specified.
>
> Assertion is an important API to balance DPDK high performance and
> robustness. To promote assertion usage, it's valuable to unhide
> assertion out of COFNIG_RTE_LOG_LEVEL.
>
> In one word, log is log, assertion is assertion, debug is hot pot :)
>
> Rationale of this patch is to introduce an dedicate switch of
> assertion: RTE_ENABLE_ASSERT
>
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Applied, thanks
prev parent reply other threads:[~2017-10-09 21:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 14:00 [PATCH] eal: add config option to enable asserts Xueming Li
2017-08-23 14:09 ` Gaëtan Rivet
2017-08-23 14:50 ` Wiles, Keith
2017-08-24 8:10 ` [PATCH v2] " Xueming Li
2017-08-24 8:23 ` Xueming Li
2017-10-09 21:01 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2483187.uH7VH6KlI1@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=keith.wiles@intel.com \
--cc=xuemingl@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.