From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC4E3C4338F for ; Fri, 13 Aug 2021 11:09:43 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C8A360F46 for ; Fri, 13 Aug 2021 11:09:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6C8A360F46 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.166754.304371 (Exim 4.92) (envelope-from ) id 1mEV43-0004Gn-2G; Fri, 13 Aug 2021 11:09:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 166754.304371; Fri, 13 Aug 2021 11:09:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mEV42-0004Gg-Uv; Fri, 13 Aug 2021 11:09:26 +0000 Received: by outflank-mailman (input) for mailman id 166754; Fri, 13 Aug 2021 11:09:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mEV42-0004Ga-94 for xen-devel@lists.xenproject.org; Fri, 13 Aug 2021 11:09:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mEV41-0004Fr-OH for xen-devel@lists.xenproject.org; Fri, 13 Aug 2021 11:09:25 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1mEV41-0008Qz-NL for xen-devel@lists.xenproject.org; Fri, 13 Aug 2021 11:09:25 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1mEV3y-00019A-7M; Fri, 13 Aug 2021 12:09:22 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=k357fCtaJ0yEVW58F8Zan4AZMTwdQ+4oQZj5tN9TPB4=; b=LcCMju0fu7Hi7Up/XwzmsEgQoF Ct2i90wFzZXebcec1OH403hTN0ZjrkCKS3NS3Yt8ky+SBqmhvfsy+H4dng0aLkyK/Y/WU2yV5ALic z4bxdBxajM52e9K4TRjdiMx1DtSItVnjRtY9/3lhN4bidSnW7hmLxmaOP9T+USHFFR1w=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24854.21217.976758.626859@mariner.uk.xensource.com> Date: Fri, 13 Aug 2021 12:09:21 +0100 To: Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Wei Liu , Juergen Gross , Julien Grall Subject: Re: [PATCH] tests/xenstore: link in librt In-Reply-To: <74fde732-c2bb-168f-a51c-74e2220c87c5@suse.com> References: <3fe5f85c-3702-286c-46a3-d90eb094123f@suse.com> <24853.1273.985325.539310@mariner.uk.xensource.com> <74fde732-c2bb-168f-a51c-74e2220c87c5@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH] tests/xenstore: link in librt"): > On 12.08.2021 13:24, Ian Jackson wrote: > >> +LDFLAGS += -lrt > > > > Don't this unconditionally is definitely not right. > > Assuming you meant "Doing this ..." - why? If the concern is that > librt.so may needlessly get recorded in a DT_NEEDED entry, then I > can replace the early addition with a late > > LDFLAGS += -Wl,--as-needed -lc -lrt > > one. librt might not exist at all on some platforms. > > How old a glibc are we talking about ? (I looked at the minimum > > versions listed in README and there's notthing about glibc; perhaps > > should be.) > > I've hit this with 2.11.3. I guess it has been made available by > libc.so from 2.17 onwards, considering the symbol version is > GLIBC_2.17. According to https://www.sourceware.org/glibc/wiki/Glibc%20Timeline glibc 2.17 was released more than eight years ago on 2012-12-25. Ian.