* [xen-unstable test] 164237: regressions - FAIL
@ 2021-08-19 3:07 osstest service owner
2021-08-19 12:06 ` Jan Beulich
0 siblings, 1 reply; 11+ messages in thread
From: osstest service owner @ 2021-08-19 3:07 UTC (permalink / raw)
To: xen-devel, osstest-admin
flight 164237 xen-unstable real [real]
flight 164246 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/164237/
http://logs.test-lab.xenproject.org/osstest/logs/164246/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-amd64-pvgrub 12 debian-di-install fail REGR. vs. 164178
test-amd64-amd64-i386-pvgrub 12 debian-di-install fail REGR. vs. 164178
Tests which did not succeed, but are not blocking:
test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 164178
test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164178
test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164178
test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 164178
test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 164178
test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164178
test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164178
test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 164178
test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164178
test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164178
test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164178
test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass
test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass
test-amd64-i386-libvirt 15 migrate-support-check fail never pass
test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass
test-amd64-amd64-libvirt 15 migrate-support-check fail never pass
test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass
test-amd64-i386-xl-pvshim 14 guest-start fail never pass
test-arm64-arm64-xl 15 migrate-support-check fail never pass
test-arm64-arm64-xl 16 saverestore-support-check fail never pass
test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass
test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass
test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass
test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass
test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass
test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass
test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass
test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass
test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass
test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass
test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass
test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass
test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass
test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass
test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass
test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass
test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass
test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass
test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass
test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass
test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass
test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass
test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass
test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass
test-armhf-armhf-xl 15 migrate-support-check fail never pass
test-armhf-armhf-xl 16 saverestore-support-check fail never pass
test-armhf-armhf-libvirt 15 migrate-support-check fail never pass
test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass
test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass
test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass
version targeted for testing:
xen 54c9736382e0d558a6acd820e44185e020131c48
baseline version:
xen 5a88d524857e5bf78b077d30ea515fcaac061bfc
Last test of basis 164178 2021-08-13 10:47:20 Z 5 days
Failing since 164182 2021-08-14 00:39:12 Z 5 days 8 attempts
Testing same since 164237 2021-08-18 07:24:21 Z 0 days 1 attempts
------------------------------------------------------------
People who touched revisions under test:
Andrew Cooper <andrew.cooper3@citrix.com>
Jan Beulich <jbeulich@suse.com>
Jane Malalane <jane.malalane@citrix.com>
Kevin Stefanov <kevin.stefanov@citrix.com>
Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
jobs:
build-amd64-xsm pass
build-arm64-xsm pass
build-i386-xsm pass
build-amd64-xtf pass
build-amd64 pass
build-arm64 pass
build-armhf pass
build-i386 pass
build-amd64-libvirt pass
build-arm64-libvirt pass
build-armhf-libvirt pass
build-i386-libvirt pass
build-amd64-prev pass
build-i386-prev pass
build-amd64-pvops pass
build-arm64-pvops pass
build-armhf-pvops pass
build-i386-pvops pass
test-xtf-amd64-amd64-1 pass
test-xtf-amd64-amd64-2 pass
test-xtf-amd64-amd64-3 pass
test-xtf-amd64-amd64-4 pass
test-xtf-amd64-amd64-5 pass
test-amd64-amd64-xl pass
test-amd64-coresched-amd64-xl pass
test-arm64-arm64-xl pass
test-armhf-armhf-xl pass
test-amd64-i386-xl pass
test-amd64-coresched-i386-xl pass
test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass
test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass
test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass
test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass
test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass
test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass
test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass
test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass
test-amd64-amd64-libvirt-xsm pass
test-arm64-arm64-libvirt-xsm pass
test-amd64-i386-libvirt-xsm pass
test-amd64-amd64-xl-xsm pass
test-arm64-arm64-xl-xsm pass
test-amd64-i386-xl-xsm pass
test-amd64-amd64-qemuu-nested-amd fail
test-amd64-amd64-xl-pvhv2-amd pass
test-amd64-i386-qemut-rhel6hvm-amd pass
test-amd64-i386-qemuu-rhel6hvm-amd pass
test-amd64-amd64-dom0pvh-xl-amd pass
test-amd64-amd64-xl-qemut-debianhvm-amd64 pass
test-amd64-i386-xl-qemut-debianhvm-amd64 pass
test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass
test-amd64-i386-xl-qemuu-debianhvm-amd64 pass
test-amd64-i386-freebsd10-amd64 pass
test-amd64-amd64-qemuu-freebsd11-amd64 pass
test-amd64-amd64-qemuu-freebsd12-amd64 pass
test-amd64-amd64-xl-qemuu-ovmf-amd64 pass
test-amd64-i386-xl-qemuu-ovmf-amd64 pass
test-amd64-amd64-xl-qemut-win7-amd64 fail
test-amd64-i386-xl-qemut-win7-amd64 fail
test-amd64-amd64-xl-qemuu-win7-amd64 fail
test-amd64-i386-xl-qemuu-win7-amd64 fail
test-amd64-amd64-xl-qemut-ws16-amd64 fail
test-amd64-i386-xl-qemut-ws16-amd64 fail
test-amd64-amd64-xl-qemuu-ws16-amd64 fail
test-amd64-i386-xl-qemuu-ws16-amd64 fail
test-armhf-armhf-xl-arndale pass
test-amd64-amd64-xl-credit1 pass
test-arm64-arm64-xl-credit1 pass
test-armhf-armhf-xl-credit1 pass
test-amd64-amd64-xl-credit2 pass
test-arm64-arm64-xl-credit2 pass
test-armhf-armhf-xl-credit2 pass
test-armhf-armhf-xl-cubietruck pass
test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass
test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass
test-amd64-amd64-examine pass
test-arm64-arm64-examine pass
test-armhf-armhf-examine pass
test-amd64-i386-examine pass
test-amd64-i386-freebsd10-i386 pass
test-amd64-amd64-qemuu-nested-intel pass
test-amd64-amd64-xl-pvhv2-intel pass
test-amd64-i386-qemut-rhel6hvm-intel pass
test-amd64-i386-qemuu-rhel6hvm-intel pass
test-amd64-amd64-dom0pvh-xl-intel pass
test-amd64-amd64-libvirt pass
test-armhf-armhf-libvirt pass
test-amd64-i386-libvirt pass
test-amd64-amd64-livepatch pass
test-amd64-i386-livepatch pass
test-amd64-amd64-migrupgrade pass
test-amd64-i386-migrupgrade pass
test-amd64-amd64-xl-multivcpu pass
test-armhf-armhf-xl-multivcpu pass
test-amd64-amd64-pair pass
test-amd64-i386-pair pass
test-amd64-amd64-libvirt-pair pass
test-amd64-i386-libvirt-pair pass
test-amd64-amd64-amd64-pvgrub fail
test-amd64-amd64-i386-pvgrub fail
test-amd64-amd64-xl-pvshim pass
test-amd64-i386-xl-pvshim fail
test-amd64-amd64-pygrub pass
test-amd64-amd64-xl-qcow2 pass
test-armhf-armhf-libvirt-raw pass
test-amd64-i386-xl-raw pass
test-amd64-amd64-xl-rtds pass
test-armhf-armhf-xl-rtds pass
test-arm64-arm64-xl-seattle pass
test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass
test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass
test-amd64-amd64-xl-shadow pass
test-amd64-i386-xl-shadow pass
test-arm64-arm64-xl-thunderx pass
test-amd64-amd64-libvirt-vhd pass
test-armhf-armhf-xl-vhd pass
------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images
Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs
Explanation of these reports, and of osstest in general, is at
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master
Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary
Not pushing.
------------------------------------------------------------
commit 54c9736382e0d558a6acd820e44185e020131c48
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date: Tue Aug 17 11:38:07 2021 +0100
x86/cet: Fix build on newer versions of GCC
Some versions of GCC complain with:
traps.c:405:22: error: 'get_shstk_bottom' defined but not used [-Werror=unused-function]
static unsigned long get_shstk_bottom(unsigned long sp)
^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Change #ifdef to if ( IS_ENABLED(...) ) to make the sole user of
get_shstk_bottom() visible to the compiler.
Fixes: 35727551c070 ("x86/cet: Fix shskt manipulation error with BUGFRAME_{warn,run_fn}")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Compile-tested-by: Jan Beulich <jbeulich@suse.com>
Tested-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
commit 35727551c0703493a2240e967cffc3063b13d49c
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date: Thu Aug 12 17:39:16 2021 +0100
x86/cet: Fix shskt manipulation error with BUGFRAME_{warn,run_fn}
This was a clear oversight in the original CET work. The BUGFRAME_run_fn and
BUGFRAME_warn paths update regs->rip without an equivalent adjustment to the
shadow stack, causing IRET to suffer #CP because of the mismatch.
One subtle, and therefore fragile, aspect of extable_shstk_fixup() was that it
required regs->rip to have its old value as a cross-check that the right word
in the shadow stack was being edited.
Rework extable_shstk_fixup() into fixup_exception_return() which takes
ownership of the update to both the regular and shadow stacks, ensuring that
the regs->rip update is ordered correctly.
Use the new fixup_exception_return() for BUGFRAME_run_fn and BUGFRAME_warn to
ensure that the shadow stack is updated too.
Fixes: 209fb9919b50 ("x86/extable: Adjust extable handling to be shadow stack compatible")
Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Tested-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
commit bc141e8ca56200bdd0a12e04a6ebff3c19d6c27b
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date: Mon Aug 16 14:24:44 2021 +0100
x86/ACPI: Insert missing newlines into FACS error messages
Booting Xen as a PVH guest currently yields:
(XEN) ACPI: SLEEP INFO: pm1x_cnt[1:b004,1:0], pm1x_evt[1:b000,1:0]
(XEN) ACPI: FACS is not 64-byte aligned: 0xfc001010<2>ACPI: wakeup_vec[fc00101c], vec_size[20]
(XEN) ACPI: Local APIC address 0xfee00000
Insert newlines as appropriate.
Fixes: d3faf9badf52 ("[host s3] Retrieve necessary sleep information from plain-text ACPI tables (FADT/FACS), and keep one hypercall remained for sleep notification.")
Fixes: 0f089bbf43ec ("x86/ACPI: fix S3 wakeup vector mapping")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
commit 6928bc511399fd8f593fe49a3241212860a6a1b5
Author: Andrew Cooper <andrew.cooper3@citrix.com>
Date: Thu Aug 12 14:49:57 2021 +0100
MAINTAINERS: Fix file path for kexec headers
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
commit 274c5e79c792ce0331d0d8cd9a01545dea5a48fd
Author: Kevin Stefanov <kevin.stefanov@citrix.com>
Date: Mon Aug 16 15:16:56 2021 +0200
x86/ioapic: remove use of TRUE/FALSE/1/0
Also fix stray usage in VT-d.
Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Kevin Stefanov <kevin.stefanov@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
commit 2e5512d1ffd2e720f25c376df12db8a914117589
Author: Jane Malalane <jane.malalane@citrix.com>
Date: Mon Aug 16 15:16:20 2021 +0200
x86/pv: provide more helpful error when CONFIG_PV32 is absent
Currently, when booting a 32bit dom0 kernel, the message isn't very
helpful:
(XEN) Xen kernel: 64-bit, lsb
(XEN) Dom0 kernel: 32-bit, PAE, lsb, paddr 0x100000 -> 0x112000
(XEN) Mismatch between Xen and DOM0 kernel
(XEN)
(XEN) ****************************************
(XEN) Panic on CPU 0:
(XEN) Could not construct domain 0
(XEN) ****************************************
With this adjustment, it now looks like this:
(XEN) Xen kernel: 64-bit, lsb
(XEN) Found 32-bit PV kernel, but CONFIG_PV32 missing
(XEN)
(XEN) ****************************************
(XEN) Panic on CPU 0:
(XEN) Could not construct domain 0
(XEN) ****************************************
Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
commit c53aa9e655e7c615283e9e9637376c2b865e9dae
Author: Jane Malalane <jane.malalane@citrix.com>
Date: Mon Aug 16 15:15:43 2021 +0200
x86/pv: remove unnecessary use of goto out in construct_dom0()
elf_check_broken() only needs to be invoked after elf_xen_parse() and
after elf_load_binary().
Suggested-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
commit 60a9d8d2fc9c4a524c7342499580a88aaa3a2b55
Author: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Date: Mon Aug 16 15:14:37 2021 +0200
ns16550: do not override fifo size if explicitly set
If fifo size is already set via uart_params, do not force it to 16 - which
may not match the actual hardware. Specifically Exar cards have fifo of
256 bytes.
Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
commit 5c34b9af05b9e5abd25d88efc4fb783136547810
Author: Jan Beulich <jbeulich@suse.com>
Date: Fri Aug 13 16:50:09 2021 +0200
libxc: simplify HYPERCALL_BUFFER()
_hcbuf_buf1 has been there only for a pointer comparison to validate
type compatibility. The same can be achieved by not using typeof() on
the definition of what so far was _hcbuf_buf2, as the initializer has
to also be type-compatible. Drop _hcbuf_buf1 and the comaprison;
rename _hcbuf_buf2.
Since we're already using compiler extensions here, don't be shy and
also omit the middle operand of the involved ?: operator.
Bring line continuation character placement in line with that of
related macros.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
commit e241d15f1c8a8a02baa401af857393f9ada5aeb3
Author: Jan Beulich <jbeulich@suse.com>
Date: Fri Aug 13 16:49:46 2021 +0200
libxenguest: fix off-by-1 in colo-secondary-bitmap merging
Valid GFNs (having a representation in the dirty bitmap) need to be
strictly below p2m_size.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
commit 1a838bf72584788310496ba5f3d865457c80727f
Author: Jan Beulich <jbeulich@suse.com>
Date: Fri Aug 13 16:49:10 2021 +0200
libxenguest: complete loops in xc_map_domain_meminfo()
minfo->p2m_size may have more than 31 significant bits. Change the
induction variable to unsigned long, and (largely for signed-ness
consistency) a helper variable to unsigned int. While there also avoid
open-coding min().
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
(qemu changes not included)
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-unstable test] 164237: regressions - FAIL
2021-08-19 3:07 [xen-unstable test] 164237: regressions - FAIL osstest service owner
@ 2021-08-19 12:06 ` Jan Beulich
2021-08-19 12:42 ` Ian Jackson
2021-08-19 12:45 ` Ian Jackson
0 siblings, 2 replies; 11+ messages in thread
From: Jan Beulich @ 2021-08-19 12:06 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel, osstest service owner
On 19.08.2021 05:07, osstest service owner wrote:
> flight 164237 xen-unstable real [real]
> flight 164246 xen-unstable real-retest [real]
> http://logs.test-lab.xenproject.org/osstest/logs/164237/
> http://logs.test-lab.xenproject.org/osstest/logs/164246/
>
> Regressions :-(
>
> Tests which did not succeed and are blocking,
> including tests which could not be run:
> test-amd64-amd64-amd64-pvgrub 12 debian-di-install fail REGR. vs. 164178
> test-amd64-amd64-i386-pvgrub 12 debian-di-install fail REGR. vs. 164178
Looks like this didn't sort itself (yet). Do you continue to be
convinced that it will, eventually?
Additionally I'm puzzled by these having been in the "are not
blocking" section up to flight 164202, and have since been in the
"are blocking" one.
Jan
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-unstable test] 164237: regressions - FAIL
2021-08-19 12:06 ` Jan Beulich
@ 2021-08-19 12:42 ` Ian Jackson
2021-08-19 12:45 ` Ian Jackson
1 sibling, 0 replies; 11+ messages in thread
From: Ian Jackson @ 2021-08-19 12:42 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel, osstest service owner
Jan Beulich writes ("Re: [xen-unstable test] 164237: regressions - FAIL"):
> Looks like this didn't sort itself (yet). Do you continue to be
> convinced that it will, eventually?
Indeed not. The error message is different now. The guest installer
reports
2021-08-18 18:14:09 Z 172.16.146.47:58906 <12>Aug 18 18:14:09
choose-mirror[2883]: WARNING **: broken mirror: invalid Suite in
Release file for jessie
which is bizarre. I didn't realise this test was using jessie,
which is ancient. These tests seem to be hardcoded to use jessie.
I'm going through the git history to see if I (or someone else) wrote
anything which might explai.
I suspect this might be obsolete pvgrub1.
> Additionally I'm puzzled by these having been in the "are not
> blocking" section up to flight 164202, and have since been in the
> "are blocking" one.
Probably, the Debian mirrors changed to drop jessie.
Ian.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-unstable test] 164237: regressions - FAIL
2021-08-19 12:06 ` Jan Beulich
2021-08-19 12:42 ` Ian Jackson
@ 2021-08-19 12:45 ` Ian Jackson
2021-08-19 13:05 ` Juergen Gross
2021-08-19 13:09 ` [xen-unstable test] 164237: regressions - FAIL Ian Jackson
1 sibling, 2 replies; 11+ messages in thread
From: Ian Jackson @ 2021-08-19 12:45 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel, Wei Liu, Juergen Gross
Jan Beulich writes ("Re: [xen-unstable test] 164237: regressions - FAIL"):
> Looks like this didn't sort itself (yet). Do you continue to be
> convinced that it will, eventually?
Hooray for explanations in commit messages.
I will (1) drop this test and (2) force push staging in the meantime.
Ian.
commit 6abb2f113025c37e3e5c6bb590b8e5f60c39a861
Author: Wei Liu <wei.liu2@citrix.com>
Date: Thu Nov 2 15:15:04 2017 +0000
make-flight: guest should use jessie to test pvgrub
stretch has 64bit feature enabled for ext4, which pvgrub can't cope.
We want to continue to test pvgrub, so specify jessie in the guest
suite field.
A consequence is that this test will test jessie forever. Eventually
jessie will rot so badly that this test fails and then we will no
longer be testing pvgrub1. Hopefully by then no-one will be using it.
CC: Juergen Gross <jgross@suse.com>
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-unstable test] 164237: regressions - FAIL
2021-08-19 12:45 ` Ian Jackson
@ 2021-08-19 13:05 ` Juergen Gross
2021-08-19 13:06 ` Ian Jackson
2021-08-19 13:24 ` Ian Jackson
2021-08-19 13:09 ` [xen-unstable test] 164237: regressions - FAIL Ian Jackson
1 sibling, 2 replies; 11+ messages in thread
From: Juergen Gross @ 2021-08-19 13:05 UTC (permalink / raw)
To: Ian Jackson, Jan Beulich; +Cc: xen-devel, Wei Liu
[-- Attachment #1.1.1: Type: text/plain, Size: 1343 bytes --]
On 19.08.21 14:45, Ian Jackson wrote:
> Jan Beulich writes ("Re: [xen-unstable test] 164237: regressions - FAIL"):
>> Looks like this didn't sort itself (yet). Do you continue to be
>> convinced that it will, eventually?
>
> Hooray for explanations in commit messages.
>
> I will (1) drop this test and (2) force push staging in the meantime.
>
> Ian.
>
> commit 6abb2f113025c37e3e5c6bb590b8e5f60c39a861
> Author: Wei Liu <wei.liu2@citrix.com>
> Date: Thu Nov 2 15:15:04 2017 +0000
>
> make-flight: guest should use jessie to test pvgrub
>
> stretch has 64bit feature enabled for ext4, which pvgrub can't cope.
> We want to continue to test pvgrub, so specify jessie in the guest
> suite field.
>
> A consequence is that this test will test jessie forever. Eventually
> jessie will rot so badly that this test fails and then we will no
> longer be testing pvgrub1. Hopefully by then no-one will be using it.
>
> CC: Juergen Gross <jgross@suse.com>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
Does this mean we should de-support pvgrub? Or even remove it?
BTW, I don't see any reason why someone would want to keep using pvgrub
with grub-pv being available...
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-unstable test] 164237: regressions - FAIL
2021-08-19 13:05 ` Juergen Gross
@ 2021-08-19 13:06 ` Ian Jackson
2021-08-19 13:24 ` Ian Jackson
1 sibling, 0 replies; 11+ messages in thread
From: Ian Jackson @ 2021-08-19 13:06 UTC (permalink / raw)
To: Juergen Gross; +Cc: Jan Beulich, xen-devel, Wei Liu
Juergen Gross writes ("Re: [xen-unstable test] 164237: regressions - FAIL"):
> Does this mean we should de-support pvgrub? Or even remove it?
I think so.
> BTW, I don't see any reason why someone would want to keep using pvgrub
> with grub-pv being available...
Precisely.
Ian.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [xen-unstable test] 164237: regressions - FAIL
2021-08-19 12:45 ` Ian Jackson
2021-08-19 13:05 ` Juergen Gross
@ 2021-08-19 13:09 ` Ian Jackson
1 sibling, 0 replies; 11+ messages in thread
From: Ian Jackson @ 2021-08-19 13:09 UTC (permalink / raw)
To: Ian Jackson; +Cc: Jan Beulich, xen-devel, Wei Liu, Juergen Gross
Ian Jackson writes ("Re: [xen-unstable test] 164237: regressions - FAIL"):
> I will (1) drop this test and (2) force push staging in the meantime.
Force pushed xen-unstable staging. osstest commit is below.
Ian.
From 8dee6e333622d830b7a9373989f63b526a85cd94 Mon Sep 17 00:00:00 2001
From: Ian Jackson <iwj@xenproject.org>
Date: Thu, 19 Aug 2021 13:46:21 +0100
Subject: [OSSTEST PATCH] make-flight: Drop pvgrub (pvgrub1) tests
This is obsolete. In 2017 in 6abb2f113025 we wrote:
A consequence is that this test will test jessie forever. Eventually
jessie will rot so badly that this test fails and then we will no
longer be testing pvgrub1. Hopefully by then no-one will be using it.
This has now occurred.
I have verified with
OSSTEST_CONFIG=standalone-config-example eatmydata ./standalone-generate-dump-flight-runvars
that the only change is to drop jobs test-amd64-amd64-*-pvgrub.
CC: Jan Beulich <jbeulich@suse.com>
CC: Juergen Gross <jgross@suse.com>
CC: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
make-flight | 25 -------------------------
1 file changed, 25 deletions(-)
diff --git a/make-flight b/make-flight
index fb38bc50..e0d11c80 100755
--- a/make-flight
+++ b/make-flight
@@ -598,30 +598,6 @@ do_pygrub_tests () {
all_hostflags=$most_hostflags
}
-do_pvgrub_tests () {
- if [ $xenarch != amd64 -o $dom0arch != amd64 -o "$kern" != "" ]; then
- return
- fi
-
- job_create_test test-$xenarch$kern-$dom0arch-amd64-pvgrub \
- test-debian-di xl $xenarch $dom0arch \
- debian_arch=amd64 \
- debian_suite=jessie \
- debian_di_version=`getconfig_TftpDiVersion_suite jessie` \
- debian_method=netboot \
- debian_bootloader=pvgrub \
- all_hostflags=$most_hostflags \
-
- job_create_test test-$xenarch$kern-$dom0arch-i386-pvgrub \
- test-debian-di xl $xenarch $dom0arch \
- debian_arch=i386 \
- debian_suite=jessie \
- debian_di_version=`getconfig_TftpDiVersion_suite jessie` \
- debian_method=netboot \
- debian_bootloader=pvgrub \
- all_hostflags=$most_hostflags
-}
-
do_pv_debian_test_one () {
testname=$1; shift
recipe_sfx=$1; shift
@@ -945,7 +921,6 @@ test_matrix_do_one () {
#do_passthrough_tests
do_pygrub_tests
- do_pvgrub_tests
do_shadow_tests
--
2.20.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [xen-unstable test] 164237: regressions - FAIL
2021-08-19 13:05 ` Juergen Gross
2021-08-19 13:06 ` Ian Jackson
@ 2021-08-19 13:24 ` Ian Jackson
2021-08-19 13:26 ` [PATCH] SUPPORT.md: Explicitly desupport pvgrub1; and support grub-pv Ian Jackson
1 sibling, 1 reply; 11+ messages in thread
From: Ian Jackson @ 2021-08-19 13:24 UTC (permalink / raw)
To: Juergen Gross; +Cc: Jan Beulich, xen-devel, Wei Liu
Juergen Gross writes ("Re: [xen-unstable test] 164237: regressions - FAIL"):
> Does this mean we should de-support pvgrub? Or even remove it?
>
> BTW, I don't see any reason why someone would want to keep using pvgrub
> with grub-pv being available...
I went to change its status in SUPPORT.md and it wasn't in evidence.
I guess you might still want it to boot old guests.
I don't think it has any security implications because it runs in
guest context.
I have prepared a patch to SUPPORT.md which I will send in a moemnt.
Ian.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] SUPPORT.md: Explicitly desupport pvgrub1; and support grub-pv
2021-08-19 13:24 ` Ian Jackson
@ 2021-08-19 13:26 ` Ian Jackson
2021-08-19 13:54 ` Juergen Gross
0 siblings, 1 reply; 11+ messages in thread
From: Ian Jackson @ 2021-08-19 13:26 UTC (permalink / raw)
To: xen-devel
Cc: iwj, Andrew Cooper, George Dunlap, Jan Beulich, Julien Grall,
Stefano Stabellini, Juergen Gross, Wei Liu
We can no longer conveniently even test pv-grub1; osstest tests for
this have just been dropped from all Xen branches
(by osstest.git#8dee6e333622).
This is without prejudice to its eventual removal. We should perhaps
proceed cautiously with that since it may be helpful for some old
guests.
Under the circumstances, I think this patch has to be a backport
candidate to all still-supported trees.
CC: Juergen Gross <jgross@suse.com>
CC: Jan Beulich <jbeulich@suse.com>,
CC: Wei Liu <wl@xen.org>
Backport-requested-by: Ian Jackson <iwj@xenproject.org>
Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
SUPPORT.md | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/SUPPORT.md b/SUPPORT.md
index 317392d8f3..9db027a85f 100644
--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -832,6 +832,28 @@ OVMF firmware implements the UEFI boot protocol.
Status, qemu-xen: Supported
+### grub-pv aka pvgrub2 (guest bootloader)
+
+ Status: Supported
+
+Support in upstream GRUB2 for running in Xen PV, to booting Xen PV
+guests.
+
+Collaboration (and security coordination) and fixes will be provided
+by the Xen Project, as needed.
+
+### x86/HVM pvgrub1 (aka stubdom pv-grub)
+
+ Status: Obsolescent, limited support
+
+GRUB1 compiled with minios and Xen stubdom, to run in guest context.
+This is provided in the Xen source distribution for the benefit of
+very old guests; it is no longer tested, but build and functionality
+fixes are welcome.
+
+pvgrub1 is not security-supported. However, it runs in guest context,
+so there should be no implications for host security.
+
# Format and definitions
This file contains prose, and machine-readable fragments.
--
2.20.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] SUPPORT.md: Explicitly desupport pvgrub1; and support grub-pv
2021-08-19 13:26 ` [PATCH] SUPPORT.md: Explicitly desupport pvgrub1; and support grub-pv Ian Jackson
@ 2021-08-19 13:54 ` Juergen Gross
2021-08-19 14:04 ` Ian Jackson
0 siblings, 1 reply; 11+ messages in thread
From: Juergen Gross @ 2021-08-19 13:54 UTC (permalink / raw)
To: Ian Jackson, xen-devel
Cc: Andrew Cooper, George Dunlap, Jan Beulich, Julien Grall,
Stefano Stabellini, Wei Liu
[-- Attachment #1.1.1: Type: text/plain, Size: 2099 bytes --]
On 19.08.21 15:26, Ian Jackson wrote:
> We can no longer conveniently even test pv-grub1; osstest tests for
> this have just been dropped from all Xen branches
> (by osstest.git#8dee6e333622).
>
> This is without prejudice to its eventual removal. We should perhaps
> proceed cautiously with that since it may be helpful for some old
> guests.
Probably, yes. OTOH keeping just old binaries should work without
any problem. This might be worth considering.
Especially as this would open up the path to drop the support of
32-bit libxenctrl/libxenguest support on 64-bit platforms in case we
want to got that route.
> Under the circumstances, I think this patch has to be a backport
> candidate to all still-supported trees.
>
> CC: Juergen Gross <jgross@suse.com>
> CC: Jan Beulich <jbeulich@suse.com>,
> CC: Wei Liu <wl@xen.org>
> Backport-requested-by: Ian Jackson <iwj@xenproject.org>
> Signed-off-by: Ian Jackson <iwj@xenproject.org>
> ---
> SUPPORT.md | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/SUPPORT.md b/SUPPORT.md
> index 317392d8f3..9db027a85f 100644
> --- a/SUPPORT.md
> +++ b/SUPPORT.md
> @@ -832,6 +832,28 @@ OVMF firmware implements the UEFI boot protocol.
>
> Status, qemu-xen: Supported
>
> +### grub-pv aka pvgrub2 (guest bootloader)
> +
> + Status: Supported
> +
> +Support in upstream GRUB2 for running in Xen PV, to booting Xen PV
> +guests.
> +
> +Collaboration (and security coordination) and fixes will be provided
> +by the Xen Project, as needed.
> +
> +### x86/HVM pvgrub1 (aka stubdom pv-grub)
s/HVM/PV/
> +
> + Status: Obsolescent, limited support
> +
> +GRUB1 compiled with minios and Xen stubdom, to run in guest context.
> +This is provided in the Xen source distribution for the benefit of
> +very old guests; it is no longer tested, but build and functionality
> +fixes are welcome.
> +
> +pvgrub1 is not security-supported. However, it runs in guest context,
> +so there should be no implications for host security.
> +
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] SUPPORT.md: Explicitly desupport pvgrub1; and support grub-pv
2021-08-19 13:54 ` Juergen Gross
@ 2021-08-19 14:04 ` Ian Jackson
0 siblings, 0 replies; 11+ messages in thread
From: Ian Jackson @ 2021-08-19 14:04 UTC (permalink / raw)
To: Juergen Gross
Cc: xen-devel, Andrew Cooper, George Dunlap, Jan Beulich,
Julien Grall, Stefano Stabellini, Wei Liu
Juergen Gross writes ("Re: [PATCH] SUPPORT.md: Explicitly desupport pvgrub1; and support grub-pv"):
> Probably, yes. OTOH keeping just old binaries should work without
> any problem. This might be worth considering.
Mmm.
> > +### x86/HVM pvgrub1 (aka stubdom pv-grub)
>
> s/HVM/PV/
Oops, fixed in my tree.
Ian.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-08-19 14:04 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-19 3:07 [xen-unstable test] 164237: regressions - FAIL osstest service owner
2021-08-19 12:06 ` Jan Beulich
2021-08-19 12:42 ` Ian Jackson
2021-08-19 12:45 ` Ian Jackson
2021-08-19 13:05 ` Juergen Gross
2021-08-19 13:06 ` Ian Jackson
2021-08-19 13:24 ` Ian Jackson
2021-08-19 13:26 ` [PATCH] SUPPORT.md: Explicitly desupport pvgrub1; and support grub-pv Ian Jackson
2021-08-19 13:54 ` Juergen Gross
2021-08-19 14:04 ` Ian Jackson
2021-08-19 13:09 ` [xen-unstable test] 164237: regressions - FAIL Ian Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.