From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99343C433F5 for ; Wed, 22 Dec 2021 19:44:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231352AbhLVTog (ORCPT ); Wed, 22 Dec 2021 14:44:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345311AbhLVToc (ORCPT ); Wed, 22 Dec 2021 14:44:32 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFC27C061574 for ; Wed, 22 Dec 2021 11:44:30 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id v7so6920173wrv.12 for ; Wed, 22 Dec 2021 11:44:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dCjrHpXu1Vo7I4rx8GmbmN8hEJq/k/PZV1K6n27kXVk=; b=bSSlZ3aH9FEGWUVzYQG9mKEMOxBNE7/T2bXPlBKZbxzhO9S2Z2J32F3JFPCuIQlfOo EzrW5Jny6H9NBAtnOPhBYd/fChsO41sQZTUqOwakHc82gQIbDAhx/X1HSxxosyTSelGe tmFMyNIS7xYEpcBviehq5HF+3xR13K2+oypvqo3B/VkYOSiakjCY3J+Ba6RwVJtEDnOP W6GbxzjxMNm/RoJl2lc19aPi4qEjgRrZi9sG+No47w/CiY+zYqMPsrFW929Q+EkH7KL5 CC8H2VOEXZ5YSjeRIfPJOBAuArrMR28tvtDuuS/xzLUPnSLHNr9/A+/zvxu7LVAhQiPo glnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dCjrHpXu1Vo7I4rx8GmbmN8hEJq/k/PZV1K6n27kXVk=; b=jng/aos4vPTo8SCUmtJceOhnwTR+VTMBRrpy2Nc4YuZmeS3XMYi1UNxFi5Ri6xskio hyWwBJjzazvsxBnWjJ480xRBL90AaKRRQfN81wHkGSA8W9A6ZI1KsyC9m6on755eqMNV jI8VdGPhN3sm8Fil7EWzMu3o5LpKD2PH72qWFDCmwdoLKC/sBY+v3ENK83Ck7ARUo/Lm DE4zGguVUmJrR/vQhRWtFgJ4iBL1FGOzsK2G+gyuDPaIUB022LCBXALs9cIAthcw+Wzi QLKLl6aWrMtlSJDR078jy5Xxjx5drIjSO56Se5G+ZX9bfjOsIpG736eQeO2bufkCgP// YYLA== X-Gm-Message-State: AOAM5338i8LhmHYrkCKgqMUrPhMrt2QfLDQPSGwslM5Yzr8FsuF9Am6g o6bDmudP8tDhLMEn61NJvU0= X-Google-Smtp-Source: ABdhPJxSwX0RyZXV/YBXj2EFbWxkfPas2TAbhpbHVlzdZLmZZ8hRCF0UKBxVVneoMV+Rl/taQPV5XA== X-Received: by 2002:a5d:59a6:: with SMTP id p6mr1126955wrr.559.1640202269582; Wed, 22 Dec 2021 11:44:29 -0800 (PST) Received: from archbook.localnet ([217.151.114.10]) by smtp.gmail.com with ESMTPSA id m12sm2991540wrp.49.2021.12.22.11.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Dec 2021 11:44:29 -0800 (PST) From: Nicolas Frattaroli To: Sascha Hauer , Rob Herring , linux-rockchip@lists.infradead.org Cc: dri-devel , linux-arm-kernel , "open list:ARM/Rockchip SoC..." , devicetree@vger.kernel.org, Sascha Hauer , Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis , Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH 08/22] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name Date: Wed, 22 Dec 2021 20:44:22 +0100 Message-ID: <2487063.3NWx74C5WQ@archbook> In-Reply-To: <8156864.jFcTpQmkuZ@diego> References: <20211220110630.3521121-1-s.hauer@pengutronix.de> <8156864.jFcTpQmkuZ@diego> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mittwoch, 22. Dezember 2021 20:39:58 CET Heiko St=FCbner wrote: > Am Mittwoch, 22. Dezember 2021, 14:52:51 CET schrieb Rob Herring: > > On Wed, Dec 22, 2021 at 6:47 AM Sascha Hauer w= rote: > > > > > > On Tue, Dec 21, 2021 at 10:31:23AM -0400, Rob Herring wrote: > > > > On Mon, Dec 20, 2021 at 12:06:16PM +0100, Sascha Hauer wrote: > > > > > "vpll" is a misnomer. A clock input to a device should be named a= fter > > > > > the usage in the device, not after the clock that drives it. On t= he > > > > > rk3568 the same clock is driven by the HPLL. > > > > > To fix that, this patch renames the vpll clock to ref clock. > > > > > > > > The problem with this series is it breaks an old kernel with new dt= =2E You > > > > can partially mitigate that with stable kernel backport, but IMO ke= eping > > > > the old name is not a burden to maintain. > > > > > > As suggested I only removed vpll from the binding document, but not f= rom > > > the code. The code still handles the old binding as well. > >=20 > > The problem is updating rk3399.dtsi. That change won't work with old > > kernels because they won't look for 'ref'. Since you shouldn't change > > it, the binding needs to cover both the old and new cases. >=20 > is "newer dt with old kernel" really a case these days? >=20 > I do understand the new kernel old dt case - for example with the > dtb being provided by firmware. >=20 > But which user would get the idea of updating only the devicetree > while staying with an older kernel? >=20 Side-by-side installations of LTS kernels with new kernels. LTS kernel uses same DT as new kernel because distribution set it up this way. Other scenario: user wants to modify their device tree. They download the latest kernel sources from kernel.org because they can't use over- lays and they don't want to fiddle with decompiled device trees. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4E7CC433F5 for ; Wed, 22 Dec 2021 19:44:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=57Nd4t7+iR27BsEDgHV3xbJ7m3fneJdCCiTrsjhmz8E=; b=fwIyHP4UilAIFk rk9U5Y4gq2pqhIgM7vmhM5Kq4bNFf8o2bY471RfY5J1moeiuR0NKnVTMEEpHOUsjFnIvNxasj1n1c rYh3kuciyiIaCjqpP+f23YHZvOiNt/HzJDUhhafQWe/F6BJxxNq4lENZm4quYWVfDOU9KmzbWXFRN Qj4gyzxVBz6Rsoxc7pbm0l9pT7OdLtyGl22T6xocK5Xr3VhIKfiSBUJ0IT+m7499saj9NMF3xOtHE 8XWsCZcykkazajrw3bZgWD69R1BVbqCh1VM1dv9IO8gBDEoF+v9cVrEUsHtfUkuKsegdclRTJvPn4 kLBa4vbPNgf0NJdCnJlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n07XO-00BGHu-Nn; Wed, 22 Dec 2021 19:44:34 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n07XL-00BGGt-E5; Wed, 22 Dec 2021 19:44:32 +0000 Received: by mail-wr1-x430.google.com with SMTP id q16so6988738wrg.7; Wed, 22 Dec 2021 11:44:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dCjrHpXu1Vo7I4rx8GmbmN8hEJq/k/PZV1K6n27kXVk=; b=bSSlZ3aH9FEGWUVzYQG9mKEMOxBNE7/T2bXPlBKZbxzhO9S2Z2J32F3JFPCuIQlfOo EzrW5Jny6H9NBAtnOPhBYd/fChsO41sQZTUqOwakHc82gQIbDAhx/X1HSxxosyTSelGe tmFMyNIS7xYEpcBviehq5HF+3xR13K2+oypvqo3B/VkYOSiakjCY3J+Ba6RwVJtEDnOP W6GbxzjxMNm/RoJl2lc19aPi4qEjgRrZi9sG+No47w/CiY+zYqMPsrFW929Q+EkH7KL5 CC8H2VOEXZ5YSjeRIfPJOBAuArrMR28tvtDuuS/xzLUPnSLHNr9/A+/zvxu7LVAhQiPo glnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dCjrHpXu1Vo7I4rx8GmbmN8hEJq/k/PZV1K6n27kXVk=; b=qjdJoVZRn5V1k1vfurfL5LennkjknA1hyH1YA4+tKGeGksJHQvwIN7TzkwGlFohk5g IaE8apRiKHdHpUIYtDz0cUJuDVtCxZmpq00+LCqC7kSQScKKkMtT+aCd7YcWC2fO9mZT YcWkvxTB7paJEwCG9cuhgaDtSxjfYQCHHiucx3sQMlgEi1UzXYlzZYk5ZtA56vIHOtyC iGzBZyTw36vG8COy/mbNyWHa6ZuZFsZU/Gh1Qn1BGaz7j2IKOBamEJKtq+g5xrlG8SH6 UU/X032ZvvOg7tU9aSCwW0A0vdPAlLOiNPx7s+ugcO/DWpjMwgM1vlaghk0mTQvls9WK hoCw== X-Gm-Message-State: AOAM532k1kPM2XoJ/bwbDAXDLBBnaQZ8VAFk6Q4k9wIBHc6PKu4Wa3ka k9fzBtx6G/bPO/Y8x1KbSig= X-Google-Smtp-Source: ABdhPJxSwX0RyZXV/YBXj2EFbWxkfPas2TAbhpbHVlzdZLmZZ8hRCF0UKBxVVneoMV+Rl/taQPV5XA== X-Received: by 2002:a5d:59a6:: with SMTP id p6mr1126955wrr.559.1640202269582; Wed, 22 Dec 2021 11:44:29 -0800 (PST) Received: from archbook.localnet ([217.151.114.10]) by smtp.gmail.com with ESMTPSA id m12sm2991540wrp.49.2021.12.22.11.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Dec 2021 11:44:29 -0800 (PST) From: Nicolas Frattaroli To: Sascha Hauer , Rob Herring , linux-rockchip@lists.infradead.org Cc: dri-devel , linux-arm-kernel , "open list:ARM/Rockchip SoC..." , devicetree@vger.kernel.org, Sascha Hauer , Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis , Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH 08/22] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name Date: Wed, 22 Dec 2021 20:44:22 +0100 Message-ID: <2487063.3NWx74C5WQ@archbook> In-Reply-To: <8156864.jFcTpQmkuZ@diego> References: <20211220110630.3521121-1-s.hauer@pengutronix.de> <8156864.jFcTpQmkuZ@diego> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211222_114431_499659_0F7AEB6C X-CRM114-Status: GOOD ( 24.54 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Mittwoch, 22. Dezember 2021 20:39:58 CET Heiko St=FCbner wrote: > Am Mittwoch, 22. Dezember 2021, 14:52:51 CET schrieb Rob Herring: > > On Wed, Dec 22, 2021 at 6:47 AM Sascha Hauer w= rote: > > > > > > On Tue, Dec 21, 2021 at 10:31:23AM -0400, Rob Herring wrote: > > > > On Mon, Dec 20, 2021 at 12:06:16PM +0100, Sascha Hauer wrote: > > > > > "vpll" is a misnomer. A clock input to a device should be named a= fter > > > > > the usage in the device, not after the clock that drives it. On t= he > > > > > rk3568 the same clock is driven by the HPLL. > > > > > To fix that, this patch renames the vpll clock to ref clock. > > > > > > > > The problem with this series is it breaks an old kernel with new dt= . You > > > > can partially mitigate that with stable kernel backport, but IMO ke= eping > > > > the old name is not a burden to maintain. > > > > > > As suggested I only removed vpll from the binding document, but not f= rom > > > the code. The code still handles the old binding as well. > > = > > The problem is updating rk3399.dtsi. That change won't work with old > > kernels because they won't look for 'ref'. Since you shouldn't change > > it, the binding needs to cover both the old and new cases. > = > is "newer dt with old kernel" really a case these days? > = > I do understand the new kernel old dt case - for example with the > dtb being provided by firmware. > = > But which user would get the idea of updating only the devicetree > while staying with an older kernel? > = Side-by-side installations of LTS kernels with new kernels. LTS kernel uses same DT as new kernel because distribution set it up this way. Other scenario: user wants to modify their device tree. They download the latest kernel sources from kernel.org because they can't use over- lays and they don't want to fiddle with decompiled device trees. _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75158C433F5 for ; Wed, 22 Dec 2021 19:44:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9B5F410E253; Wed, 22 Dec 2021 19:44:32 +0000 (UTC) Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by gabe.freedesktop.org (Postfix) with ESMTPS id 05E0E10E253 for ; Wed, 22 Dec 2021 19:44:31 +0000 (UTC) Received: by mail-wr1-x430.google.com with SMTP id r17so7015455wrc.3 for ; Wed, 22 Dec 2021 11:44:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dCjrHpXu1Vo7I4rx8GmbmN8hEJq/k/PZV1K6n27kXVk=; b=bSSlZ3aH9FEGWUVzYQG9mKEMOxBNE7/T2bXPlBKZbxzhO9S2Z2J32F3JFPCuIQlfOo EzrW5Jny6H9NBAtnOPhBYd/fChsO41sQZTUqOwakHc82gQIbDAhx/X1HSxxosyTSelGe tmFMyNIS7xYEpcBviehq5HF+3xR13K2+oypvqo3B/VkYOSiakjCY3J+Ba6RwVJtEDnOP W6GbxzjxMNm/RoJl2lc19aPi4qEjgRrZi9sG+No47w/CiY+zYqMPsrFW929Q+EkH7KL5 CC8H2VOEXZ5YSjeRIfPJOBAuArrMR28tvtDuuS/xzLUPnSLHNr9/A+/zvxu7LVAhQiPo glnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dCjrHpXu1Vo7I4rx8GmbmN8hEJq/k/PZV1K6n27kXVk=; b=j+Atovd9eHMoJQfHZw5A4jvcEKFQFvy/y6c+TzOTmTgFAAQGz+LS2yaFHiyPhamy7B Uojt3sAQ/yF+Wb82DwQQ3QbwqegNKXTMmN/UYZ95bb/WkEHtKNI/twQ8R91YDtwkh/ql v/LeEgrrfKB8N/0RwU4VrrTiN8Fz1uKwxsThu8FDLGMNu/1rsFfXh1tpT0pbu9pCpHnc m4uVn9zdSQ2FS9VUo9atHxPExEa31ZkHtPEmwqGstNsC+AdqtU6ZmyWq30aH91eCb4wq /nrwbT8Ruew6lF7n/vEcL5SlCSXn4zHHxnTLr1vir0GyLrsGERnORoV+QuCciatq2Piy YR4A== X-Gm-Message-State: AOAM530zv29MdBK7+RtyVSIb218uwxDgSz3VwytfzyY8vMNBH+v/XBGQ LRkb2Zpm8CJMDJRfiGwvwzN1leJKYU8= X-Google-Smtp-Source: ABdhPJxSwX0RyZXV/YBXj2EFbWxkfPas2TAbhpbHVlzdZLmZZ8hRCF0UKBxVVneoMV+Rl/taQPV5XA== X-Received: by 2002:a5d:59a6:: with SMTP id p6mr1126955wrr.559.1640202269582; Wed, 22 Dec 2021 11:44:29 -0800 (PST) Received: from archbook.localnet ([217.151.114.10]) by smtp.gmail.com with ESMTPSA id m12sm2991540wrp.49.2021.12.22.11.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Dec 2021 11:44:29 -0800 (PST) From: Nicolas Frattaroli To: Sascha Hauer , Rob Herring , linux-rockchip@lists.infradead.org Subject: Re: [PATCH 08/22] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name Date: Wed, 22 Dec 2021 20:44:22 +0100 Message-ID: <2487063.3NWx74C5WQ@archbook> In-Reply-To: <8156864.jFcTpQmkuZ@diego> References: <20211220110630.3521121-1-s.hauer@pengutronix.de> <8156864.jFcTpQmkuZ@diego> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Peter Geis , Sandy Huang , dri-devel , "open list:ARM/Rockchip SoC..." , Michael Riesch , Sascha Hauer , Andy Yan , linux-arm-kernel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mittwoch, 22. Dezember 2021 20:39:58 CET Heiko St=FCbner wrote: > Am Mittwoch, 22. Dezember 2021, 14:52:51 CET schrieb Rob Herring: > > On Wed, Dec 22, 2021 at 6:47 AM Sascha Hauer w= rote: > > > > > > On Tue, Dec 21, 2021 at 10:31:23AM -0400, Rob Herring wrote: > > > > On Mon, Dec 20, 2021 at 12:06:16PM +0100, Sascha Hauer wrote: > > > > > "vpll" is a misnomer. A clock input to a device should be named a= fter > > > > > the usage in the device, not after the clock that drives it. On t= he > > > > > rk3568 the same clock is driven by the HPLL. > > > > > To fix that, this patch renames the vpll clock to ref clock. > > > > > > > > The problem with this series is it breaks an old kernel with new dt= =2E You > > > > can partially mitigate that with stable kernel backport, but IMO ke= eping > > > > the old name is not a burden to maintain. > > > > > > As suggested I only removed vpll from the binding document, but not f= rom > > > the code. The code still handles the old binding as well. > >=20 > > The problem is updating rk3399.dtsi. That change won't work with old > > kernels because they won't look for 'ref'. Since you shouldn't change > > it, the binding needs to cover both the old and new cases. >=20 > is "newer dt with old kernel" really a case these days? >=20 > I do understand the new kernel old dt case - for example with the > dtb being provided by firmware. >=20 > But which user would get the idea of updating only the devicetree > while staying with an older kernel? >=20 Side-by-side installations of LTS kernels with new kernels. LTS kernel uses same DT as new kernel because distribution set it up this way. Other scenario: user wants to modify their device tree. They download the latest kernel sources from kernel.org because they can't use over- lays and they don't want to fiddle with decompiled device trees. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A0BBC433F5 for ; Wed, 22 Dec 2021 19:45:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uZB2bYRBNZAH1GeN9Y1dRoQUhWVxnyvoL4QJryCna20=; b=Swn2+GO4snhVxB 6uagtdUsfVdioRjeuU/ebVkosycwzUtn3RayYpU5LMyZ+ZiihNPBuNLMXCRwbHHENiPQWhTKY0Qx3 bfWkKeQwDjBDupHXd6Y+muy5POnZHKniwwrAvCjW3HcWmuyjfZ89PkwZFTBIxvOPHhpuMsinWROCs chtBnk/qQ3nVL20BkFsgzwDDC4Mspmy0dTrYbmPtf43r7VTGumLCX7kIsl1QacnfZ534Cvkha/4w0 vdmQ9tGMIfquqHW4zD5u4bJD4kvEkWKrUN6dA5VIVHi+zVgfXXcmYmof4ssktHGKrAt6lEh2NdCu0 WmPJGe9SNlu1Z99Trb4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n07XQ-00BGI7-7k; Wed, 22 Dec 2021 19:44:36 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n07XL-00BGGt-E5; Wed, 22 Dec 2021 19:44:32 +0000 Received: by mail-wr1-x430.google.com with SMTP id q16so6988738wrg.7; Wed, 22 Dec 2021 11:44:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dCjrHpXu1Vo7I4rx8GmbmN8hEJq/k/PZV1K6n27kXVk=; b=bSSlZ3aH9FEGWUVzYQG9mKEMOxBNE7/T2bXPlBKZbxzhO9S2Z2J32F3JFPCuIQlfOo EzrW5Jny6H9NBAtnOPhBYd/fChsO41sQZTUqOwakHc82gQIbDAhx/X1HSxxosyTSelGe tmFMyNIS7xYEpcBviehq5HF+3xR13K2+oypvqo3B/VkYOSiakjCY3J+Ba6RwVJtEDnOP W6GbxzjxMNm/RoJl2lc19aPi4qEjgRrZi9sG+No47w/CiY+zYqMPsrFW929Q+EkH7KL5 CC8H2VOEXZ5YSjeRIfPJOBAuArrMR28tvtDuuS/xzLUPnSLHNr9/A+/zvxu7LVAhQiPo glnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dCjrHpXu1Vo7I4rx8GmbmN8hEJq/k/PZV1K6n27kXVk=; b=qjdJoVZRn5V1k1vfurfL5LennkjknA1hyH1YA4+tKGeGksJHQvwIN7TzkwGlFohk5g IaE8apRiKHdHpUIYtDz0cUJuDVtCxZmpq00+LCqC7kSQScKKkMtT+aCd7YcWC2fO9mZT YcWkvxTB7paJEwCG9cuhgaDtSxjfYQCHHiucx3sQMlgEi1UzXYlzZYk5ZtA56vIHOtyC iGzBZyTw36vG8COy/mbNyWHa6ZuZFsZU/Gh1Qn1BGaz7j2IKOBamEJKtq+g5xrlG8SH6 UU/X032ZvvOg7tU9aSCwW0A0vdPAlLOiNPx7s+ugcO/DWpjMwgM1vlaghk0mTQvls9WK hoCw== X-Gm-Message-State: AOAM532k1kPM2XoJ/bwbDAXDLBBnaQZ8VAFk6Q4k9wIBHc6PKu4Wa3ka k9fzBtx6G/bPO/Y8x1KbSig= X-Google-Smtp-Source: ABdhPJxSwX0RyZXV/YBXj2EFbWxkfPas2TAbhpbHVlzdZLmZZ8hRCF0UKBxVVneoMV+Rl/taQPV5XA== X-Received: by 2002:a5d:59a6:: with SMTP id p6mr1126955wrr.559.1640202269582; Wed, 22 Dec 2021 11:44:29 -0800 (PST) Received: from archbook.localnet ([217.151.114.10]) by smtp.gmail.com with ESMTPSA id m12sm2991540wrp.49.2021.12.22.11.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Dec 2021 11:44:29 -0800 (PST) From: Nicolas Frattaroli To: Sascha Hauer , Rob Herring , linux-rockchip@lists.infradead.org Cc: dri-devel , linux-arm-kernel , "open list:ARM/Rockchip SoC..." , devicetree@vger.kernel.org, Sascha Hauer , Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis , Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH 08/22] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name Date: Wed, 22 Dec 2021 20:44:22 +0100 Message-ID: <2487063.3NWx74C5WQ@archbook> In-Reply-To: <8156864.jFcTpQmkuZ@diego> References: <20211220110630.3521121-1-s.hauer@pengutronix.de> <8156864.jFcTpQmkuZ@diego> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211222_114431_499659_0F7AEB6C X-CRM114-Status: GOOD ( 24.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mittwoch, 22. Dezember 2021 20:39:58 CET Heiko St=FCbner wrote: > Am Mittwoch, 22. Dezember 2021, 14:52:51 CET schrieb Rob Herring: > > On Wed, Dec 22, 2021 at 6:47 AM Sascha Hauer w= rote: > > > > > > On Tue, Dec 21, 2021 at 10:31:23AM -0400, Rob Herring wrote: > > > > On Mon, Dec 20, 2021 at 12:06:16PM +0100, Sascha Hauer wrote: > > > > > "vpll" is a misnomer. A clock input to a device should be named a= fter > > > > > the usage in the device, not after the clock that drives it. On t= he > > > > > rk3568 the same clock is driven by the HPLL. > > > > > To fix that, this patch renames the vpll clock to ref clock. > > > > > > > > The problem with this series is it breaks an old kernel with new dt= . You > > > > can partially mitigate that with stable kernel backport, but IMO ke= eping > > > > the old name is not a burden to maintain. > > > > > > As suggested I only removed vpll from the binding document, but not f= rom > > > the code. The code still handles the old binding as well. > > = > > The problem is updating rk3399.dtsi. That change won't work with old > > kernels because they won't look for 'ref'. Since you shouldn't change > > it, the binding needs to cover both the old and new cases. > = > is "newer dt with old kernel" really a case these days? > = > I do understand the new kernel old dt case - for example with the > dtb being provided by firmware. > = > But which user would get the idea of updating only the devicetree > while staying with an older kernel? > = Side-by-side installations of LTS kernels with new kernels. LTS kernel uses same DT as new kernel because distribution set it up this way. Other scenario: user wants to modify their device tree. They download the latest kernel sources from kernel.org because they can't use over- lays and they don't want to fiddle with decompiled device trees. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel