From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BB56C83028 for ; Thu, 2 Sep 2021 17:04:54 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28FED61051 for ; Thu, 2 Sep 2021 17:04:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 28FED61051 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.177585.323106 (Exim 4.92) (envelope-from ) id 1mLq8o-0006ob-MV; Thu, 02 Sep 2021 17:04:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177585.323106; Thu, 02 Sep 2021 17:04:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLq8o-0006oU-Ji; Thu, 02 Sep 2021 17:04:42 +0000 Received: by outflank-mailman (input) for mailman id 177585; Thu, 02 Sep 2021 17:04:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLq8m-0006oO-Du for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 17:04:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLq8m-0001Du-Bo for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 17:04:40 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1mLq8m-0007tR-An for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 17:04:40 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1mLq8h-0003Xd-Jy; Thu, 02 Sep 2021 18:04:35 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=EwrkcWG+KtHbspcp5DkvRxCnd1eWWHv+1cIErtfTVjg=; b=bDDDwbvXfOyL/MbBT9A/njs4zb em1e437Z8ewV8Lv6fGTbNJIZomyxOWXWYlm//NqfiS7MRZdRoeta/VN1GRMWGndWGkp+Ejq5SVvtT h5YmeOcJJ0DTtUGyR2/0eARjqYU+oV8vVR/yj7yjFffgKAyXKJUB0ro9395wQ1BLQ758=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24881.1059.344754.415908@mariner.uk.xensource.com> Date: Thu, 2 Sep 2021 18:04:35 +0100 To: Juergen Gross Cc: Jan Beulich , "xen-devel\@lists.xenproject.org" , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , George Dunlap , Anthony Perard , Marek Marczykowski Subject: Re: [PATCH v2 02/13] libxc: split xc_logdirty_control() from xc_shadow_control() [and 1 more messages] In-Reply-To: <7284e7d0-99cc-e35d-2d44-46e7a3132498@suse.com>, References: <0bebfe8c-6897-dc8b-7fe0-9127d4996eb8@suse.com> <4b68233b-259c-3308-3292-82e991e1e108@suse.com> <7284e7d0-99cc-e35d-2d44-46e7a3132498@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Juergen Gross writes ("Re: [PATCH v2 02/13] libxc: split xc_logdirty_control() from xc_shadow_control()"): > On 05.07.21 17:12, Jan Beulich wrote: > >>> +long long xc_logdirty_control(xc_interface *xch, > >>> + uint32_t domid, > >>> + unsigned int sop, > >>> + xc_hypercall_buffer_t *dirty_bitmap, > >>> + unsigned long pages, > >>> + unsigned int mode, > >>> + xc_shadow_op_stats_t *stats) > >>> +{ > >>> + int rc; > >>> + struct xen_domctl domctl = { > >>> + .cmd = XEN_DOMCTL_shadow_op, > >>> + .domain = domid, > >>> + .u.shadow_op = { > >>> + .op = sop, > >> > >> And same here the other way round: sop should really only be one of > >> XEN_DOMCTL_SHADOW_OP_CLEAN or XEN_DOMCTL_SHADOW_OP_PEEK. > >> > >> With that fixed you can add my: > >> > >> Reviewed-by: Juergen Gross > > > > Thanks, but I won't take this just yet, awaiting your (and maybe > > others') view(s) on my reply above. > > I'm not feeling really strong in this regard. Either way is fine for > me. OK. My understanding then is that you are happy with Jan's patch and he can add the Reviewed-by even though he's not checking the ops. Is that right ? If so, then Jan, please add my Acked-by: Ian Jackson along with Juergen's review. If I have misunderstood please explain :-). Thanks, Ian.