All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: u-boot@lists.denx.de, Jagan Teki <jagan@amarulasolutions.com>,
	Priyanka Jain <priyanka.jain@nxp.com>,
	Tom Rini <trini@konsulko.com>,
	Peter Griffin <peter.griffin@linaro.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH v2 8/9] arm: dts: ls1028a: sync the fsl-ls1028a.dtsi with linux
Date: Wed, 01 Sep 2021 14:05:34 +0200	[thread overview]
Message-ID: <248b3bb606fa9a073a98adc0748656ad@walle.cc> (raw)
In-Reply-To: <20210901115554.2zlfcfc4m6ymxwfx@skbuf>

Am 2021-09-01 13:55, schrieb Vladimir Oltean:
> On Wed, Sep 01, 2021 at 01:51:53PM +0200, Michael Walle wrote:
>> Yes but that is on purpose. In the current u-boot device tree, it was
>> disabled, but the boards reenabled them again. So it didn't matter.
>> 
>> I want to have a specific sync point (that is the v5.14 tag) for the
>> .dtsi. At least where possible; for phy-mode and so on I needed to to
>> take additional patches which weren't picked up in linux yet, but
>> these just affect the sl28 board device trees.
> 
> Binary compatibility is one thing and I can understand it.
> Textual compatibility, down to label names, and where the device is
> being disabled from? Hmmmm, I'm having a hard time saying yes to that.

It's a step back, yes. But only until v5.16 (I don't think the changes
will make it during the merge window). I guess you are concerned because
of your vendor fork? Mh, well actually I don't understand your concert,
because your tree isn't compatible anyway if we change the labels.

We'd trade the clear information where the device tree is from for
something that - in my opinion - is not worth it. I mean the device
tree (source) is used just here in u-boot for these three boards and
all have the usb nodes enabled.

> (btw I finished reviewing this patch, I have no other comments)

thanks for the efforts!

-michael

  reply	other threads:[~2021-09-01 12:05 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01  8:55 [PATCH v2 0/9] arm: dts: ls1028a: sync device tree with linux Michael Walle
2021-09-01  8:55 ` [PATCH v2 1/9] armv8: ls1028a: add IOMMU stream ID to vivante node Michael Walle
2021-09-01  8:55 ` [PATCH v2 2/9] arm: dts: ls1028a: move devices into /soc Michael Walle
2021-09-01 10:05   ` Vladimir Oltean
2021-09-01  8:55 ` [PATCH v2 3/9] arm: dts: ls1028a: remove /memory node Michael Walle
2021-09-01  8:55 ` [PATCH v2 4/9] arm: dts: ls1028a: update the labels Michael Walle
2021-09-01 10:07   ` Vladimir Oltean
2021-09-01  8:55 ` [PATCH v2 5/9] watchdog: sp805_wdt: use correct compatible string Michael Walle
2021-09-01  8:55 ` [PATCH v2 6/9] spi: fsl_dspi: add new compatible fsl, ls1021a-v1.0-dspi Michael Walle
2021-09-01  8:55 ` [PATCH v2 7/9] serial: lpuart: add new compatible fsl,ls1028a-lpuart Michael Walle
2021-09-01  8:55 ` [PATCH v2 8/9] arm: dts: ls1028a: sync the fsl-ls1028a.dtsi with linux Michael Walle
2021-09-01 10:29   ` Vladimir Oltean
2021-09-01 21:34     ` Michael Walle
2021-09-01 21:59       ` Vladimir Oltean
2021-09-06  8:37         ` Michael Walle
2021-09-01 11:24   ` Vladimir Oltean
2021-09-01 11:51     ` Michael Walle
2021-09-01 11:55       ` Vladimir Oltean
2021-09-01 12:05         ` Michael Walle [this message]
2021-09-01 12:21           ` Vladimir Oltean
2021-09-01 12:38             ` Michael Walle
2021-09-01 12:57               ` Vladimir Oltean
2021-09-01 13:30                 ` Michael Walle
2021-09-01 21:38                   ` Tom Rini
2021-09-01 11:27   ` Vladimir Oltean
2021-09-01 14:51     ` Michael Walle
2021-09-01 11:43   ` Vladimir Oltean
2021-09-01 11:46     ` Michael Walle
2021-09-01  8:55 ` [PATCH v2 9/9] arm: dts: sl28: sync dtbs Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=248b3bb606fa9a073a98adc0748656ad@walle.cc \
    --to=michael@walle.cc \
    --cc=jagan@amarulasolutions.com \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=peter.griffin@linaro.org \
    --cc=priyanka.jain@nxp.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.