From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 878EFC433F5 for ; Thu, 7 Oct 2021 10:54:02 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40C6461058 for ; Thu, 7 Oct 2021 10:54:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 40C6461058 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.203467.358595 (Exim 4.92) (envelope-from ) id 1mYR28-0001I6-RB; Thu, 07 Oct 2021 10:53:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 203467.358595; Thu, 07 Oct 2021 10:53:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mYR28-0001Hz-OG; Thu, 07 Oct 2021 10:53:52 +0000 Received: by outflank-mailman (input) for mailman id 203467; Thu, 07 Oct 2021 10:53:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mYR27-0001Ht-Mf for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 10:53:51 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mYR27-000158-Lz for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 10:53:51 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1mYR27-0003bW-Kz for xen-devel@lists.xenproject.org; Thu, 07 Oct 2021 10:53:51 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1mYR22-0006AI-Tw; Thu, 07 Oct 2021 11:53:46 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=5r18isox69HWOlErqX6kicas+rMNkHHt/kdttCLlODU=; b=zTA1T0J1SAS4bUTCgw3eKcLe/i DTAa0F6eBPSjFTB+DLX15mjMKJCVKNhMOgLYwFdRUpnf4WaVkJzUwvhuLfEs8ky701Y4SD3vQBYF0 p7BtGloIGhSgRwtzMoDW/KI4gtNvmWD9IypEGRtSnBta13j4+51VNqmn26GQxsKaT9vs=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24926.53690.621007.507249@mariner.uk.xensource.com> Date: Thu, 7 Oct 2021 11:53:46 +0100 To: Julien Grall Cc: Rahul Singh , xen-devel@lists.xenproject.org, bertrand.marquis@arm.com, Andre.Przywara@arm.com, Wei Liu , Anthony PERARD , Juergen Gross , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl In-Reply-To: <7bdac405-a889-15e1-be19-5876f7253855@xen.org> References: <7bdac405-a889-15e1-be19-5876f7253855@xen.org> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("Re: [PATCH v5 10/11] arm/libxl: Emulated PCI device tree node in libxl"): > On 06/10/2021 19:40, Rahul Singh wrote: > > diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl > > index 3f9fff653a..78b1ddf0b8 100644 > > --- a/tools/libs/light/libxl_types.idl > > +++ b/tools/libs/light/libxl_types.idl > > @@ -644,6 +644,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ > > > > ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), > > ("vuart", libxl_vuart_type), > > + ("vpci", libxl_defbool), > > I have posted some comments regarding the field in v4. To summarize, > AFAICT, this option is meant to be only set by libxl but you still let > the toolstack (e.g. xl, libvirt) to set it. > > If you still want to expose to the toolstack, then I think the option > should be outside of arch_arm. Otherwise, this should be moved in an > internal structure (Ian, do you have any suggestion?). If it should be in an internal structure, probably the libxl create context. But I'm not convinced yet. In particular, if enabling VPCI is necessary on ARM for hotplugged PCI devices[1], then there has to be a way for the admin to say "while this domain may not have any PCI devices right now, I may wish to hotplug some". That's what the "passthrough=" option is for. See my other mail. [1] I think this is all true even if PCI hotplug for ARM is not currently implemented. Ian.