From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC046C2D0E4 for ; Fri, 27 Nov 2020 13:47:33 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E304221EB for ; Fri, 27 Nov 2020 13:47:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="Dv1Zs2bV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E304221EB Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.39377.72256 (Exim 4.92) (envelope-from ) id 1kie5W-0002FD-Rq; Fri, 27 Nov 2020 13:47:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 39377.72256; Fri, 27 Nov 2020 13:47:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kie5W-0002F6-Nr; Fri, 27 Nov 2020 13:47:02 +0000 Received: by outflank-mailman (input) for mailman id 39377; Fri, 27 Nov 2020 13:47:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kie5W-0002F1-3q for xen-devel@lists.xenproject.org; Fri, 27 Nov 2020 13:47:02 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 37eb4911-a61d-4333-97d0-805bc0880c2d; Fri, 27 Nov 2020 13:47:01 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 965C0ABD7; Fri, 27 Nov 2020 13:47:00 +0000 (UTC) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kie5W-0002F1-3q for xen-devel@lists.xenproject.org; Fri, 27 Nov 2020 13:47:02 +0000 X-Inumbo-ID: 37eb4911-a61d-4333-97d0-805bc0880c2d Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 37eb4911-a61d-4333-97d0-805bc0880c2d; Fri, 27 Nov 2020 13:47:01 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1606484820; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AH8MLbQO+xGAs2wywTgpXKp3VgDz6169LTuoob1JGIc=; b=Dv1Zs2bVsDa3vvJuHpPqTcJRLGCzPYwSI9W3Yv+T8NuKXjSBR0gnYcCuOyQ/I+4Pp7MhnR nSrlgnOY3IBHPpa+PXz8jHCwWyLmWI9TDXGhP6yrbwjeiYTNoKXBL26ba5+pgvb4XIHHS5 YZRMmLOp0ZCRFcIstuhcFCqShOX+ub8= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 965C0ABD7; Fri, 27 Nov 2020 13:47:00 +0000 (UTC) Subject: Re: [PATCH v4 2/3] xen/pci: solve compilation error on ARM with HAS_PCI enabled. To: Bertrand Marquis , Rahul Singh Cc: "xen-devel@lists.xenproject.org" , Paul Durrant References: <2ce402cfae6d90433626bcdc6314e5ee5dda103f.1606326929.git.rahul.singh@arm.com> From: Jan Beulich Message-ID: <24926459-3f9f-0481-c5a3-9d6f36401346@suse.com> Date: Fri, 27 Nov 2020 14:47:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 26.11.2020 10:05, Bertrand Marquis wrote: > > >> On 25 Nov 2020, at 18:16, Rahul Singh wrote: >> >> If mem-sharing, mem-paging, or log-dirty functionality is not enabled >> for architecture when HAS_PCI is enabled, the compiler will throw an >> error. >> >> Move code to x86 specific file to fix compilation error. >> >> Also, modify the code to use likely() in place of unlikley() for each >> condition to make code more optimized. >> >> No functional change intended. >> >> Signed-off-by: Rahul Singh > Reviewed-by: Bertrand Marquis > > I guess the small typo fix could be fixed by the commiter directly :-) Indeed, and with it Acked-by: Jan Beulich Jan