From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7115C433EF for ; Thu, 28 Oct 2021 15:55:29 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9221A610CA for ; Thu, 28 Oct 2021 15:55:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9221A610CA Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.218164.378482 (Exim 4.92) (envelope-from ) id 1mg7k9-0005iQ-EN; Thu, 28 Oct 2021 15:55:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 218164.378482; Thu, 28 Oct 2021 15:55:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mg7k9-0005iJ-BA; Thu, 28 Oct 2021 15:55:05 +0000 Received: by outflank-mailman (input) for mailman id 218164; Thu, 28 Oct 2021 15:55:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mg7k7-0005iD-VJ for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 15:55:03 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mg7k7-0002MB-Sx for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 15:55:03 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1mg7k7-0003lf-S6 for xen-devel@lists.xenproject.org; Thu, 28 Oct 2021 15:55:03 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1mg7k2-0002Zf-AA; Thu, 28 Oct 2021 16:54:58 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=XKsSmWH6fEEInPTeowmJjPBExAxFn3B2Cx2v8gh8Gkc=; b=WCdg6XN8g1xt9YEd1SV+H7e3fM f4IU2LpRnVcaMxjk11V/hr/H2kkGz5uJnxWlCmkN5GXudtKXFdhMFn5LqdY65SaBdkIY/dDSN/nW7 wxwSsyt3AOloIfwDQdKOnC3vgj+SBgxdSHdazDtz+SGrbXXqW129oXVIYoUaKA88cb2o=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24954.51153.588540.850154@mariner.uk.xensource.com> Date: Thu, 28 Oct 2021 16:54:57 +0100 To: Julien Grall Cc: Oleksandr Andrushchenko , "xen-devel\@lists.xenproject.org" , "sstabellini\@kernel.org" , "iwj\@xenproject.org" , Bertrand Marquis , Rahul Singh Subject: Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers In-Reply-To: References: <20211027082533.1406015-1-andr2000@gmail.com> <65886734-7333-4469-fcc1-6916db708f13@xen.org> <6d8f1061-7aec-2c1a-aaf4-c30440c2797a@xen.org> <38da2edd-06a2-63d0-51ad-1284272c8da5@epam.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Julien Grall writes ("Re: [PATCH] xen/arm: fix SBDF calculation for vPCI MMIO handlers"): > On 28/10/2021 16:27, Oleksandr Andrushchenko wrote: > > bridge as private and using info->gpa - GUEST_VPCI_ECAM_BASE... > > So, I would stay with simpler > > > >     if ( bridge ) > >        { > >            sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - bridge->cfg->phys_addr); > >            sbdf.seg = bridge->segment; > >        } > >        else > >            sbdf.sbdf = VPCI_ECAM_BDF(info->gpa - GUEST_VPCI_ECAM_BASE); > > I am fine with that so long this is part of an helper (maybe > vpci_sbdf_from_addr()) rather than duplicated. There are a number of patches that I'm getting CC'd on related to ARM and vpci (according to the Subject). Are these targeted for 4.16 ? Most of them don't have 4.16 Subject tags. Am I getting these in my capacity as a REST maintainer ? I am finding it difficult to see the wood for the trees. It would be really helpful if these vpci fixes were collected together into a series. Thanks, Ian. (writing as Xen 4.16 Release Manager)