From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC3B8C433F5 for ; Fri, 19 Nov 2021 14:26:07 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84FC661549 for ; Fri, 19 Nov 2021 14:26:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 84FC661549 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.228059.394549 (Exim 4.92) (envelope-from ) id 1mo4pw-0003li-TG; Fri, 19 Nov 2021 14:25:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 228059.394549; Fri, 19 Nov 2021 14:25:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mo4pw-0003lb-Ol; Fri, 19 Nov 2021 14:25:56 +0000 Received: by outflank-mailman (input) for mailman id 228059; Fri, 19 Nov 2021 14:25:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mo4pv-0003lR-EE for xen-devel@lists.xenproject.org; Fri, 19 Nov 2021 14:25:55 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mo4pv-0000xV-DW for xen-devel@lists.xenproject.org; Fri, 19 Nov 2021 14:25:55 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1mo4pv-0000ut-Ca for xen-devel@lists.xenproject.org; Fri, 19 Nov 2021 14:25:55 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1mo4pr-0005eV-RG; Fri, 19 Nov 2021 14:25:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=KHW3S0IHaNV919e5kFrVOklnNu0dgoO9Q2dd+EFUpDs=; b=5o/yO5/OuiP153Hbs0ovejMc7U dfcLuFM5NERyF5tDRoIYNT3BVEaTMLAO6AfZnxi0YQBe/UJK2AUEeAtixxfSO8PeI7My7R4zy6HVx KJ38i/z4QNf8XARC4r//70tRs3UOwosjOf1jKGgxeVFAcDiJex5TTNuFl5XcZMEdDS0s=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24983.46063.379168.151942@mariner.uk.xensource.com> Date: Fri, 19 Nov 2021 14:25:51 +0000 To: Jan Beulich Cc: "xen-devel\@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH 0/7] (mainly) xz imports from Linux In-Reply-To: References: X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("[PATCH 0/7] (mainly) xz imports from Linux"): > While going through their 5.15.3 log I did notice two changes, which made > me go check what else we might be missing. The series here is the result. > Linux has also updated zstd, but that includes a pretty large change which > I'm not ready to deal with right now. Them moving closer to the upstream > zstd sources is certainly a good thing, so I suppose sooner or later we > will want to follow them in doing so. > > 1: xz: add fall-through comments to a switch statement > 2: xz: fix XZ_DYNALLOC to avoid useless memory reallocations > 3: decompressors: fix spelling mistakes > 4: xz: avoid overlapping memcpy() with invalid input with in-place decompression > 5: xz: fix spelling in comments > 6: xz: move s->lzma.len = 0 initialization to lzma_reset() > 7: xz: validate the value before assigning it to an enum variable FTAOD I think none of these are critical bug fixes for 4.16. Please let me know if I'm wrong. In theory 4 is UB but in practice the result is presumably just wrong answers. Ian.