All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dr. Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] rockchip: rk3288: update the mmc number for fastboot
Date: Thu, 27 Jul 2017 14:16:24 +0200	[thread overview]
Message-ID: <24A5C43D-2A1A-42C5-A136-0706EDF55272@theobroma-systems.com> (raw)
In-Reply-To: <1501156079-17854-1-git-send-email-kever.yang@rock-chips.com>

Kever,

> On 27 Jul 2017, at 13:47, Kever Yang <kever.yang@rock-chips.com> wrote:
> 
> The emmc number is 0, correct it for fastboot parameter.

I provided some code in rk3399-board-spl.c (commit d02d11f8; see
spl_node_to_boot_device(…) and how 'desc->devnum’ is accessed there)
to map from a of_node back to a device-number.

Could you do something similar for the fastboot case, so we can have a DTS
property (e.g. under /config or /chosen) to map back to the devnum on a
per-board basis?

> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
> include/configs/rk3288_common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/configs/rk3288_common.h b/include/configs/rk3288_common.h
> index 488d679..4489323 100644
> --- a/include/configs/rk3288_common.h
> +++ b/include/configs/rk3288_common.h
> @@ -66,7 +66,7 @@
> #define CONFIG_CMD_FASTBOOT
> #define CONFIG_USB_FUNCTION_FASTBOOT
> #define CONFIG_FASTBOOT_FLASH
> -#define CONFIG_FASTBOOT_FLASH_MMC_DEV	1	/* eMMC */
> +#define CONFIG_FASTBOOT_FLASH_MMC_DEV	0	/* eMMC */
> #define CONFIG_FASTBOOT_BUF_ADDR	CONFIG_SYS_LOAD_ADDR
> #define CONFIG_FASTBOOT_BUF_SIZE	0x08000000
> 
> -- 
> 1.9.1
> 

  reply	other threads:[~2017-07-27 12:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-27 11:47 [U-Boot] [PATCH] rockchip: rk3288: update the mmc number for fastboot Kever Yang
2017-07-27 12:16 ` Dr. Philipp Tomsich [this message]
2017-07-27 13:04   ` Kever Yang
2017-07-27 13:09     ` Dr. Philipp Tomsich
2017-08-17  7:51       ` Kever Yang
2017-08-17  8:27         ` Dr. Philipp Tomsich
2017-08-21  5:05           ` Kever Yang
2017-08-04 22:43 ` [U-Boot] " Philipp Tomsich
2017-09-05  9:19 ` Philipp Tomsich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24A5C43D-2A1A-42C5-A136-0706EDF55272@theobroma-systems.com \
    --to=philipp.tomsich@theobroma-systems.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.