From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Tomsich Date: Thu, 3 Jan 2019 22:36:23 +0100 Subject: [U-Boot] [PATCH 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now[Please note, mail behalf by 3vnmnxammciszqnjoyvtpbt.vynrlcly.fhunyvjr-jopwz.jvt@chromium-sendgmr.bounces.google.com] In-Reply-To: References: <20181229131641.131209-1-sjg@chromium.org> <20181229131641.131209-2-sjg@chromium.org> Message-ID: <24E33E40-E24E-4541-8EA1-25FE1390297C@theobroma-systems.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de > On 03.01.2019, at 22:29, Simon Glass wrote: >=20 > Hi, >=20 > On Thu, 3 Jan 2019 at 00:32, Kever Yang > wrote: >>=20 >> Hi Simon, >>=20 >>=20 >> On 12/29/2018 09:16 PM, Simon Glass wrote: >>> This function causes a 5-second delay and stops the display working on >>> minnie. >>=20 >> I don't understand why need 5-second, the logic is to check the adc key >> press to decide the mode, maybe because the different usage of the adc >> in minnie? >>=20 >> Most of boards(which do not have ec like chromebook) need this check to >> get into download mode. >> I would prefer chrombook to implement a function to replace the week >> rockchip_dnl_mode_check(); >=20 > But where is it specified in the DT that it uses the ADC for this > feature? It really should have a driver=E2=80=A6 3 things: a. It really should have a driver. b. One does not have to replace rockchip_dnl_mode_check(), as there already is logic to remove it if CONFIG_ROCKCHIP_BOOT_MODE_REG is set to 0 in the config. c. We really need to get away from configuring magic addresses via Kconfig= .=20