From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7195C43603 for ; Sat, 14 Dec 2019 15:46:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8271E20706 for ; Sat, 14 Dec 2019 15:46:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c+R88c7R" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725975AbfLNPqk (ORCPT ); Sat, 14 Dec 2019 10:46:40 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:40277 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725943AbfLNPqk (ORCPT ); Sat, 14 Dec 2019 10:46:40 -0500 Received: by mail-wr1-f67.google.com with SMTP id c14so2002319wrn.7; Sat, 14 Dec 2019 07:46:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=4ZheM6H1IJf91c1ZceviNMo0bD3V67BjHbfGbfFZiDQ=; b=c+R88c7R0IFMXSgL7bFY3SG0xEGz8jTGqMRLXSXdSgjMZ8NzhFr4pyDNFM52Qlx3aC gVryr6ldpTFFY+5iU+28QaPoRQdhYp8sHsQpLHI4VnnmlK6u4OgEUR3ryfQR48fMi8Kf PRnDK8ddLTvbgvD4gxLJM5yJw44sNPM3b3dF9wZshjKCZ35oqSt3k8aVT01azxClcdSr JXv52XWrTwgiJUpVd/1hlwVHM7vm/vO8+f+n8aR954H8PAFCEKa47zgKNdF71jaCuD3a J3K5/9p4qwEpShcI7qCNAWJ+d5NBmc44qKSBJx05XhcDKSfRdPPl4bSuQ4wSUMuts9WI /pDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=4ZheM6H1IJf91c1ZceviNMo0bD3V67BjHbfGbfFZiDQ=; b=Q3D/ZtscAGMeMlHpCkL0HvfirN5TVyGaf2oFWjGSdLX+eZYpW5f3z3kHRLxRHAws97 V4thB+lPw1hTZ6zw0lT1dtJ77+DjIllWl8I2FWSUpSeO0gAhC6wdkXpmM0yjEiU2JoQn Cw8aiOwXJwn1ExdSfd251T4HVoaMg+aqfCpTHermAGN/dGxzJPVyVoeLqB45KOnM5n9F kLg50cZh9Ad3VQ5AGVw2tHxsBEaptqYHdiDiW2LRJS1CCrLcqaH0c+qXz07bg2wBkx7e AQCCGx3kQzEmn8eaoRPJM8ESygaOhJRKzl7znFbdDOHB6XKHLrMf7wKuyyN63mhSbatK 6LGA== X-Gm-Message-State: APjAAAVt+tIIniosOQiuhJeUd3QtUHusKemmwbq41YGRU9iMpWz83yEx dnYiMmKnct9ljThviMwRRlMl8Yr32z1lyg== X-Google-Smtp-Source: APXvYqxUWjq2pg/m7vAarnMa01TbxmF7dhf3iGJcVpBhIKgU/YHr0zB5TJ8QARwhlC7PuseFZK7R2Q== X-Received: by 2002:adf:df0e:: with SMTP id y14mr18158363wrl.377.1576338398416; Sat, 14 Dec 2019 07:46:38 -0800 (PST) Received: from apple.sigmaris.info (apple.sigmaris.info. [2a02:8010:6606:0:feaa:14ff:fe20:9878]) by smtp.gmail.com with ESMTPSA id s65sm14819596wmf.48.2019.12.14.07.46.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Dec 2019 07:46:37 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: [PATCH v3 4/7] media: hantro: h264: Use the generic H264 reflist builder From: Hugh Cole-Baker In-Reply-To: <20191213125414.90725-5-boris.brezillon@collabora.com> Date: Sat, 14 Dec 2019 15:46:35 +0000 Cc: Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Sakari Ailus , linux-media@vger.kernel.org, Mark Rutland , devicetree@vger.kernel.org, Tomasz Figa , Heiko Stuebner , Jonas Karlman , Nicolas Dufresne , Paul Kocialkowski , linux-rockchip@lists.infradead.org, Rob Herring , kernel@collabora.com, Ezequiel Garcia Content-Transfer-Encoding: quoted-printable Message-Id: <24EFC68C-CF34-4D6E-8927-1CFA0CE81F45@gmail.com> References: <20191213125414.90725-1-boris.brezillon@collabora.com> <20191213125414.90725-5-boris.brezillon@collabora.com> To: Boris Brezillon X-Mailer: Apple Mail (2.3445.9.1) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Boris, > On 13 Dec 2019, at 12:54, Boris Brezillon = wrote: >=20 > Now that the core provides generic reflist builders, we can use them > instead of implementing our own. >=20 > Signed-off-by: Boris Brezillon > --- > Changes in v3: > * New patch > --- > drivers/staging/media/hantro/hantro_h264.c | 237 +-------------------- > 1 file changed, 8 insertions(+), 229 deletions(-) >=20 > diff --git a/drivers/staging/media/hantro/hantro_h264.c = b/drivers/staging/media/hantro/hantro_h264.c > index 568640eab3a6..d998272d20e6 100644 > --- a/drivers/staging/media/hantro/hantro_h264.c > +++ b/drivers/staging/media/hantro/hantro_h264.c > @@ -11,7 +11,7 @@ > */ >=20 > #include > -#include > +#include With this patch, CONFIG_VIDEO_HANTRO needs to depend on = CONFIG_V4L2_H264, without that it can encounter linking errors due to missing symbols for v4l2_h264_init_reflist_builder, etc. > #include > #include "hantro.h" > @@ -240,229 +240,6 @@ static void prepare_table(struct hantro_ctx = *ctx) > reorder_scaling_list(ctx); > } > ..snip.. -- Regards, Hugh Cole-Baker= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hugh Cole-Baker Subject: Re: [PATCH v3 4/7] media: hantro: h264: Use the generic H264 reflist builder Date: Sat, 14 Dec 2019 15:46:35 +0000 Message-ID: <24EFC68C-CF34-4D6E-8927-1CFA0CE81F45@gmail.com> References: <20191213125414.90725-1-boris.brezillon@collabora.com> <20191213125414.90725-5-boris.brezillon@collabora.com> Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20191213125414.90725-5-boris.brezillon-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Boris Brezillon Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, Heiko Stuebner , Jonas Karlman , Tomasz Figa , Paul Kocialkowski , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Sakari Ailus , Laurent Pinchart , Nicolas Dufresne , Hans Verkuil , Mauro Carvalho Chehab , Ezequiel Garcia , linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rockchip.vger.kernel.org Hi Boris, > On 13 Dec 2019, at 12:54, Boris Brezillon wrote: > > Now that the core provides generic reflist builders, we can use them > instead of implementing our own. > > Signed-off-by: Boris Brezillon > --- > Changes in v3: > * New patch > --- > drivers/staging/media/hantro/hantro_h264.c | 237 +-------------------- > 1 file changed, 8 insertions(+), 229 deletions(-) > > diff --git a/drivers/staging/media/hantro/hantro_h264.c b/drivers/staging/media/hantro/hantro_h264.c > index 568640eab3a6..d998272d20e6 100644 > --- a/drivers/staging/media/hantro/hantro_h264.c > +++ b/drivers/staging/media/hantro/hantro_h264.c > @@ -11,7 +11,7 @@ > */ > > #include > -#include > +#include With this patch, CONFIG_VIDEO_HANTRO needs to depend on CONFIG_V4L2_H264, without that it can encounter linking errors due to missing symbols for v4l2_h264_init_reflist_builder, etc. > #include > #include "hantro.h" > @@ -240,229 +240,6 @@ static void prepare_table(struct hantro_ctx *ctx) > reorder_scaling_list(ctx); > } > ..snip.. -- Regards, Hugh Cole-Baker