From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Joakim Zhang <qiangqing.zhang@nxp.com>,
"wg@grandegger.com" <wg@grandegger.com>,
"davem@davemloft.net" <davem@davemloft.net>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"A.s. Dong" <aisheng.dong@nxp.com>
Subject: Re: [PATCH] can: flexcan: Implement CAN Runtime PM
Date: Wed, 21 Nov 2018 15:36:19 +0100 [thread overview]
Message-ID: <24a43a20-7302-c449-06b3-5ee8f6c051a0@pengutronix.de> (raw)
In-Reply-To: <20181019094326.28185-1-qiangqing.zhang@nxp.com>
[-- Attachment #1.1: Type: text/plain, Size: 1224 bytes --]
On 10/19/18 11:45 AM, Joakim Zhang wrote:
> From: Dong Aisheng <aisheng.dong@nxp.com>
>
> Flexcan will be disabled during suspend if no wakeup function required
> and enabled after resume accordingly. During this period, we could
> explicitly disable clocks.
>
> Implement Runtime PM which will:
> 1) Keep device in suspend state (clocks disabled) if it's not openned
> 2) Make Power Domain framework be able to shutdown the corresponding power
> domain of this device.
Without CONFIG_PM the device fails to probe:
> [ 214.420606] flexcan 2090000.flexcan: 2090000.flexcan supply xceiver not found, using dummy regulator
> [ 214.445952] flexcan 2090000.flexcan: Linked as a consumer to regulator.0
> [ 214.453448] flexcan 2090000.flexcan: registering netdev failed
> [ 214.459666] flexcan 2090000.flexcan: Dropping the link to regulator.0
> [ 214.472066] flexcan: probe of 2090000.flexcan failed with error -110
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-11-21 14:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 9:45 [PATCH] can: flexcan: Implement CAN Runtime PM Joakim Zhang
2018-11-21 14:36 ` Marc Kleine-Budde [this message]
2018-11-22 1:39 ` Joakim Zhang
2018-11-27 7:44 ` Joakim Zhang
2018-11-27 7:52 ` Marc Kleine-Budde
2018-11-27 8:07 ` Aisheng DONG
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24a43a20-7302-c449-06b3-5ee8f6c051a0@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=aisheng.dong@nxp.com \
--cc=davem@davemloft.net \
--cc=linux-can@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.