From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E648C433EF for ; Mon, 13 Sep 2021 10:58:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A2F260EE5 for ; Mon, 13 Sep 2021 10:58:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3A2F260EE5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B9A106E15F; Mon, 13 Sep 2021 10:58:13 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0EB176E0A6 for ; Mon, 13 Sep 2021 10:58:13 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10105"; a="201147222" X-IronPort-AV: E=Sophos;i="5.85,288,1624345200"; d="scan'208";a="201147222" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2021 03:58:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,288,1624345200"; d="scan'208";a="451529421" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP; 13 Sep 2021 03:58:00 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 13 Sep 2021 03:58:00 -0700 Received: from bgsmsx604.gar.corp.intel.com (10.67.234.6) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 13 Sep 2021 03:57:58 -0700 Received: from bgsmsx604.gar.corp.intel.com ([10.67.234.6]) by BGSMSX604.gar.corp.intel.com ([10.67.234.6]) with mapi id 15.01.2242.012; Mon, 13 Sep 2021 16:27:56 +0530 From: "Gupta, Anshuman" To: "Vivi, Rodrigo" , "intel-gfx@lists.freedesktop.org" CC: Daniel Vetter , David Weinehall , "Tangudu, Tilak" , "Deak, Imre" Thread-Topic: [PATCH 3/3] drm/i915: Enable runtime pm autosuspend by default Thread-Index: AQHXpmuSG8o9SgdSHkyWa50bn75Zwquhztxw Date: Mon, 13 Sep 2021 10:57:56 +0000 Message-ID: <24b529f8a179488cbc62bb89306b1abd@intel.com> References: <20210910174447.289750-1-rodrigo.vivi@intel.com> <20210910174447.289750-3-rodrigo.vivi@intel.com> In-Reply-To: <20210910174447.289750-3-rodrigo.vivi@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action x-originating-ip: [10.223.10.1] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915: Enable runtime pm autosuspend by default X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" > -----Original Message----- > From: Vivi, Rodrigo > Sent: Friday, September 10, 2021 11:15 PM > To: intel-gfx@lists.freedesktop.org > Cc: Vivi, Rodrigo ; Daniel Vetter > ; David Weinehall ; > Tangudu, Tilak ; Deak, Imre ; > Gupta, Anshuman > Subject: [PATCH 3/3] drm/i915: Enable runtime pm autosuspend by default >=20 > Let's enable runtime pm autosuspend by default everywhere. >=20 > But at this time let's not touch the autosuspend_delay time, what caused = some > regression on our previous attempt. >=20 > v2: CI on some gen9 platforms was not clean. But it came > pretty clean on newer generations. For now, let's > pick gen12 and newer. We will return later to extend > that to older platforms. >=20 > Cc: Daniel Vetter > Cc: David Weinehall > Cc: Tilak Tangudu > Cc: Imre Deak > Signed-off-by: Rodrigo Vivi > Reviewed-by: Anshuman Gupta #v1 > --- > drivers/gpu/drm/i915/intel_runtime_pm.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c > b/drivers/gpu/drm/i915/intel_runtime_pm.c > index f28b5bab61b4..f91a04c3ef14 100644 > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c > @@ -605,6 +605,10 @@ void intel_runtime_pm_enable(struct > intel_runtime_pm *rpm) > pm_runtime_use_autosuspend(kdev); > } >=20 > + /* XXX: Enable by default only for newer platforms for now */ > + if (GRAPHICS_VER(i915) >=3D 12) > + pm_runtime_allow(kdev); Reviewed-by: Anshuman Gupta Looks good to me. Br, Anshuman Gupta. > + > /* > * The core calls the driver load handler with an RPM reference held. > * We drop that here and will reacquire it during unloading in > -- > 2.31.1