From: David Hildenbrand <david@redhat.com>
To: Yafang Shao <laoar.shao@gmail.com>, akpm@linux-foundation.org
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
oliver.sang@intel.com, lkp@intel.com,
Andrii Nakryiko <andrii@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Michal Miroslaw <mirq-linux@rere.qmqm.pl>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Matthew Wilcox <willy@infradead.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Kees Cook <keescook@chromium.org>, Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH 7/7] tools/testing/selftests/bpf: make it adopt to task comm size change
Date: Thu, 11 Nov 2021 11:11:04 +0100 [thread overview]
Message-ID: <24b685c3-f16a-9ced-fb39-bf6a0b9f994e@redhat.com> (raw)
In-Reply-To: <20211108083840.4627-8-laoar.shao@gmail.com>
On 08.11.21 09:38, Yafang Shao wrote:
> The hard-coded 16 is used in various bpf progs. These progs get task
> comm either via bpf_get_current_comm() or prctl() or
> bpf_core_read_str(), all of which can work well even if the task comm size
> is changed.
>
> In these BPF programs, one thing to be improved is the
> sched:sched_switch tracepoint args. As the tracepoint args are derived
> from the kernel, we'd better make it same with the kernel. So the macro
> TASK_COMM_LEN is converted to type enum, then all the BPF programs can
> get it through BTF.
>
> The BPF program which wants to use TASK_COMM_LEN should include the header
> vmlinux.h. Regarding the test_stacktrace_map and test_tracepoint, as the
> type defined in linux/bpf.h are also defined in vmlinux.h, so we don't
> need to include linux/bpf.h again.
>
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
> Acked-by: Andrii Nakryiko <andrii@kernel.org>
> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
> Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>
> Cc: Michal Miroslaw <mirq-linux@rere.qmqm.pl>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Petr Mladek <pmladek@suse.com>
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-11-11 10:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 8:38 [PATCH 0/7] task comm cleanups Yafang Shao
2021-11-08 8:38 ` [PATCH 1/7] fs/exec: make __set_task_comm always set a nul terminated string Yafang Shao
2021-11-10 8:28 ` David Hildenbrand
2021-11-10 9:05 ` Yafang Shao
2021-11-11 9:58 ` David Hildenbrand
2021-11-10 20:17 ` Kees Cook
2021-11-08 8:38 ` [PATCH 2/7] fs/exec: make __get_task_comm always get " Yafang Shao
2021-11-11 9:59 ` David Hildenbrand
2021-11-08 8:38 ` [PATCH 3/7] drivers/infiniband: use get_task_comm instead of open-coded string copy Yafang Shao
2021-11-11 10:01 ` David Hildenbrand
2021-11-08 8:38 ` [PATCH 4/7] fs/binfmt_elf: " Yafang Shao
2021-11-11 10:03 ` David Hildenbrand
2021-11-11 10:06 ` David Hildenbrand
2021-11-11 11:34 ` Petr Mladek
2021-11-11 11:47 ` David Hildenbrand
2021-11-12 1:08 ` Yafang Shao
2021-11-12 1:03 ` Yafang Shao
2021-11-08 8:38 ` [PATCH 5/7] samples/bpf/test_overhead_kprobe_kern: make it adopt to task comm size change Yafang Shao
2021-11-08 18:20 ` Andrii Nakryiko
2021-11-11 10:07 ` David Hildenbrand
2021-11-08 8:38 ` [PATCH 6/7] tools/bpf/bpftool/skeleton: use bpf_probe_read_kernel_str to get task comm Yafang Shao
2021-11-11 10:08 ` David Hildenbrand
2021-11-08 8:38 ` [PATCH 7/7] tools/testing/selftests/bpf: make it adopt to task comm size change Yafang Shao
2021-11-11 10:11 ` David Hildenbrand [this message]
2021-11-09 18:28 ` [PATCH 0/7] task comm cleanups Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24b685c3-f16a-9ced-fb39-bf6a0b9f994e@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=arnaldo.melo@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=keescook@chromium.org \
--cc=laoar.shao@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=oliver.sang@intel.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.