From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751524AbdG0Moy (ORCPT ); Thu, 27 Jul 2017 08:44:54 -0400 Received: from lucky1.263xmail.com ([211.157.147.135]:40308 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750836AbdG0Mow (ORCPT ); Thu, 27 Jul 2017 08:44:52 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: david.wu@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: david.wu@rock-chips.com X-UNIQUE-TAG: <60b0d62c994bd2aa03ce90c452fa762b> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 05/11] net: stmmac: dwmac-rk: Add internal phy support To: Andrew Lunn Cc: davem@davemloft.net, heiko@sntech.de, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, olof@lixom.net, linux@armlinux.org.uk, arnd@arndb.de, f.fainelli@gmail.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, huangtao@rock-chips.com, hwg@rock-chips.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1498192929-7519-1-git-send-email-david.wu@rock-chips.com> <1498193947-8011-1-git-send-email-david.wu@rock-chips.com> <20170624022954.GD4875@lunn.ch> From: "David.Wu" Message-ID: <24bc9102-d37f-1a63-ad7b-f69e8e38d848@rock-chips.com> Date: Thu, 27 Jul 2017 20:44:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170624022954.GD4875@lunn.ch> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, ÔÚ 2017/6/24 10:29, Andrew Lunn дµÀ: > If this is the PHY clock, should it actually be specified in the PHY > binding? Can you read the PHY ID registers with this clock off? If the phy clock is closed, we can not read the PHYID. From mboxrd@z Thu Jan 1 00:00:00 1970 From: david.wu@rock-chips.com (David.Wu) Date: Thu, 27 Jul 2017 20:44:42 +0800 Subject: [PATCH 05/11] net: stmmac: dwmac-rk: Add internal phy support In-Reply-To: <20170624022954.GD4875@lunn.ch> References: <1498192929-7519-1-git-send-email-david.wu@rock-chips.com> <1498193947-8011-1-git-send-email-david.wu@rock-chips.com> <20170624022954.GD4875@lunn.ch> Message-ID: <24bc9102-d37f-1a63-ad7b-f69e8e38d848@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Andrew, ? 2017/6/24 10:29, Andrew Lunn ??: > If this is the PHY clock, should it actually be specified in the PHY > binding? Can you read the PHY ID registers with this clock off? If the phy clock is closed, we can not read the PHYID.