From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29F9BC433B4 for ; Tue, 6 Apr 2021 12:25:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A69396121E for ; Tue, 6 Apr 2021 12:25:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A69396121E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTklh-0002ti-Jo for qemu-devel@archiver.kernel.org; Tue, 06 Apr 2021 08:25:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTkjm-0001Tl-95 for qemu-devel@nongnu.org; Tue, 06 Apr 2021 08:23:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:26967) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTkjh-0003jQ-Pq for qemu-devel@nongnu.org; Tue, 06 Apr 2021 08:23:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617711791; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+UBKrxXh0Nojghvd8aiZzxVJTbhnNDkgbxPPyzy+/bk=; b=M+V2A8s2ox/afozJbqdzUM/0LA61S4Mrv55FMgDtm5MjGSx0Kr2/B/B399XI/doUhYPEWG JtBG0wOU/IQ/04DaXZS6tWwmyRI31YjaF77d0vYfHenKQx9Ri7s9lKvnokUXHnv4J6hp1M aXLYMfhYg3Dcwzbmf9rAjf0mBm8tmGI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-v2lkSJZ-NHacShHfqIgLIw-1; Tue, 06 Apr 2021 08:23:08 -0400 X-MC-Unique: v2lkSJZ-NHacShHfqIgLIw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 58FE48B5DFD; Tue, 6 Apr 2021 12:22:52 +0000 (UTC) Received: from [10.36.112.13] (ovpn-112-13.ams2.redhat.com [10.36.112.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A7EC25C890; Tue, 6 Apr 2021 12:22:50 +0000 (UTC) Subject: Re: [PATCH] hw/arm/virt-acpi-build: Fix GSIV values of the {GERR, Sync} interrupts To: Peter Maydell References: <20210402084731.93-1-yuzenghui@huawei.com> <7f42bc9f-3fb8-d24d-d9e4-9b93784504a6@redhat.com> From: Auger Eric Message-ID: <24c077d2-0e0e-02bc-0f92-4086be7e8982@redhat.com> Date: Tue, 6 Apr 2021 14:22:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eric.auger@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=eric.auger@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers , Shannon Zhao , qemu-arm , Zenghui Yu , wanghaibin.wang@huawei.com, Prem Mallappa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Peter, On 4/6/21 12:44 PM, Peter Maydell wrote: > On Tue, 6 Apr 2021 at 11:10, Auger Eric wrote: >> >> Hi Zenghui, >> >> On 4/2/21 10:47 AM, Zenghui Yu wrote: >>> The GSIV values in SMMUv3 IORT node are not correct as they don't match >>> the SMMUIrq enumeration, which describes the IRQ<->PIN mapping used by >>> our emulated vSMMU. >>> >>> Fixes: a703b4f6c1ee ("hw/arm/virt-acpi-build: Add smmuv3 node in IORT table") >>> Signed-off-by: Zenghui Yu >> Acked-by: Eric Auger > > Eric, when you send an acked-by tag do you mean to say that you've > reviewed the patch, or merely that you think it's basically the > right thing but you haven't actually looked at the details? I mean I have reviewed the patch carefully and I think it is good to go. I thought that as a maintainer for the arm smmu component I was supposed to send an A-b instead of an R-b. > > (I ask because if the former I can just put this in target-arm.next, > but if the latter then I need to dig out the SMMU spec and review > the patch myself :-)) Yes that's rather the former but obviously if you have some cycles / interest in the topic I am more than happy to get your opinion too! Thanks Eric > > thanks > -- PMM >