From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 5/7] x86/traps: Lift all non-entrypoint logic in entry_int82() up into C Date: Wed, 3 May 2017 19:29:12 +0100 Message-ID: <24cbb437-39ab-5838-d989-9e7c1be0f696@citrix.com> References: <1493748326-9582-1-git-send-email-andrew.cooper3@citrix.com> <1493748326-9582-6-git-send-email-andrew.cooper3@citrix.com> <5909B8C1020000780015637E@prv-mh.provo.novell.com> <20170503112634.zaojs4gvabxkb4my@citrix.com> <5909E2EC020000780015655B@prv-mh.provo.novell.com> <6c9ffeb0-1b77-b4c7-603b-b83bd66a9e09@citrix.com> <5909EB2302000078001565B9@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5909EB2302000078001565B9@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: Wei Liu , Xen-devel List-Id: xen-devel@lists.xenproject.org T24gMDMvMDUvMTcgMTM6MzcsIEphbiBCZXVsaWNoIHdyb3RlOgo+Pj4+IE9uIDAzLjA1LjE3IGF0 IDE0OjE4LCA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3JvdGU6Cj4+IE9uIDAzLzA1LzE3 IDEzOjAyLCBKYW4gQmV1bGljaCB3cm90ZToKPj4+Pj4+IE9uIDAzLjA1LjE3IGF0IDEzOjM4LCA8 YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4gd3JvdGU6Cj4+Pj4gT24gMDMvMDUvMTcgMTI6MjYs IFdlaSBMaXUgd3JvdGU6Cj4+Pj4+IE9uIFdlZCwgTWF5IDAzLCAyMDE3IGF0IDAzOjAyOjI1QU0g LTA2MDAsIEphbiBCZXVsaWNoIHdyb3RlOgo+Pj4+Pj4+Pj4gT24gMDIuMDUuMTcgYXQgMjA6MDUs IDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPiB3cm90ZToKPj4+Pj4+PiAtLS0gL2Rldi9udWxs Cj4+Pj4+Pj4gKysrIGIveGVuL2FyY2gveDg2L3B2L3RyYXBzLmMKPj4+Pj4+PiBAQCAtMCwwICsx LDQ0IEBACj4+Pj4+Pj4KPj4gKy8qKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioKPj4+PiAqKioKPj4+Pj4+PiAr ICogYXJjaC94ODYvcHYvdHJhcHMuYwo+Pj4+Pj4+ICsgKgo+Pj4+Pj4+ICsgKiBQViBsb3cgbGV2 ZWwgZW50cnkgcG9pbnRzLgo+Pj4+Pj4+ICsgKgo+Pj4+Pj4+ICsgKiBUaGlzIHByb2dyYW0gaXMg ZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlmeQo+Pj4+ Pj4+ICsgKiBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNl bnNlIGFzIHB1Ymxpc2hlZCBieQo+Pj4+Pj4+ICsgKiB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0 aW9uOyBlaXRoZXIgdmVyc2lvbiAyIG9mIHRoZSBMaWNlbnNlLCBvcgo+Pj4+Pj4+ICsgKiAoYXQg eW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgo+Pj4+Pj4+ICsgKgo+Pj4+Pj4+ICsgKiBU aGlzIHByb2dyYW0gaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVz ZWZ1bCwKPj4+Pj4+PiArICogYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4g dGhlIGltcGxpZWQgd2FycmFudHkgb2YKPj4+Pj4+PiArICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJ VE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQo+Pj4+Pj4+ICsgKiBHTlUg R2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgo+Pj4+Pj4+ICsgKgo+Pj4+ Pj4+ICsgKiBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJh bCBQdWJsaWMgTGljZW5zZQo+Pj4+Pj4+ICsgKiBhbG9uZyB3aXRoIHRoaXMgcHJvZ3JhbTsgSWYg bm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNlbnNlcy8+Lgo+Pj4+Pj4+ICsgKgo+Pj4+ Pj4+ICsgKiBDb3B5cmlnaHQgKGMpIDIwMTcgQ2l0cml4IFN5c3RlbXMgTHRkLgo+Pj4+Pj4+ICsg Ki8KPj4+Pj4+PiArCj4+Pj4+Pj4gKyNpbmNsdWRlIDx4ZW4vaHlwZXJjYWxsLmg+Cj4+Pj4+Pj4g Kwo+Pj4+Pj4+ICsjaW5jbHVkZSA8YXNtL2FwaWMuaD4KPj4+Pj4+PiArCj4+Pj4+Pj4gKyNpZmRl ZiBDT05GSUdfQ09NUEFUCj4+Pj4+PiBBcyBleHByZXNzZWQgYmVmb3JlLCBJIGRpc2FncmVlIHRv IHRoZSByZS1pbnRyb2R1Y3Rpb24gb2Ygc3VjaAo+Pj4+Pj4gY29uZGl0aW9uYWxzIGluIHg4NiBj b2RlLgo+Pj4+Pj4KPj4+Pj4gSSdtIGN1cmlvdXMgdG8ga25vdyBob3cgdGhlIENPTVBBVCBpbnRl cmZhY2UgaXMgdHJlYXRlZCBsb25nIHRlcm0uCj4+Pj4+Cj4+Pj4+IEkgZ3Vlc3MgeW91J3JlIG9m IHRoZSBvcGluaW9uIHRoYXQgd2Ugc2hvdWxkIGFsd2F5cyBoYXZlIHRoZW0gZW5hYmxlZD8KPj4+ PiBUaGVyZSBpcyBhIHZhbGlkIHVzZWNhc2UgdG8gZGlzYWJsZSBDT05GSUdfQ09NUEFULCBzZWVp bmcgYXMgc3VmZmljaWVudAo+Pj4+IFBWSCBpbnRlcmZhY2VzIGV4aXN0IHRvIHN0YXJ0IEFQcyBz dHJhaWdodCBpbiA2NGJpdCBtb2RlLCBhcyBpdCBwcm92aWRlcwo+Pj4+IGEgbWVhbmluZ2Z1bCBy ZWR1Y3Rpb24gaW4gaHlwZXJ2aXNvciBhdHRhY2sgc3VyZmFjZS4KPj4+IFdoYXQgZG9lcyBQVkgg aGF2ZSB0byBkbyB3aXRoIDMyLWJpdCBQViBjb21wYXQgZ3Vlc3Qgc3VwcG9ydD8KPj4gTm90aGlu Zy4gIEkgYW0gdW5zdXJlIGFzIHRvIHdoeSBkbyB5b3UgdGhpbmsgaXQgZG9lcz8KPj4KPj4gVGhl IENPTkZJR19DT01QQVQgaW5mcmFzdHJ1Y3R1cmUgYnkgSFZNIGd1ZXN0cyBhcyB3ZWxsLiAKPiBB IHJhdGhlciBzbWFsbCBwYXJ0IG9mIGl0LCBpZiBhdCBhbGwuIEFuZCBpZiBIVk0gZ3Vlc3RzIHJl YWxseSB1c2UgcGFydHMKPiBvZiBpdCwgd2UgY2FuJ3QgZGlzYWJsZSBpdCB3aXRob3V0IGJyZWFr aW5nIHN1Y2ggZ3Vlc3RzIHJ1bm5pbmcKPiAocGVyaGFwcyBqdXN0IHRlbXBvcmFyaWx5KSBpbiAz Mi1iaXQgbW9kZS4KPgo+Pj4+IEFzIGl0IGlzIGEgY29uZmlndXJhYmxlIG9wdGlvbiwgSSBpbnRl bmQgdG8gd29yayBpbiBhIGRpcmVjdGlvbiB3aGljaAo+Pj4+IGV2ZW50dWFsbHkgbWFrZXMgaXQg dXNhYmxlIHVuZGVyIHg4Ni4KPj4+Pgo+Pj4+IElmIHRoZXJlIGlzIGEgd2lzaCB0byBtb3ZlIGlu IGFuIG9wcG9zaXRlIGRpcmVjdGlvbiwgdGhhdCBzaG91bGQgYmUgYQo+Pj4+IHNlcGFyYXRlIGRp c2N1c3Npb24gbWFkZSBvdmVyIGEgcGF0Y2ggcmVtb3ZpbmcgaXRzIGVudHJ5IGZyb20KPj4+PiBj b21tb24vS2NvbmZpZy4KPj4+IE9uY2UgYWdhaW4gLSBmcm9tIGNvbW1vbiBjb2RlIHBlcnNwZWN0 aXZlIHRoaXMgaXMgYSB2YWxpZCBjb25maWcKPj4+IG9wdGlvbiB0byBoYXZlLiBYODYsIGhvd2V2 ZXIsIHVuY29uZGl0aW9uYWxseSBzZWxlY3RzIGl0LCBzbyB0aGVyZSdzCj4+PiBubyBwb2ludCBo YXZpbmcgc3VjaCBjb25kaXRpb25hbHMgaW4geDg2IGNvZGUuCj4+IEkgZG9uJ3QgYWdyZWUgd2l0 aCB0aGlzIHJlYXNvbmluZy4gIElmIGl0IGlzIGEgcmVhc29uYWJsZSBjb25maWd1cmF0aW9uCj4+ IGZvciBjb21tb24gY29kZSB0byB1c2UsIGl0IGlzIGEgcmVhc29uYWJsZSBjb25maWd1cmF0aW9u IGZvciB4ODYgY29kZSB0bwo+PiB1c2UuCj4gRGVwZW5kczogSXQncyB0aGVyZSBpbiBjb21tb24g Y29kZSB0byBza2lwIHRoZSByZXNwZWN0aXZlIHBpZWNlcyBvZgo+IGNvZGUgZm9yIGFyY2hpdGVj dHVyZXMgbm90IG5lZWRpbmcgaXQuIEl0IHVzZWQgdG8gYmUgYSBtZWFuaW5nZnVsCj4gb3B0aW9u IGluIHg4NiBhcyBsb25nIGFzIHRoZXJlIHdhcyBhIDMyLWJpdCBoeXBlcnZpc29yLgo+Cj4+IE9y IGRvIHlvdSBkaXNhZ3JlZSB3aXRoIG15IGFyZ3VtZW50IGZvciB3aHkgaXQgc2hvdWxkIGJlIGEg Y29uZmlndXJhYmxlCj4+IG9wdGlvbiB3aGljaCBjYW4gYmUgdHVybmVkIG9mZiBpbiBhbiB4ODYg YnVpbGQ/Cj4gV2VsbCwgSSdkIGZpcnN0IG9mIGFsbCBoYXZlIHRvIGNoZWNrIGFnYWluIGhvdyBt dWNoIG9mIHRoaXMgcmVhbGx5IGlzCj4gYmVpbmcgdXNlZCBieSBIVk0gY29kZS4gSG1tLCBsb29r cyBsaWtlIGl0J3MgbW9yZSB0aGFuIEkgZGlkCj4gcmVtZW1iZXIuIEJ1dCB3aXRoIGFsbCBDT05G SUdfQ09NUEFUIHVzZXMgZ29uZSBmcm9tIHg4Ngo+IGNvZGUgKG1pbnVzIHRoZSBvbmVzIHlvdSBp bnRyb2R1Y2VkIG5vdCB2ZXJ5IGxvbmcgYWdvKSwgSSBkb24ndAo+IHNlZSB3aHkgeW91IHdhbnQg dG8gcmUtaW50cm9kdWNlIGEgZmV3IG1vcmUgbm93LiBJZiB3ZSByZWFsbHkKPiB3YW50IHRoZSBv cHRpb24gb2YgZGlzYWJsaW5nIHRoYXQgY29kZSwgYSBjb25jZXJ0ZWQgZWZmb3J0IHNob3VsZAo+ IGJlIG1hZGUgdG8gcmUtYWRkIHRoZSBjb25kaXRpb25hbHMgd2hlcmV2ZXIgbmVlZGVkLiBPdGhl cndpc2UKPiB3ZSdsbCBlbmQgdXAgd2l0aCBjb2RlIHdoZXJlIHJlYWRlcnMgd291bGQgbGVnaXRp bWF0ZWx5IGFzayB3aHkKPiB0aGUgY29uZGl0aW9uYWxzIGFyZSB0aGVyZSBpbiBzb21lIHBsYWNl cywgYnV0IG1pc3NpbmcgaW4gbWFueQo+IG90aGVycy4gQW5kIG5vLCBJIHdvdWxkbid0IHZpZXcg YSBwYXRjaCBsaWtlIHRoZSBvbmUgaGVyZSBhcyB0aGUKPiBiZWdpbm5pbmcgb2YgYSB0cmFuc2l0 aW9uYWwgcGVyaW9kIChhcyBleHByZXNzZWQgYmVmb3JlLCBJIHNob3VsZAo+IGhhdmUgbm90aWNl ZCBhbmQgb2JqZWN0ZWQgdG8gdGhlIHJlLWludHJvZHVjdGlvbiBvZiBzdWNoICNpZmRlZi1zCj4g aW4geW91ciBQViBoeXBlcmNhbGwgY2hhbmdlcykuCgpUaGUgcmVhc29uIGMvcyBkZTgyZmVlYmYy YyB1c2VzIENPTkZJR19DT01QQVQgaXMgYmVjYXVzZSBvZgoKc3RydWN0IG1jX3N0YXRlIHsKICAg IHVuc2lnbmVkIGxvbmcgZmxhZ3M7CiAgICB1bmlvbiB7CiAgICAgICAgc3RydWN0IG11bHRpY2Fs bF9lbnRyeSBjYWxsOwojaWZkZWYgQ09ORklHX0NPTVBBVAogICAgICAgIHN0cnVjdCBjb21wYXRf bXVsdGljYWxsX2VudHJ5IGNvbXBhdF9jYWxsOwojZW5kaWYKICAgIH07Cn07CgpiZWluZyBkZWZp bmVkIHVzaW5nIENPTkZJR19DT01QQVQuICBJdCBkaWRuJ3QgZXZlbiBjcm9zcyBteSBtaW5kIHRo YXQgaXQKbWlnaHQgaGF2ZSBiZWVuIG9rIHRvIGFsbG93IHRoZSBjb2RlIHRvIGZhaWwgdG8gY29t cGlsZSBpZiBDT05GSUdfQ09NUEFUCndhcyBub3Qgc2VsZWN0ZWQuICBJIHRoZXJlZm9yZSB3cm90 ZSBjb2RlIHdoaWNoIG1hdGNoZWQgdGhlIHN0cnVjdHVyZQpkZWZpbml0aW9uIGl0IHdhcyB1c2lu Zy4KCgpJcnJlc3BlY3RpdmUgb2YgdGhlIGhpc3Rvcnkgd2hpY2ggbGVhZCB0byB0aGlzIHBvaW50 LCB0aGUgaW1wb3J0YW50CnF1ZXN0aW9uIGlzIHdoZXRoZXIgd2Ugd2FudCB0byBhbGxvdyBjb21w aWxpbmcgeDg2IHdpdGhvdXQgQ09ORklHX0NPTVBBVC4KCklmIHRoZSBldmVudHVhbCBkZWNpc2lv biBpcyB5ZXMsIHRoZW4gbmV3IGNvZGUgc2hvdWxkIHNwZWNpZmljYWxseSBiZQppbnRyb2R1Y2Vk IGFzIGJlaW5nIENPTkZJR19DT01QQVQtY2xlYW4sIGJlY2F1c2UgZGVjaXNpb25zIGxpa2UgdGhh dAphZmZlY3QgaG93IHRvIHN0cnVjdHVyZSB0aGUgY29kZSBpbiB0aGUgZmlyc3QgcGxhY2UsIGFu ZCB0aGVyZWZvcmUgYmUKZmFyIGNsZWFuZXIgY2hhbmdlcyB0aGFuIHRyeWluZyB0byByZXRyb2Zp dCBDT05GSUdfQ09NUEFUIGluIHRoZSBmdXR1cmUuCgp+QW5kcmV3CgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhl bi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK