From: Gal Pressman <galpress@amazon.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Doug Ledford <dledford@redhat.com>, <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH for-rc] RDMA/restrack: Track driver QP types in resource tracker
Date: Tue, 30 Jul 2019 16:49:52 +0300 [thread overview]
Message-ID: <24f4f7e3-dada-5185-3988-2e821b321bc1@amazon.com> (raw)
In-Reply-To: <20190730133817.GC4878@mtr-leonro.mtl.com>
On 30/07/2019 16:38, Leon Romanovsky wrote:
> On Tue, Jul 30, 2019 at 02:01:37PM +0300, Gal Pressman wrote:
>> The check for QP type different than XRC has wrongly excluded driver QP
>> types from the resource tracker.
>>
>> Fixes: 78a0cd648a80 ("RDMA/core: Add resource tracking for create and destroy QPs")
>
> It is a little bit over to say "wrongly". At that time, we did it on purpose
> because it was unclear how to represent such QP types to users and we didn't
> have vendor specific hooks introduced by Steve later on.
It's very confusing to see a test running and zero QPs in "rdma res".
I'm fine with removing the "wrongly" :), but I still think this should be
targeted to for-rc as a bug fix.
>
> I would like to see the output or "rdma res" and "rdma res show qp" with
> running driver QP after your change.
gal@server [~] $ rdma res
0: efa_0: pd 2 cq 4 qp 2 cm_id 0 mr 2 ctx 2
gal@server [~] $ rdma res show qp
link efa_0/1 lqpn 0 type UNKNOWN state RTS sq-psn 13400680 pdn 0 pid 17847 comm ib_send_bw
link efa_0/1 lqpn 1 type UNKNOWN state RTR sq-psn 0 pdn 1 pid 17820 comm ib_send_bw
We can change the UNKNOWN to DRIVER/something else in userspace code.
next prev parent reply other threads:[~2019-07-30 13:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 11:01 [PATCH for-rc] RDMA/restrack: Track driver QP types in resource tracker Gal Pressman
2019-07-30 12:19 ` Jason Gunthorpe
2019-07-30 12:21 ` Gal Pressman
2019-07-30 13:38 ` Leon Romanovsky
2019-07-30 13:49 ` Gal Pressman [this message]
2019-07-30 15:19 ` Leon Romanovsky
2019-07-31 7:05 ` Gal Pressman
2019-07-31 7:46 ` Leon Romanovsky
2019-07-31 7:53 ` Gal Pressman
2019-07-31 8:34 ` Leon Romanovsky
2019-07-31 8:51 ` Gal Pressman
2019-07-31 10:01 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24f4f7e3-dada-5185-3988-2e821b321bc1@amazon.com \
--to=galpress@amazon.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.