From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A0E5C433F5 for ; Tue, 16 Nov 2021 13:53:29 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64BCF61548 for ; Tue, 16 Nov 2021 13:53:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 64BCF61548 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8DA3B838BF; Tue, 16 Nov 2021 14:53:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="VOQWSbs4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 73D0F8169D; Tue, 16 Nov 2021 14:53:24 +0100 (CET) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8895683884 for ; Tue, 16 Nov 2021 14:53:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ariel.dalessandro@collabora.com Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: adalessandro) with ESMTPSA id 999AA1F454AB DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=collabora.com; s=mail; t=1637070799; bh=SKjCfXjVAAEpPAwKmcmBg9oxFIn4RcCkQnucdaM9xOI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=VOQWSbs470dZYHCHpZjHWAe25PlA7d8PkJkmmOmPtRdgNTR+xssImnFtUCx1zkhnu fFozenaUKNwP4dCigfN0mTO7boM66jEbNCpFlpvcxBx0GfGDWbTGfX0EH+ngOK3HVc MaLxsQ2TygyS3uPPwvaLvo0vdwsU8yPm+BTkFzMdVKgOfuHyQe8ZXA1gf4fr/X2dnk j0WTy8ix+0S6HG8vYrDEyIw8aPvpgDy2GvWBPsPQ88jBs+RocCTPdbHUNMi9trwDCF GzPGwj0y1S7qWlFGR32t8zd9CHKjK+PtJX1Kzwps3fA1cIzhptExG8jxy5Wg1I7/C/ 6UTHbi7M0ayZQ== Subject: Re: [PATCH v3 1/1] imx8mn_var_som: Add support for Variscite VAR-SOM-MX8M-NANO board To: Tom Rini , Fabio Estevam Cc: U-Boot-Denx , dl-uboot-imx , Adam Ford , Andre Przywara , ZHIZHIKIN Andrey , Christian Hewitt , Heiko Schocher , Ilko Iliev , Jagan Teki , Marcel Ziswiler , Neil Armstrong , Patrick Delaunay , Peter Robinson , Peng Fan , Rick Chen , Stefano Babic , Sean Anderson , Simon Glass , Teresa Remmet , Tim Harvey References: <20211116035055.1194673-1-ariel.dalessandro@collabora.com> <20211116035055.1194673-2-ariel.dalessandro@collabora.com> <20211116131347.GA24579@bill-the-cat> From: Ariel D'Alessandro Message-ID: <24fa628f-d8ad-a88c-1f27-17511117a911@collabora.com> Date: Tue, 16 Nov 2021 10:53:09 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20211116131347.GA24579@bill-the-cat> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On 11/16/21 10:13 AM, Tom Rini wrote: > On Tue, Nov 16, 2021 at 08:37:06AM -0300, Fabio Estevam wrote: >> Hi Ariel, >> >> The patch looks good. Only some minor comments: >> >> On Tue, Nov 16, 2021 at 12:51 AM Ariel D'Alessandro >> wrote: >>> >>> Add support for iMX8MN VAR-SOM-MX8M-NANO board. Enables support for: >>> >>> - 1GiB DDR4 RAM >>> - 16 GiB eMMC >>> - SD card >>> - Gigabit ethernet >>> - USBOTG1 peripheral - fastboot >>> >>> Signed-off-by: Ariel D'Alessandro >> >> It would be nice to have a README file so that the users can know how >> to build and flash mainline >> U-Boot in this board. > > And that means an entry under doc/board/variscite/ to be clear. Yes :-) thanks, will add it in v4.