On 10/25/2016 09:36 AM, Paolo Bonzini wrote: > > > On 25/10/2016 16:35, Eric Blake wrote: >> So your argument is that we should always pass down every unaligned >> less-than-optimum discard request all the way to the hardware, rather >> than dropping it higher in the stack, even though discard requests are >> already advisory, in order to leave the hardware as the ultimate >> decision on whether to ignore the unaligned request? > > Yes, I agree with Peter as to this. Okay, I'll work on patches. I think it counts as bug fix, so appropriate even if I miss soft freeze (I'd still like to get NBD write zero support into 2.8, since it already missed 2.7, but that one is still awaiting review with not much time left). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org