From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753344AbcBOWmI (ORCPT ); Mon, 15 Feb 2016 17:42:08 -0500 Received: from gloria.sntech.de ([95.129.55.99]:51662 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752757AbcBOWmG (ORCPT ); Mon, 15 Feb 2016 17:42:06 -0500 From: Heiko Stuebner To: Shawn Lin Cc: Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] clk: rockchip: don't return NULL when registering inverter fails Date: Mon, 15 Feb 2016 23:41:51 +0100 Message-ID: <2500574.XYymApL490@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <1455507213-13037-1-git-send-email-shawn.lin@rock-chips.com> References: <1455507153-12914-1-git-send-email-shawn.lin@rock-chips.com> <1455507213-13037-1-git-send-email-shawn.lin@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, 15. Februar 2016, 11:33:33 schrieb Shawn Lin: > Avoid return NULL if rockchip_clk_register_inverter fails, otherwise > rockchip_clk_register_branches print "unknown clock type". The acutal > case is that it's a known clock type but we fail to regiser it, which > may makes user confuse the reason of failure. > > Signed-off-by: Shawn Lin applied to my clk-branch for 4.6