From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932904AbcKVVIl (ORCPT ); Tue, 22 Nov 2016 16:08:41 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:51748 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755369AbcKVVIj (ORCPT ); Tue, 22 Nov 2016 16:08:39 -0500 From: Arnd Bergmann To: Lee Jones Cc: Milo Kim , bcousson@baylibre.com, Tony Lindgren , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Robert Nelson Subject: Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources Date: Tue, 22 Nov 2016 22:08:10 +0100 Message-ID: <2502592.54T1nU6yzL@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20161122160013.GH10134@dell.home> References: <20161121131515.8040-1-woogyom.kim@gmail.com> <20161122155759.GG10134@dell.home> <20161122160013.GH10134@dell.home> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:vqoaFUok2Z0wV0bcodDEQaNPR56h1lp07kG/S9ISV6Lc6OvtAbk EH0jr7SLz5du4FXW0+YTCw0K7jarxHRom2u9OFGl+24uZn4sBR2PC3C/CB0SOasx2qkjrk6 jqg85MLV/dV/0eqmXewpY3+aa66qhrsHP9pmTb9ZrXcyFqznUbFlLkowE1yJvdZNYEjDKVp mWno2vxX/pFu7Yyhm9HOg== X-UI-Out-Filterresults: notjunk:1;V01:K0:XihBZHUfziU=:/evF9a71dd8MVGnUAq0nNy JH/HyqcXPfVrLVl/bCiVsYP5j75Epq9XaZ5j6KygNaHw0LVwpAT7o5DR0JIKhHJpJBEsRsmbs FfJwmoE7COOT+jmw8JZ+LvFXjwz+zsVKk43S1I8Bvu4FMulIlHQuaTGwigKg5MMz4aITx/C4r N3bSIDdU275Q1MfKzOXrGqrywF/pEFhlkolNfdDaPcDAn1ebHqYctNlWRZHx8PvTSbm5Ogv9U xlTUBcOKVA+9sJRALW5IpAQOTf3FhzrZNiT3mnMAqS6UPKkIXoXtSLxkml55NiRl3z6pRl4u5 hmxf1O+KxX+LUU00cQopQ8ZKHTaNVAR7phVe0kZQ43scqTR8qxJjbJYHvjVc10szLTCbUf2lT paT54dENLmHjkfyPDkdvbcKGax/9m71DbVbwWtjm8CTI3Wb8aE1s8ZUrNZIytyEfVOnjQ1h8M Wl6NLE6/Jp0DtjhSkIQZRBBxnYyKZmssYqAzmgQ5VJm9igrvJmmtQCunCjAjUc733Njaqgkl8 Rm1aTqdEg7PffT6V345xoA5PFm2Zvj1cQb6XGCwPCCbCuj8BzuW4FG1fsNMtKyS3jB57gWQzh 7jMIj6g92oCQ4uHatsBhI/kVg+Xd2+MhG+QqVIMwfYJjE/eW/F4dQQIUwAH2xf8TGz6BNElTH inaw0kYJtwdwX4S7rY1CTscAKQ8pDGN5a0Q8RS8ww4gJNWQ9O3XKqDrLkeVQw2hSDsWYPSAqG j7LNO8M2Hz6md4vn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, November 22, 2016 4:00:13 PM CET Lee Jones wrote: > > > diff --git a/include/dt-bindings/mfd/tps65217.h b/include/dt-bindings/mfd/tps65217.h > > > index cafb9e6..0293fdd 100644 > > > --- a/include/dt-bindings/mfd/tps65217.h > > > +++ b/include/dt-bindings/mfd/tps65217.h > > > @@ -19,8 +19,8 @@ > > > #ifndef __DT_BINDINGS_TPS65217_H__ > > > #define __DT_BINDINGS_TPS65217_H__ > > > > > > -#define TPS65217_IRQ_USB 0 > > > -#define TPS65217_IRQ_AC 1 > > > -#define TPS65217_IRQ_PB 2 > > > +#define TPS65217_IRQ_USB_POWER 0 /* USB power state change */ > > > +#define TPS65217_IRQ_AC_POWER 1 /* AC power state change */ > > > +#define TPS65217_IRQ_PUSHBUTTON 2 /* Push button state change */ > > > > This changes the ABI. > > > > It will require a DT Ack. > > Tell a lie. Sorry, I was getting false positives from my grep. It > looks like you use the same scheme from within include/linux. I > suggest that you probable don't want to do that. Doing this change however would cause a bisection problem: you can't rename just the constants in the header or just the driver using those constants. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources Date: Tue, 22 Nov 2016 22:08:10 +0100 Message-ID: <2502592.54T1nU6yzL@wuerfel> References: <20161121131515.8040-1-woogyom.kim@gmail.com> <20161122155759.GG10134@dell.home> <20161122160013.GH10134@dell.home> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20161122160013.GH10134-Re9dqnLqz4GzQB+pC5nmwQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lee Jones Cc: Milo Kim , bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, Tony Lindgren , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Robert Nelson List-Id: devicetree@vger.kernel.org On Tuesday, November 22, 2016 4:00:13 PM CET Lee Jones wrote: > > > diff --git a/include/dt-bindings/mfd/tps65217.h b/include/dt-bindings/mfd/tps65217.h > > > index cafb9e6..0293fdd 100644 > > > --- a/include/dt-bindings/mfd/tps65217.h > > > +++ b/include/dt-bindings/mfd/tps65217.h > > > @@ -19,8 +19,8 @@ > > > #ifndef __DT_BINDINGS_TPS65217_H__ > > > #define __DT_BINDINGS_TPS65217_H__ > > > > > > -#define TPS65217_IRQ_USB 0 > > > -#define TPS65217_IRQ_AC 1 > > > -#define TPS65217_IRQ_PB 2 > > > +#define TPS65217_IRQ_USB_POWER 0 /* USB power state change */ > > > +#define TPS65217_IRQ_AC_POWER 1 /* AC power state change */ > > > +#define TPS65217_IRQ_PUSHBUTTON 2 /* Push button state change */ > > > > This changes the ABI. > > > > It will require a DT Ack. > > Tell a lie. Sorry, I was getting false positives from my grep. It > looks like you use the same scheme from within include/linux. I > suggest that you probable don't want to do that. Doing this change however would cause a bisection problem: you can't rename just the constants in the header or just the driver using those constants. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 22 Nov 2016 22:08:10 +0100 Subject: [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources In-Reply-To: <20161122160013.GH10134@dell.home> References: <20161121131515.8040-1-woogyom.kim@gmail.com> <20161122155759.GG10134@dell.home> <20161122160013.GH10134@dell.home> Message-ID: <2502592.54T1nU6yzL@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday, November 22, 2016 4:00:13 PM CET Lee Jones wrote: > > > diff --git a/include/dt-bindings/mfd/tps65217.h b/include/dt-bindings/mfd/tps65217.h > > > index cafb9e6..0293fdd 100644 > > > --- a/include/dt-bindings/mfd/tps65217.h > > > +++ b/include/dt-bindings/mfd/tps65217.h > > > @@ -19,8 +19,8 @@ > > > #ifndef __DT_BINDINGS_TPS65217_H__ > > > #define __DT_BINDINGS_TPS65217_H__ > > > > > > -#define TPS65217_IRQ_USB 0 > > > -#define TPS65217_IRQ_AC 1 > > > -#define TPS65217_IRQ_PB 2 > > > +#define TPS65217_IRQ_USB_POWER 0 /* USB power state change */ > > > +#define TPS65217_IRQ_AC_POWER 1 /* AC power state change */ > > > +#define TPS65217_IRQ_PUSHBUTTON 2 /* Push button state change */ > > > > This changes the ABI. > > > > It will require a DT Ack. > > Tell a lie. Sorry, I was getting false positives from my grep. It > looks like you use the same scheme from within include/linux. I > suggest that you probable don't want to do that. Doing this change however would cause a bisection problem: you can't rename just the constants in the header or just the driver using those constants. Arnd