From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ale.deltatee.com (ale.deltatee.com [207.54.116.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DD3BF224E693F for ; Thu, 1 Mar 2018 13:17:00 -0800 (PST) References: <20180228234006.21093-1-logang@deltatee.com> <1519876489.4592.3.camel@kernel.crashing.org> <1519876569.4592.4.camel@au1.ibm.com> <1519938210.4592.30.camel@au1.ibm.com> <1de70207-40ce-29f0-6093-337112852475@deltatee.com> <20180301211817.GC6742@redhat.com> From: Logan Gunthorpe Message-ID: <25034ee7-de03-ed77-78e0-2333f46897cc@deltatee.com> Date: Thu, 1 Mar 2018 14:22:56 -0700 MIME-Version: 1.0 In-Reply-To: <20180301211817.GC6742@redhat.com> Content-Language: en-US Subject: Re: [PATCH v2 00/10] Copy Offload in NVMe Fabrics with P2P PCI Memory List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Jerome Glisse Cc: Jens Axboe , Keith Busch , Oliver OHalloran , benh@au1.ibm.com, linux-nvdimm , linux-rdma , linux-pci@vger.kernel.org, Linux Kernel Mailing List , linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, Alex Williamson , Jason Gunthorpe , Bjorn Helgaas , Max Gurtovoy , Christoph Hellwig List-ID: On 01/03/18 02:18 PM, Jerome Glisse wrote: > This is pretty easy to do with HMM: > > unsigned long hmm_page_to_phys_pfn(struct page *page) This is not useful unless you want to go through all the kernel paths we are using and replace page_to_phys() and friends with something else that calls an HMM function when appropriate... The problem isn't getting the physical address from a page, it's that we are passing these pages through various kernel interfaces which expect pages that work in the usual manner. (Look at the code: we quite simply provide a way to get the PCI bus address from a page when necessary). Logan _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: To: Jerome Glisse Cc: benh@au1.ibm.com, Dan Williams , Linux Kernel Mailing List , linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma , linux-nvdimm , linux-block@vger.kernel.org, Stephen Bates , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg , Bjorn Helgaas , Jason Gunthorpe , Max Gurtovoy , Alex Williamson , Oliver OHalloran References: <20180228234006.21093-1-logang@deltatee.com> <1519876489.4592.3.camel@kernel.crashing.org> <1519876569.4592.4.camel@au1.ibm.com> <1519938210.4592.30.camel@au1.ibm.com> <1de70207-40ce-29f0-6093-337112852475@deltatee.com> <20180301211817.GC6742@redhat.com> From: Logan Gunthorpe Message-ID: <25034ee7-de03-ed77-78e0-2333f46897cc@deltatee.com> Date: Thu, 1 Mar 2018 14:22:56 -0700 MIME-Version: 1.0 In-Reply-To: <20180301211817.GC6742@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Subject: Re: [PATCH v2 00/10] Copy Offload in NVMe Fabrics with P2P PCI Memory List-ID: On 01/03/18 02:18 PM, Jerome Glisse wrote: > This is pretty easy to do with HMM: > > unsigned long hmm_page_to_phys_pfn(struct page *page) This is not useful unless you want to go through all the kernel paths we are using and replace page_to_phys() and friends with something else that calls an HMM function when appropriate... The problem isn't getting the physical address from a page, it's that we are passing these pages through various kernel interfaces which expect pages that work in the usual manner. (Look at the code: we quite simply provide a way to get the PCI bus address from a page when necessary). Logan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Logan Gunthorpe Subject: Re: [PATCH v2 00/10] Copy Offload in NVMe Fabrics with P2P PCI Memory Date: Thu, 1 Mar 2018 14:22:56 -0700 Message-ID: <25034ee7-de03-ed77-78e0-2333f46897cc@deltatee.com> References: <20180228234006.21093-1-logang@deltatee.com> <1519876489.4592.3.camel@kernel.crashing.org> <1519876569.4592.4.camel@au1.ibm.com> <1519938210.4592.30.camel@au1.ibm.com> <1de70207-40ce-29f0-6093-337112852475@deltatee.com> <20180301211817.GC6742@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180301211817.GC6742-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Jerome Glisse Cc: Jens Axboe , Keith Busch , Oliver OHalloran , benh-8fk3Idey6ehBDgjK7y7TUQ@public.gmane.org, linux-nvdimm , linux-rdma , linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Kernel Mailing List , linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alex Williamson , Jason Gunthorpe , Bjorn Helgaas , Max Gurtovoy , Christoph Hellwig List-Id: linux-rdma@vger.kernel.org On 01/03/18 02:18 PM, Jerome Glisse wrote: > This is pretty easy to do with HMM: > > unsigned long hmm_page_to_phys_pfn(struct page *page) This is not useful unless you want to go through all the kernel paths we are using and replace page_to_phys() and friends with something else that calls an HMM function when appropriate... The problem isn't getting the physical address from a page, it's that we are passing these pages through various kernel interfaces which expect pages that work in the usual manner. (Look at the code: we quite simply provide a way to get the PCI bus address from a page when necessary). Logan From mboxrd@z Thu Jan 1 00:00:00 1970 From: logang@deltatee.com (Logan Gunthorpe) Date: Thu, 1 Mar 2018 14:22:56 -0700 Subject: [PATCH v2 00/10] Copy Offload in NVMe Fabrics with P2P PCI Memory In-Reply-To: <20180301211817.GC6742@redhat.com> References: <20180228234006.21093-1-logang@deltatee.com> <1519876489.4592.3.camel@kernel.crashing.org> <1519876569.4592.4.camel@au1.ibm.com> <1519938210.4592.30.camel@au1.ibm.com> <1de70207-40ce-29f0-6093-337112852475@deltatee.com> <20180301211817.GC6742@redhat.com> Message-ID: <25034ee7-de03-ed77-78e0-2333f46897cc@deltatee.com> On 01/03/18 02:18 PM, Jerome Glisse wrote: > This is pretty easy to do with HMM: > > unsigned long hmm_page_to_phys_pfn(struct page *page) This is not useful unless you want to go through all the kernel paths we are using and replace page_to_phys() and friends with something else that calls an HMM function when appropriate... The problem isn't getting the physical address from a page, it's that we are passing these pages through various kernel interfaces which expect pages that work in the usual manner. (Look at the code: we quite simply provide a way to get the PCI bus address from a page when necessary). Logan