From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mail.openembedded.org (Postfix) with ESMTP id 2914D6BBDC for ; Mon, 31 Mar 2014 12:19:18 +0000 (UTC) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 31 Mar 2014 05:13:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,765,1389772800"; d="scan'208";a="483942673" Received: from williams-mobl.ger.corp.intel.com (HELO peggleto-mobl5.ger.corp.intel.com) ([10.252.120.67]) by orsmga001.jf.intel.com with ESMTP; 31 Mar 2014 05:18:12 -0700 From: Paul Eggleton To: "Stanacar, StefanX" Date: Mon, 31 Mar 2014 13:18:11 +0100 Message-ID: <2505811.xE1RLRgDA1@peggleto-mobl5.ger.corp.intel.com> Organization: Intel Corporation User-Agent: KMail/4.12.3 (Linux/3.13.6-200.fc20.x86_64; KDE/4.12.3; x86_64; ; ) In-Reply-To: <1396267153.6418.5.camel@firebird.rb.intel.com> References: <1396259888.14790.58.camel@ted> <1396267153.6418.5.camel@firebird.rb.intel.com> MIME-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 1/1] core-image-lsb: enforce pam as a needed distro feature X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Mar 2014 12:19:20 -0000 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Monday 31 March 2014 11:58:49 Stanacar, StefanX wrote: > On Mon, 2014-03-31 at 10:58 +0100, Richard Purdie wrote: > > On Mon, 2014-03-31 at 12:51 +0300, Cristian Iorga wrote: > > > core-image-lsb only gave a warning: > > > "WARNING: Building libpam but 'pam' isn't in DISTRO_FEATURES, > > > PAM won't work correctly" > > > when the proper DISTRO was not set for it. > > > default choice would be DISTRO = "poky-lsb", > > > but not necessarily, depending on each custom distro. > > > > > > This fix will enforce the proper usage of pam > > > as a distro feature for core-image-lsb by giving > > > an error instead of just a warning. > > > > > > Fixes [YOCTO #6073] > > > > > > Signed-off-by: Cristian Iorga > > > --- > > > > > > meta/recipes-extended/images/core-image-lsb.bb | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/meta/recipes-extended/images/core-image-lsb.bb > > > b/meta/recipes-extended/images/core-image-lsb.bb index ed316a6..ab61c6e > > > 100644 > > > --- a/meta/recipes-extended/images/core-image-lsb.bb > > > +++ b/meta/recipes-extended/images/core-image-lsb.bb > > > @@ -9,4 +9,6 @@ IMAGE_INSTALL = "\ > > > > > > packagegroup-core-lsb \ > > > " > > > > > > -inherit core-image > > > +inherit core-image distro_features_check > > > + > > > +REQUIRED_DISTRO_FEATURES = "pam" > > > > I have a feeling the autobuilder builds core-image-lsb in situations > > where DISTRO=poky, although I could be wrong. Have you checked? > > FWIW, all the -lsb buildsets are done with DISTRO=poky-lsb on the AB. > Unfortuntely we do have one problematic build. > So the answer to your question is: we don't have core-image-lsb builds > with DISTRO=poky but we do have a lib64-core-image-lsb-sdk image built > with DISTRO=poky and no pam in DISTRO_FEATURES, see the last build on > nightly-multilib... :( If we're doing this then we should be changing the autobuilder so it doesn't. LSB images should not be built in non-LSB configuration. Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre