From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bvSkk-0000qj-TA for qemu-devel@nongnu.org; Sat, 15 Oct 2016 13:28:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bvSki-0005x8-KQ for qemu-devel@nongnu.org; Sat, 15 Oct 2016 13:28:09 -0400 References: <20160928204644.11523-1-mreitz@redhat.com> <1b3f7281-eaa6-586b-0f3c-f30cebf88322@linux.vnet.ibm.com> <59343543-96c7-ebc1-5889-7259df3a2c90@redhat.com> <8bf56524-e566-85a2-3cde-b503e178b8e9@linux.vnet.ibm.com> From: Max Reitz Message-ID: <2510482c-9d74-1366-9839-8995394ac657@redhat.com> Date: Sat, 15 Oct 2016 19:27:57 +0200 MIME-Version: 1.0 In-Reply-To: <8bf56524-e566-85a2-3cde-b503e178b8e9@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VLoO5R7GjrCjcbhtFlQ3ocsJPIA5jwux4" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v4 0/3] iotests: Fix test 162 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hao QingFeng , qemu-block@nongnu.org Cc: Kevin Wolf , Sascha Silbe , qemu-devel@nongnu.org, Stefan Hajnoczi , Liu Jing , Christian Borntraeger , Cornelia Huck This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VLoO5R7GjrCjcbhtFlQ3ocsJPIA5jwux4 From: Max Reitz To: Hao QingFeng , qemu-block@nongnu.org Cc: Kevin Wolf , Sascha Silbe , qemu-devel@nongnu.org, Stefan Hajnoczi , Liu Jing , Christian Borntraeger , Cornelia Huck Message-ID: <2510482c-9d74-1366-9839-8995394ac657@redhat.com> Subject: Re: [Qemu-block] [PATCH v4 0/3] iotests: Fix test 162 References: <20160928204644.11523-1-mreitz@redhat.com> <1b3f7281-eaa6-586b-0f3c-f30cebf88322@linux.vnet.ibm.com> <59343543-96c7-ebc1-5889-7259df3a2c90@redhat.com> <8bf56524-e566-85a2-3cde-b503e178b8e9@linux.vnet.ibm.com> In-Reply-To: <8bf56524-e566-85a2-3cde-b503e178b8e9@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 13.10.2016 07:20, Hao QingFeng wrote: >=20 >=20 > =E5=9C=A8 2016-10-13 3:46, Max Reitz =E5=86=99=E9=81=93: >> On 12.10.2016 10:55, Hao QingFeng wrote: >>> Max, >>> >>> Just a common question for this case, if sshx block driver wasn't bui= lt >>> into qemu-img, this case would fail as below: >> Good point, and thanks for bringing it up, but it's not directly linke= d >> to this series other than by its subject, of course, so I'd rather add= a >> fix on top. > Thanks and sorry for sending to the improper mail series. >>> exec /home/haoqf/KVMonz/qemu/tests/qemu-iotests/../../qemu-img info >>> --image-opts driver=3Dssh,host=3Dlocalhost,port=3D0.42,path=3D/foo >>> qemu-img: Could not open >>> 'driver=3Dssh,host=3Dlocalhost,port=3D0.42,path=3D/foo': Unknown driv= er 'ssh' >>> >>> Adding 162.notrun can bypass this case but it would skip it even if >>> qemu-img has sshx block driver, in which case I think it should be ru= n. >>> >>> So How about adding a script to dynamically check at runtime if the >>> current env qemu-img can meet the requirement to run the test or not?= >> Unfortunately, the list of block drivers listed by will not contain ss= h >> if ssh is built as a module, which is possible. > Actually I am not sure if I understood it. Do you mean > "CONFIG_LIBSSH2=3Dm" set > rather than "CONFIG_LIBSSH2=3Dy" in config-host.mak? But in the configu= re > it's > set to be "CONFIG_LIBSSH2=3Dy": > if test "$libssh2" =3D "yes" ; then > echo "CONFIG_LIBSSH2=3Dy" >> $config_host_mak > echo "LIBSSH2_CFLAGS=3D$libssh2_cflags" >> $config_host_mak > echo "LIBSSH2_LIBS=3D$libssh2_libs" >> $config_host_mak > fi I don't know which version of qemu you are looking at, but on master it says "m" instead of "y" there: http://git.qemu.org/?p=3Dqemu.git;a=3Dblob;f=3Dconfigure;h=3Ddd9e6792bbe0= 4411d81eb5438d58eb1999d4dcd2;hb=3DHEAD#l5477 > Meanwhile I changed it to be "CONFIG_LIBSSH2=3Dm" and reconfig, make th= e > qemu, > qemu-img --help can still prompt ssh. Have you tried building master with --enable-modules specified for configure? Max >> This is a bug that should be fixed, but I'd rather do so in a separate= >> series from this one. >> >> In any case, once it is fixed I'd rather just take the approach quorum= >> tests take already (e.g. test 081), which is something like: >> >> test_ssh=3D$($QEMU_IMG --help | grep '^Supported formats:.* ssh\( \|$\= )') >> [ "$test_ssh" =3D "" ] && _notrun "ssh support required" > Cool. Agree with this like what was done in 081. thanks >> Max >> >=20 --VLoO5R7GjrCjcbhtFlQ3ocsJPIA5jwux4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEvBAEBCAAZBQJYAmcdEhxtcmVpdHpAcmVkaGF0LmNvbQAKCRD0B9sAYdXPQDz+ B/9dlm9+bfhRMDDbqeSqlXA0MqG2lgXIVl8eigMdesz5AhIKpvfLGmhdLPNSRMwf EfLLChz+MkrYPMKAMXwK41+1vHT0LtBFRrC3yukq/JPeRz4qG0+6KjIUHVRlkmpo IUtVc6CGk5wAIOFDmrkj24GqfztwHrl1QSteUhlI+FXYFGuTJbRWif62EVbw8NQ4 DQTAjYh7DeUZFziuVpj2AyAd6M5QVgjZz3vhMUSg2dtooWufUtBlw3CIuhZwfsA3 MxRm0/wLtVa3BJeLWjNCb49h5p5TeBa5861yx2lApiMEYPgnzGpzOMDCh7lrj6gJ 6ejPS8tPP9EMzBnn7f2u29ta =yrOI -----END PGP SIGNATURE----- --VLoO5R7GjrCjcbhtFlQ3ocsJPIA5jwux4--