All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Dongli Zhang <dongli.zhang@oracle.com>, qemu-devel@nongnu.org
Cc: berrange@redhat.com, ehabkost@redhat.com, mst@redhat.com,
	joe.jin@oracle.com, dgilbert@redhat.com, pbonzini@redhat.com
Subject: Re: [PATCH RFC 0/1] To add HMP interface to dump PCI MSI-X table/PBA
Date: Fri, 23 Apr 2021 14:01:06 +0800	[thread overview]
Message-ID: <25113515-5c1d-c557-d0cc-04bfacecb6ee@redhat.com> (raw)
In-Reply-To: <20210423044713.3403-1-dongli.zhang@oracle.com>


在 2021/4/23 下午12:47, Dongli Zhang 写道:
> This is inspired by the discussion with Jason on below patchset.
>
> https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg09020.html
>
> The new HMP command is introduced to dump the MSI-X table and PBA.
>
> Initially, I was going to add new option to "info pci". However, as the
> number of entries is not determined and the output of MSI-X table is much
> more similar to the output of hmp_info_tlb()/hmp_info_mem(), this patch
> adds interface for only HMP.
>
> The patch is tagged with RFC because I am looking for suggestions on:
>
> 1. Is it fine to add new "info msix <dev>" command?


I wonder the reason for not simply reusing "info pci"?


>
> 2. Is there any issue with output format?


If it's not for QMP, I guess it's not a part of ABI so it should be fine.


>
> 3. Is it fine to add only for HMP, but not QMP?


I think so.

Thanks


>
> Thank you very much!
>
> Dongli Zhang
>
>
>



  parent reply	other threads:[~2021-04-23  6:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23  4:47 [PATCH RFC 0/1] To add HMP interface to dump PCI MSI-X table/PBA Dongli Zhang
2021-04-23  4:47 ` [PATCH RFC 1/1] msix: add hmp interface to dump MSI-X info Dongli Zhang
2021-04-23  7:59   ` Jason Wang
2021-04-23 17:32     ` Dongli Zhang
2021-04-25  3:36       ` Jason Wang
2021-04-26  5:41         ` Dongli Zhang
2021-04-23  6:01 ` Jason Wang [this message]
2021-04-23 17:26   ` [PATCH RFC 0/1] To add HMP interface to dump PCI MSI-X table/PBA Dongli Zhang
2021-04-25  3:34     ` Jason Wang
2021-04-27  8:53     ` Dr. David Alan Gilbert
2021-04-28  2:31       ` Jason Wang
2021-04-28  5:10         ` Dongli Zhang
2021-04-28  5:55           ` Jason Wang
2021-04-28  6:25             ` Dongli Zhang
2021-04-28  8:45           ` Dr. David Alan Gilbert
2021-04-28 15:59             ` Dongli Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25113515-5c1d-c557-d0cc-04bfacecb6ee@redhat.com \
    --to=jasowang@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=dongli.zhang@oracle.com \
    --cc=ehabkost@redhat.com \
    --cc=joe.jin@oracle.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.