From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754779AbdJIUVf (ORCPT ); Mon, 9 Oct 2017 16:21:35 -0400 Received: from mail.kdab.com ([176.9.126.58]:47198 "EHLO mail.kdab.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754076AbdJIUVe (ORCPT ); Mon, 9 Oct 2017 16:21:34 -0400 From: Milian Wolff To: Namhyung Kim Cc: acme@kernel.org, jolsa@kernel.org, Jin Yao , Linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , David Ahern , Peter Zijlstra , kernel-team@lge.com Subject: Re: [PATCH v4 14/15] perf report: use srcline from callchain for hist entries Date: Mon, 09 Oct 2017 22:21:30 +0200 Message-ID: <25129135.mgkeNORqek@agathebauer> Organization: KDAB (Deutschland) GmbH&Co KG, a KDAB Group company In-Reply-To: <20171005040829.GA1584@danjae.aot.lge.com> References: <20171001143100.19988-1-milian.wolff@kdab.com> <20171001143100.19988-15-milian.wolff@kdab.com> <20171005040829.GA1584@danjae.aot.lge.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Donnerstag, 5. Oktober 2017 06:08:29 CEST Namhyung Kim wrote: > On Sun, Oct 01, 2017 at 04:30:59PM +0200, Milian Wolff wrote: > > This also removes the symbol name from the srcline column, > > more on this below. > > > > This ensures we use the correct srcline, which could originate > > from a potentially inlined function. The hist entries used to > > query for the srcline based purely on the IP, which leads to > > wrong results for inlined entries. > > Yep, AFAICS current srcline returns the first entry in a inline-chain > and the srcfile (sort key) returns the last. I think we need to make > it consistent. It seems this patch fix it when --inline option is > used, but I guess the --no-inline case still has the problem. I'm not sure I've understood you correctly. There is indeed an issue still when passing --no-inline, which seems to arise from the use of map__rip_2objdump instead of map__objdump_2mem. I've changed that now and will include that patch in v5 of this patch series. Cheers -- Milian Wolff | milian.wolff@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH&Co KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts