All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: linux@armlinux.org.uk, mripard@kernel.org, wens@csie.org,
	Corentin Labbe <clabbe@baylibre.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
	Corentin Labbe <clabbe@baylibre.com>
Subject: Re: [PATCH RESEND] ARM: configs: sunxi: enable brcm wireless
Date: Sun, 27 Dec 2020 21:03:23 +0100	[thread overview]
Message-ID: <25142918.GuFC1uy7vR@jernej-laptop> (raw)
In-Reply-To: <20201227200000.28526-1-clabbe@baylibre.com>

Hi!

Dne nedelja, 27. december 2020 ob 21:00:00 CET je Corentin Labbe napisal(a):
> Lot of sunxi boards have BRCM wireless device, so let's enable necessary
> options for it in our defconfig.

Idea is good but modules (=m) instead of build in (=y) would be better. As you 
said, not all boards have such wifi and there is no need to make kernel binary 
bigger.

Best regards,
Jernej

> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
>  arch/arm/configs/sunxi_defconfig | 23 ++++++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/configs/sunxi_defconfig
> b/arch/arm/configs/sunxi_defconfig index a60c134c5e04..4891aefdef7d 100644
> --- a/arch/arm/configs/sunxi_defconfig
> +++ b/arch/arm/configs/sunxi_defconfig
> @@ -52,7 +52,28 @@ CONFIG_STMMAC_ETH=y
>  # CONFIG_NET_VENDOR_WIZNET is not set
>  CONFIG_MICREL_PHY=y
>  CONFIG_REALTEK_PHY=y
> -# CONFIG_WLAN is not set
> +CONFIG_WLAN=y
> +# CONFIG_WLAN_VENDOR_ADMTEK is not set
> +# CONFIG_WLAN_VENDOR_ATH is not set
> +# CONFIG_WLAN_VENDOR_ATMEL is not set
> +CONFIG_WLAN_VENDOR_BROADCOM=y
> +# CONFIG_WLAN_VENDOR_CISCO is not set
> +# CONFIG_WLAN_VENDOR_INTEL is not set
> +# CONFIG_WLAN_VENDOR_INTERSIL is not set
> +# CONFIG_WLAN_VENDOR_MARVELL is not set
> +# CONFIG_WLAN_VENDOR_MEDIATEK is not set
> +# CONFIG_WLAN_VENDOR_MICROCHIP is not set
> +# CONFIG_WLAN_VENDOR_RALINK is not set
> +# CONFIG_WLAN_VENDOR_REALTEK is not set
> +# CONFIG_WLAN_VENDOR_RSI is not set
> +# CONFIG_WLAN_VENDOR_ST is not set
> +# CONFIG_WLAN_VENDOR_TI is not set
> +# CONFIG_WLAN_VENDOR_ZYDAS is not set
> +# CONFIG_WLAN_VENDOR_QUANTENNA is not set
> +CONFIG_CFG80211=y
> +CONFIG_CFG80211_WEXT=y
> +CONFIG_MAC80211=y
> +CONFIG_BRCMFMAC=y
>  CONFIG_INPUT_EVDEV=y
>  CONFIG_KEYBOARD_SUN4I_LRADC=y
>  # CONFIG_INPUT_MOUSE is not set





WARNING: multiple messages have this Message-ID (diff)
From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: linux@armlinux.org.uk, mripard@kernel.org, wens@csie.org,
	Corentin Labbe <clabbe@baylibre.com>
Cc: linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Corentin Labbe <clabbe@baylibre.com>
Subject: Re: [PATCH RESEND] ARM: configs: sunxi: enable brcm wireless
Date: Sun, 27 Dec 2020 21:03:23 +0100	[thread overview]
Message-ID: <25142918.GuFC1uy7vR@jernej-laptop> (raw)
In-Reply-To: <20201227200000.28526-1-clabbe@baylibre.com>

Hi!

Dne nedelja, 27. december 2020 ob 21:00:00 CET je Corentin Labbe napisal(a):
> Lot of sunxi boards have BRCM wireless device, so let's enable necessary
> options for it in our defconfig.

Idea is good but modules (=m) instead of build in (=y) would be better. As you 
said, not all boards have such wifi and there is no need to make kernel binary 
bigger.

Best regards,
Jernej

> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
>  arch/arm/configs/sunxi_defconfig | 23 ++++++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/configs/sunxi_defconfig
> b/arch/arm/configs/sunxi_defconfig index a60c134c5e04..4891aefdef7d 100644
> --- a/arch/arm/configs/sunxi_defconfig
> +++ b/arch/arm/configs/sunxi_defconfig
> @@ -52,7 +52,28 @@ CONFIG_STMMAC_ETH=y
>  # CONFIG_NET_VENDOR_WIZNET is not set
>  CONFIG_MICREL_PHY=y
>  CONFIG_REALTEK_PHY=y
> -# CONFIG_WLAN is not set
> +CONFIG_WLAN=y
> +# CONFIG_WLAN_VENDOR_ADMTEK is not set
> +# CONFIG_WLAN_VENDOR_ATH is not set
> +# CONFIG_WLAN_VENDOR_ATMEL is not set
> +CONFIG_WLAN_VENDOR_BROADCOM=y
> +# CONFIG_WLAN_VENDOR_CISCO is not set
> +# CONFIG_WLAN_VENDOR_INTEL is not set
> +# CONFIG_WLAN_VENDOR_INTERSIL is not set
> +# CONFIG_WLAN_VENDOR_MARVELL is not set
> +# CONFIG_WLAN_VENDOR_MEDIATEK is not set
> +# CONFIG_WLAN_VENDOR_MICROCHIP is not set
> +# CONFIG_WLAN_VENDOR_RALINK is not set
> +# CONFIG_WLAN_VENDOR_REALTEK is not set
> +# CONFIG_WLAN_VENDOR_RSI is not set
> +# CONFIG_WLAN_VENDOR_ST is not set
> +# CONFIG_WLAN_VENDOR_TI is not set
> +# CONFIG_WLAN_VENDOR_ZYDAS is not set
> +# CONFIG_WLAN_VENDOR_QUANTENNA is not set
> +CONFIG_CFG80211=y
> +CONFIG_CFG80211_WEXT=y
> +CONFIG_MAC80211=y
> +CONFIG_BRCMFMAC=y
>  CONFIG_INPUT_EVDEV=y
>  CONFIG_KEYBOARD_SUN4I_LRADC=y
>  # CONFIG_INPUT_MOUSE is not set





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-12-27 20:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-27 20:00 [PATCH RESEND] ARM: configs: sunxi: enable brcm wireless Corentin Labbe
2020-12-27 20:00 ` Corentin Labbe
2020-12-27 20:03 ` Jernej Škrabec [this message]
2020-12-27 20:03   ` Jernej Škrabec
2020-12-28  2:36   ` [linux-sunxi] " Chen-Yu Tsai
2020-12-28  2:36     ` Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25142918.GuFC1uy7vR@jernej-laptop \
    --to=jernej.skrabec@siol.net \
    --cc=clabbe@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=linux@armlinux.org.uk \
    --cc=mripard@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.