From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 812BAC48BDF for ; Sun, 20 Jun 2021 14:27:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1042F6108E for ; Sun, 20 Jun 2021 14:27:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1042F6108E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luyPc-0006Cz-SZ for qemu-devel@archiver.kernel.org; Sun, 20 Jun 2021 10:27:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luyOw-0005Rq-TI for qemu-devel@nongnu.org; Sun, 20 Jun 2021 10:26:19 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:50135) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luyOt-0001U9-2k for qemu-devel@nongnu.org; Sun, 20 Jun 2021 10:26:18 -0400 Received: from [192.168.100.1] ([82.142.1.74]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.119]) with ESMTPSA (Nemesis) id 1Mgf4k-1lN0dJ2XsK-00h9Bu; Sun, 20 Jun 2021 16:26:09 +0200 Subject: Re: [PATCH 2/2] tests/tcg/linux-test: Check that sigaction can query SIGKILL/SIGSTOP To: Ilya Leoshkevich , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20210601145600.3131040-1-iii@linux.ibm.com> <20210601145600.3131040-3-iii@linux.ibm.com> From: Laurent Vivier Message-ID: <2519118c-c5c4-c759-a17c-9c49e5bfac22@vivier.eu> Date: Sun, 20 Jun 2021 16:26:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210601145600.3131040-3-iii@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:HjRHyxsMwOXysl72zQuInCZ+UVtM4GG1uyVCvardRZV6ZOCjP7S 0+ql5/XcBnGJpPH3bcqjl3mDrxnTA3ADz9w8o5YSqcX+cy2pEJAZiIs1MGEKQwxb+LZEMNn 2IOkf2T6enT4QFiahCSn4/YjUmiUZJ51DWHMVGuP7qHUqp37qdh20KUe2Hzps47jfFzqoKL ZDPr7iteZJ5pOM31ryggg== X-UI-Out-Filterresults: notjunk:1;V03:K0:hNA9SKi9Fvw=:5Mt8o+AT5KYQIE+5bH+hCU hfW6RDpyVKRJ2pSW5wIpAQFLbUFH1qTl+dP6OST7fUhoojyVzcjULZadfOm5X4M5YVNJoVgO0 sgoue6V64Zc+f77ECeCt1r9ysy8S2EwE2j+G7RsjeKVe+mxMSXpmIBr6AGZ/aIgeTyIb/4Peq 49eknjjFN99wQhFEd4biPPTifQWIm0jf5+kqQTPjwo/Vx492P3174mAVIkIc8Xb/drrW1kZRr uc/crNuLv4V8yS4P4EbP2XMXjc/hZdxDBRIIUnawoS+Y2Up5c44miW9st3AKjNAbMe4ouQbhA FVuuzKoMJLZrtPoaCjpq84wabk59kP0z0ORaMWsozv7hw3a8+fh/ZEwVw891mHeG5ht+rignX nLTHjSNt39swAruepoOzV6GQv28ArsYgPS33WfEFDZlqaANKU4uqxPpACsQW/Nc/HIZXNaP4s 5i11p0sUClW+p5C8p+nYZkqtaunoTJ6Y2yGx00wataavXH3wxvT3LYpzTDqjQF39ZWyxj3icp WwzkP8bZJFskicoHlqOjjU= Received-SPF: none client-ip=217.72.192.73; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Borntraeger , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 01/06/2021 à 16:56, Ilya Leoshkevich a écrit : > Verify that querying is allowed, but making changes isn't. > > Signed-off-by: Ilya Leoshkevich > --- > tests/tcg/multiarch/linux-test.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-test.c > index ce033c21c7..cd9d8159bc 100644 > --- a/tests/tcg/multiarch/linux-test.c > +++ b/tests/tcg/multiarch/linux-test.c > @@ -496,6 +496,15 @@ static void test_signal(void) > sigemptyset(&act.sa_mask); > act.sa_flags = 0; > chk_error(sigaction(SIGSEGV, &act, NULL)); > + > + if (sigaction(SIGKILL, &act, NULL) == 0) { > + error("sigaction(SIGKILL, &act, NULL) must not succeed"); > + } > + if (sigaction(SIGSTOP, &act, NULL) == 0) { > + error("sigaction(SIGSTOP, &act, NULL) must not succeed"); > + } > + chk_error(sigaction(SIGKILL, NULL, &act)); > + chk_error(sigaction(SIGSTOP, NULL, &act)); > } > > #define SHM_SIZE 32768 > Reviewed-by: Laurent Vivier Alex, I will merge this via linux-user, is it ok for you? Thanks, Laurent