* [PATCH] acpi/ged: fix reset cause
@ 2021-06-24 11:00 Gerd Hoffmann
2021-06-24 11:06 ` Peter Maydell
2021-06-24 14:02 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2021-06-24 11:00 UTC (permalink / raw)
To: qemu-devel
Cc: peter.maydell, Igor Mammedov, Gerd Hoffmann, Michael S. Tsirkin
Reset requests should use SHUTDOWN_CAUSE_GUEST_RESET not
SHUTDOWN_CAUSE_GUEST_SHUTDOWN.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/acpi/generic_event_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c
index 39c825763ad8..e28457a7d103 100644
--- a/hw/acpi/generic_event_device.c
+++ b/hw/acpi/generic_event_device.c
@@ -207,7 +207,7 @@ static void ged_regs_write(void *opaque, hwaddr addr, uint64_t data,
return;
case ACPI_GED_REG_RESET:
if (data == ACPI_GED_RESET_VALUE) {
- qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);
+ qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_RESET);
}
return;
}
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] acpi/ged: fix reset cause
2021-06-24 11:00 [PATCH] acpi/ged: fix reset cause Gerd Hoffmann
@ 2021-06-24 11:06 ` Peter Maydell
2021-06-24 18:53 ` Michael S. Tsirkin
2021-06-24 14:02 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 4+ messages in thread
From: Peter Maydell @ 2021-06-24 11:06 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: Igor Mammedov, QEMU Developers, Michael S. Tsirkin
On Thu, 24 Jun 2021 at 12:01, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> Reset requests should use SHUTDOWN_CAUSE_GUEST_RESET not
> SHUTDOWN_CAUSE_GUEST_SHUTDOWN.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/acpi/generic_event_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c
> index 39c825763ad8..e28457a7d103 100644
> --- a/hw/acpi/generic_event_device.c
> +++ b/hw/acpi/generic_event_device.c
> @@ -207,7 +207,7 @@ static void ged_regs_write(void *opaque, hwaddr addr, uint64_t data,
> return;
> case ACPI_GED_REG_RESET:
> if (data == ACPI_GED_RESET_VALUE) {
> - qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);
> + qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_RESET);
> }
> return;
> }
> --
> 2.31.1
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] acpi/ged: fix reset cause
2021-06-24 11:00 [PATCH] acpi/ged: fix reset cause Gerd Hoffmann
2021-06-24 11:06 ` Peter Maydell
@ 2021-06-24 14:02 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-06-24 14:02 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel
Cc: peter.maydell, Michael S. Tsirkin, Igor Mammedov
On 6/24/21 1:00 PM, Gerd Hoffmann wrote:
> Reset requests should use SHUTDOWN_CAUSE_GUEST_RESET not
> SHUTDOWN_CAUSE_GUEST_SHUTDOWN.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/acpi/generic_event_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] acpi/ged: fix reset cause
2021-06-24 11:06 ` Peter Maydell
@ 2021-06-24 18:53 ` Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2021-06-24 18:53 UTC (permalink / raw)
To: Peter Maydell; +Cc: Igor Mammedov, Gerd Hoffmann, QEMU Developers
On Thu, Jun 24, 2021 at 12:06:14PM +0100, Peter Maydell wrote:
> On Thu, 24 Jun 2021 at 12:01, Gerd Hoffmann <kraxel@redhat.com> wrote:
> >
> > Reset requests should use SHUTDOWN_CAUSE_GUEST_RESET not
> > SHUTDOWN_CAUSE_GUEST_SHUTDOWN.
> >
> > Reported-by: Peter Maydell <peter.maydell@linaro.org>
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> > hw/acpi/generic_event_device.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c
> > index 39c825763ad8..e28457a7d103 100644
> > --- a/hw/acpi/generic_event_device.c
> > +++ b/hw/acpi/generic_event_device.c
> > @@ -207,7 +207,7 @@ static void ged_regs_write(void *opaque, hwaddr addr, uint64_t data,
> > return;
> > case ACPI_GED_REG_RESET:
> > if (data == ACPI_GED_RESET_VALUE) {
> > - qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);
> > + qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_RESET);
> > }
> > return;
> > }
> > --
> > 2.31.1
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> thanks
> -- PMM
tagged, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-24 18:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-24 11:00 [PATCH] acpi/ged: fix reset cause Gerd Hoffmann
2021-06-24 11:06 ` Peter Maydell
2021-06-24 18:53 ` Michael S. Tsirkin
2021-06-24 14:02 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.