All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: Christoph Hellwig <hch@lst.de>
Cc: Varun Prakash <varun@chelsio.com>, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvmet-tcp: fix data digest pointer calculation
Date: Wed, 27 Oct 2021 12:49:31 +0300	[thread overview]
Message-ID: <252308fb-d557-34ce-5c7f-a6307f92b111@grimberg.me> (raw)
In-Reply-To: <20211027071316.GA11266@lst.de>


>>>> diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c
>>>> index 07ee347..d641bfa 100644
>>>> --- a/drivers/nvme/target/tcp.c
>>>> +++ b/drivers/nvme/target/tcp.c
>>>> @@ -702,7 +702,7 @@ static int nvmet_try_send_ddgst(struct nvmet_tcp_cmd *cmd, bool last_in_batch)
>>>>    	struct nvmet_tcp_queue *queue = cmd->queue;
>>>>    	struct msghdr msg = { .msg_flags = MSG_DONTWAIT };
>>>>    	struct kvec iov = {
>>>> -		.iov_base = &cmd->exp_ddgst + cmd->offset,
>>>> +		.iov_base = (u8 *)&cmd->exp_ddgst + cmd->offset,
>>>
>>> Wouldn't be the better fix to divide cmd->offset by 4 instead of the
>>> casts?  I can fix this up inline if that is ok.
>>
>> Don't really mind, what makes it a better fix?
> 
> I generally prefer to avoid casts as they paper over bugs.

I'm fine either way.


  reply	other threads:[~2021-10-27  9:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 17:16 [PATCH] nvmet-tcp: fix data digest pointer calculation Varun Prakash
2021-10-26 13:24 ` Sagi Grimberg
2021-10-27  5:57 ` Christoph Hellwig
2021-10-27  7:11   ` Sagi Grimberg
2021-10-27  7:13     ` Christoph Hellwig
2021-10-27  9:49       ` Sagi Grimberg [this message]
2021-10-27 14:49         ` Varun Prakash
2021-10-28  8:26           ` Sagi Grimberg
2021-10-28 10:49             ` Varun Prakash
2021-10-28 14:00               ` Christoph Hellwig
2021-10-28 14:07                 ` Sagi Grimberg
2021-10-27 21:37 ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=252308fb-d557-34ce-5c7f-a6307f92b111@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=hch@lst.de \
    --cc=linux-nvme@lists.infradead.org \
    --cc=varun@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.