From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] devtools: check commit log fixes syntax Date: Wed, 30 Jan 2019 12:31:21 +0100 Message-ID: <2527672.4HATR1JlfD@xps> References: <20190129153052.38634-1-ferruh.yigit@intel.com> <20190130112934.GB157424@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Ferruh Yigit , dev@dpdk.org, Qi Zhang , david.marchand@redhat.com To: Bruce Richardson Return-path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id C39CD1B272 for ; Wed, 30 Jan 2019 12:31:26 +0100 (CET) In-Reply-To: <20190130112934.GB157424@bricha3-MOBL.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/01/2019 12:29, Bruce Richardson: > On Wed, Jan 30, 2019 at 11:15:44AM +0000, Ferruh Yigit wrote: > > On 1/29/2019 8:41 PM, Thomas Monjalon wrote: > > > 29/01/2019 16:30, Ferruh Yigit: > > >> Fixes line commit id length defined as 12 in fixline alias: > > >> fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae' > > >> > > >> Check if the Fixes line commit id length matches the defined value. > > > > > > This check was missing on purpose, in order to not be too strict. > > > I think it's OK if the length of the SHA1 is not always the same. > > > > That is OK, if we don't want to be strict on this, I will update patch as rejected. > > > I think having this check is still good. It's not enforcing the rule, just > warning when violated. In 99% of cases this warning should be fixed IMHO, > especially if you guys are fixing these manually anyway. I don't fix it manually. I think SHA1 length has no importance. Why do you think it should be fixed?