From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4267CC4361B for ; Thu, 10 Dec 2020 12:20:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAC2223C81 for ; Thu, 10 Dec 2020 12:20:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EAC2223C81 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 175E86E441; Thu, 10 Dec 2020 12:20:46 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9C5D86E429; Thu, 10 Dec 2020 12:20:44 +0000 (UTC) IronPort-SDR: ru80uhl8Y2CXSEbb/xgz7+ax6FJ9iujOlNZEkQteluji+OH4T/+v3uQuWiZ/g65Uh+3O6VAikY 3zA0V7uKboqg== X-IronPort-AV: E=McAfee;i="6000,8403,9830"; a="161295679" X-IronPort-AV: E=Sophos;i="5.78,408,1599548400"; d="scan'208";a="161295679" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2020 04:20:43 -0800 IronPort-SDR: K4kkgKmNOnj9mj1LRvQRm9rywBeaRnfg5H5+yvX02joxBiM5y/YJJG0ePGAjJiahEDU9lf77xb WQB1a0kTVwow== X-IronPort-AV: E=Sophos;i="5.78,408,1599548400"; d="scan'208";a="375894739" Received: from aknautiy-mobl.gar.corp.intel.com (HELO [10.215.193.151]) ([10.215.193.151]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2020 04:20:40 -0800 Subject: Re: [PATCH v4 07/16] drm/dp_helper: Add helpers to configure PCONs RGB-YCbCr Conversion To: Dan Carpenter , kbuild@lists.01.org, intel-gfx@lists.freedesktop.org References: <20201209175034.GJ2767@kadam> From: "Nautiyal, Ankit K" Message-ID: <25291b7c-5aa5-d687-8516-a64e122dd2ee@intel.com> Date: Thu, 10 Dec 2020 17:50:38 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20201209175034.GJ2767@kadam> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kbuild-all@lists.01.org, lkp@intel.com, airlied@linux.ie, swati2.sharma@intel.com, vandita.kulkarni@intel.com, uma.shankar@intel.com, dri-devel@lists.freedesktop.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Dan, Thanks for the mail. As rightly mentioned, the intention was && instead of ||. I will fix the issue in the next version of the patch. Thanks & Regards, Ankit On 12/9/2020 11:20 PM, Dan Carpenter wrote: > Hi Ankit, > > url: https://github.com/0day-ci/linux/commits/Ankit-Nautiyal/Add-support-for-DP-HDMI2-1-PCON/20201208-160027 > base: git://anongit.freedesktop.org/drm-intel for-linux-next > config: i386-randconfig-m021-20201209 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Dan Carpenter > > smatch warnings: > drivers/gpu/drm/drm_dp_helper.c:3185 drm_dp_pcon_convert_rgb_to_ycbcr() warn: was && intended here instead of ||? > > vim +3185 drivers/gpu/drm/drm_dp_helper.c > > +int drm_dp_pcon_convert_rgb_to_ycbcr(struct drm_dp_aux *aux, u8 color_spc) > +{ > + int ret; > + u8 buf; > + > + if (color_spc != DP_CONVERSION_BT601_RGB_YCBCR_ENABLE || > + color_spc != DP_CONVERSION_BT709_RGB_YCBCR_ENABLE || > + color_spc != DP_CONVERSION_BT2020_RGB_YCBCR_ENABLE) > + return -EINVAL; > > "color_spc" cannot possibly be equal to three different values so this > function will always return -EINVAL. > > + > + ret = drm_dp_dpcd_readb(aux, DP_PROTOCOL_CONVERTER_CONTROL_2, &buf); > + if (ret < 0) > + return ret; > + > + buf |= color_spc; > + ret = drm_dp_dpcd_writeb(aux, DP_PROTOCOL_CONVERTER_CONTROL_2, buf); > + if (ret < 0) > + return ret; > + > + return 0; > +} > > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7F6CC433FE for ; Thu, 10 Dec 2020 12:20:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90C8423B70 for ; Thu, 10 Dec 2020 12:20:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90C8423B70 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C136F6E429; Thu, 10 Dec 2020 12:20:45 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9C5D86E429; Thu, 10 Dec 2020 12:20:44 +0000 (UTC) IronPort-SDR: ru80uhl8Y2CXSEbb/xgz7+ax6FJ9iujOlNZEkQteluji+OH4T/+v3uQuWiZ/g65Uh+3O6VAikY 3zA0V7uKboqg== X-IronPort-AV: E=McAfee;i="6000,8403,9830"; a="161295679" X-IronPort-AV: E=Sophos;i="5.78,408,1599548400"; d="scan'208";a="161295679" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2020 04:20:43 -0800 IronPort-SDR: K4kkgKmNOnj9mj1LRvQRm9rywBeaRnfg5H5+yvX02joxBiM5y/YJJG0ePGAjJiahEDU9lf77xb WQB1a0kTVwow== X-IronPort-AV: E=Sophos;i="5.78,408,1599548400"; d="scan'208";a="375894739" Received: from aknautiy-mobl.gar.corp.intel.com (HELO [10.215.193.151]) ([10.215.193.151]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2020 04:20:40 -0800 To: Dan Carpenter , kbuild@lists.01.org, intel-gfx@lists.freedesktop.org References: <20201209175034.GJ2767@kadam> From: "Nautiyal, Ankit K" Message-ID: <25291b7c-5aa5-d687-8516-a64e122dd2ee@intel.com> Date: Thu, 10 Dec 2020 17:50:38 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20201209175034.GJ2767@kadam> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH v4 07/16] drm/dp_helper: Add helpers to configure PCONs RGB-YCbCr Conversion X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kbuild-all@lists.01.org, airlied@linux.ie, dri-devel@lists.freedesktop.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Dan, Thanks for the mail. As rightly mentioned, the intention was && instead of ||. I will fix the issue in the next version of the patch. Thanks & Regards, Ankit On 12/9/2020 11:20 PM, Dan Carpenter wrote: > Hi Ankit, > > url: https://github.com/0day-ci/linux/commits/Ankit-Nautiyal/Add-support-for-DP-HDMI2-1-PCON/20201208-160027 > base: git://anongit.freedesktop.org/drm-intel for-linux-next > config: i386-randconfig-m021-20201209 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Dan Carpenter > > smatch warnings: > drivers/gpu/drm/drm_dp_helper.c:3185 drm_dp_pcon_convert_rgb_to_ycbcr() warn: was && intended here instead of ||? > > vim +3185 drivers/gpu/drm/drm_dp_helper.c > > +int drm_dp_pcon_convert_rgb_to_ycbcr(struct drm_dp_aux *aux, u8 color_spc) > +{ > + int ret; > + u8 buf; > + > + if (color_spc != DP_CONVERSION_BT601_RGB_YCBCR_ENABLE || > + color_spc != DP_CONVERSION_BT709_RGB_YCBCR_ENABLE || > + color_spc != DP_CONVERSION_BT2020_RGB_YCBCR_ENABLE) > + return -EINVAL; > > "color_spc" cannot possibly be equal to three different values so this > function will always return -EINVAL. > > + > + ret = drm_dp_dpcd_readb(aux, DP_PROTOCOL_CONVERTER_CONTROL_2, &buf); > + if (ret < 0) > + return ret; > + > + buf |= color_spc; > + ret = drm_dp_dpcd_writeb(aux, DP_PROTOCOL_CONVERTER_CONTROL_2, buf); > + if (ret < 0) > + return ret; > + > + return 0; > +} > > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0694047986906555144==" MIME-Version: 1.0 From: Nautiyal, Ankit K To: kbuild-all@lists.01.org Subject: Re: [PATCH v4 07/16] drm/dp_helper: Add helpers to configure PCONs RGB-YCbCr Conversion Date: Thu, 10 Dec 2020 17:50:38 +0530 Message-ID: <25291b7c-5aa5-d687-8516-a64e122dd2ee@intel.com> In-Reply-To: <20201209175034.GJ2767@kadam> List-Id: --===============0694047986906555144== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Dan, Thanks for the mail. As rightly mentioned, the intention was && instead of ||. I will fix the issue in the next version of the patch. Thanks & Regards, Ankit On 12/9/2020 11:20 PM, Dan Carpenter wrote: > Hi Ankit, > > url: https://github.com/0day-ci/linux/commits/Ankit-Nautiyal/Add-suppo= rt-for-DP-HDMI2-1-PCON/20201208-160027 > base: git://anongit.freedesktop.org/drm-intel for-linux-next > config: i386-randconfig-m021-20201209 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Dan Carpenter > > smatch warnings: > drivers/gpu/drm/drm_dp_helper.c:3185 drm_dp_pcon_convert_rgb_to_ycbcr() w= arn: was && intended here instead of ||? > > vim +3185 drivers/gpu/drm/drm_dp_helper.c > > +int drm_dp_pcon_convert_rgb_to_ycbcr(struct drm_dp_aux *aux, u8 color_sp= c) > +{ > + int ret; > + u8 buf; > + > + if (color_spc !=3D DP_CONVERSION_BT601_RGB_YCBCR_ENABLE || > + color_spc !=3D DP_CONVERSION_BT709_RGB_YCBCR_ENABLE || > + color_spc !=3D DP_CONVERSION_BT2020_RGB_YCBCR_ENABLE) > + return -EINVAL; > > "color_spc" cannot possibly be equal to three different values so this > function will always return -EINVAL. > > + > + ret =3D drm_dp_dpcd_readb(aux, DP_PROTOCOL_CONVERTER_CONTROL_2, &buf); > + if (ret < 0) > + return ret; > + > + buf |=3D color_spc; > + ret =3D drm_dp_dpcd_writeb(aux, DP_PROTOCOL_CONVERTER_CONTROL_2, buf); > + if (ret < 0) > + return ret; > + > + return 0; > +} > > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org > > _______________________________________________ > dri-devel mailing list > dri-devel(a)lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0694047986906555144==--