All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Tianyu Li <tianyu.li@arm.com>, Jakub Grajciar <jgrajcia@cisco.com>
Cc: dev@dpdk.org, nd@arm.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/memif: fix missing Tx-bps stats for zero-copy
Date: Wed, 14 Apr 2021 09:13:10 +0100	[thread overview]
Message-ID: <252a9754-9d9d-36cf-dd4e-6326e604429d@intel.com> (raw)
In-Reply-To: <20210412082231.1866235-1-tianyu.li@arm.com>

On 4/12/2021 9:22 AM, Tianyu Li wrote:
> Fix the missing Tx-bps counter for memif zero-copy mode
> Before
>    Rx-pps:      6891450          Rx-bps:   3528438928
>    Tx-pps:      6891482          Tx-bps:            0
> After
>    Throughput (since last show)
>    Rx-pps:     11157056          Rx-bps:   5712413016
>    Tx-pps:     11157056          Tx-bps:   5712413016
> 
> Fixes: 43b815d88188 ("net/memif: support zero-copy slave")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tianyu Li <tianyu.li@arm.com>
> ---
>   drivers/net/memif/rte_eth_memif.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c
> index 77c95bcb7..dd2825968 100644
> --- a/drivers/net/memif/rte_eth_memif.c
> +++ b/drivers/net/memif/rte_eth_memif.c
> @@ -706,6 +706,7 @@ memif_tx_one_zc(struct pmd_process_private *proc_private, struct memif_queue *mq
>   	/* populate descriptor */
>   	d0 = &ring->desc[slot & mask];
>   	d0->length = rte_pktmbuf_data_len(mbuf);
> +	mq->n_bytes += rte_pktmbuf_data_len(mbuf);
>   	/* FIXME: get region index */
>   	d0->region = 1;
>   	d0->offset = rte_pktmbuf_mtod(mbuf, uint8_t *) -
> 

Looks good to me, but let's wait Jakub's review for it.

  reply	other threads:[~2021-04-14  8:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-12  8:22 [dpdk-dev] [PATCH] net/memif: fix missing Tx-bps stats for zero-copy Tianyu Li
2021-04-14  8:13 ` Ferruh Yigit [this message]
2021-04-27  6:30   ` Tianyu Li
2021-05-18 12:08     ` Ferruh Yigit
2021-05-18 16:57       ` Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
2021-05-19  7:57 ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=252a9754-9d9d-36cf-dd4e-6326e604429d@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=jgrajcia@cisco.com \
    --cc=nd@arm.com \
    --cc=stable@dpdk.org \
    --cc=tianyu.li@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.