From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v4 2/3] Add Intel FPGA BUS Rawdev Driver
Date: Tue, 3 Apr 2018 15:04:53 +0530
Message-ID: <25304883-90fc-a579-c234-2058aa7a10b8@nxp.com>
References: <1521553556-62982-1-git-send-email-rosen.xu@intel.com>
 <1522512182-182441-1-git-send-email-rosen.xu@intel.com>
 <1522512182-182441-3-git-send-email-rosen.xu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, declan.doherty@intel.com, bruce.richardson@intel.com,
 shreyansh.jain@nxp.com, ferruh.yigit@intel.com,
 konstantin.ananyev@intel.com, tianfei.zhang@intel.com, hao.wu@intel.com,
 gaetan.rivet@6wind.com, Yanglong Wu <yanglong.wu@intel.com>
To: Rosen Xu <rosen.xu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur03hn0202.outbound.protection.outlook.com [104.47.10.202])
 by dpdk.org (Postfix) with ESMTP id 5BC601B690
 for <dev@dpdk.org>; Tue,  3 Apr 2018 11:19:52 +0200 (CEST)
In-Reply-To: <1522512182-182441-3-git-send-email-rosen.xu@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Saturday 31 March 2018 09:33 PM, Rosen Xu wrote:
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> Signed-off-by: Yanglong Wu  <yanglong.wu@intel.com>
> ---
>   config/common_base                                 |   1 +
>   drivers/raw/Makefile                               |   1 +
>   drivers/raw/ifpga_rawdev/Makefile                  |  34 ++
>   drivers/raw/ifpga_rawdev/ifpga_rawdev.c            | 594 +++++++++++++++++++++
>   drivers/raw/ifpga_rawdev/ifpga_rawdev.h            |  37 ++
>   .../raw/ifpga_rawdev/rte_ifpga_rawdev_version.map  |   4 +
>   mk/rte.app.mk                                      |   1 +
>   7 files changed, 672 insertions(+)
>   create mode 100644 drivers/raw/ifpga_rawdev/Makefile
>   create mode 100644 drivers/raw/ifpga_rawdev/ifpga_rawdev.c
>   create mode 100644 drivers/raw/ifpga_rawdev/ifpga_rawdev.h
>   create mode 100644 drivers/raw/ifpga_rawdev/rte_ifpga_rawdev_version.map
> 
> diff --git a/config/common_base b/config/common_base
> index 49f6b09..08b7cce 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -137,6 +137,7 @@ CONFIG_RTE_LIBRTE_VDEV_BUS=y
>   # Compile the Intel FPGA bus
>   #
>   CONFIG_RTE_LIBRTE_IFPGA_BUS=y
> +CONFIG_RTE_LIBRTE_IFPGA_RAWDEV=y
>   
>   #
>   # Compile ARK PMD
> diff --git a/drivers/raw/Makefile b/drivers/raw/Makefile
> index da7c8b4..6fc8f2f 100644
> --- a/drivers/raw/Makefile
> +++ b/drivers/raw/Makefile
> @@ -5,5 +5,6 @@ include $(RTE_SDK)/mk/rte.vars.mk
>   
>   # DIRS-$(<configuration>) += <directory>
>   DIRS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_RAWDEV) += skeleton_rawdev
> +DIRS-$(CONFIG_RTE_LIBRTE_IFPGA_RAWDEV) += ifpga_rawdev
>   
>   include $(RTE_SDK)/mk/rte.subdir.mk
> diff --git a/drivers/raw/ifpga_rawdev/Makefile b/drivers/raw/ifpga_rawdev/Makefile
> new file mode 100644
> index 0000000..118c729
> --- /dev/null
> +++ b/drivers/raw/ifpga_rawdev/Makefile
> @@ -0,0 +1,34 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2018 Intel Corporation
> +
> +include $(RTE_SDK)/mk/rte.vars.mk
> +
> +#
> +# library name
> +#
> +LIB = librte_ifpga_rawdev.a
> +
> +CFLAGS += -DALLOW_EXPERIMENTAL_API
> +CFLAGS += -O3
> +CFLAGS += $(WERROR_FLAGS)
> +CFLAGS += -I$(RTE_SDK)/drivers/bus/ifpga
> +CFLAGS += -I$(RTE_SDK)/drivers/raw/ifpga_rawdev
> +LDLIBS += -lrte_eal
> +LDLIBS += -lrte_rawdev
> +LDLIBS += -lrte_bus_vdev
> +LDLIBS += -lrte_kvargs
> +
> +EXPORT_MAP := rte_ifpga_rawdev_version.map
> +
> +LIBABIVER := 1
> +
> +VPATH += $(SRCDIR)/base
> +
> +include $(RTE_SDK)/drivers/raw/ifpga_rawdev/base/Makefile
> +
> +#
> +# all source are stored in SRCS-y
> +#
> +SRCS-$(CONFIG_RTE_LIBRTE_IFPGA_RAWDEV) += ifpga_rawdev.c
> +
> +include $(RTE_SDK)/mk/rte.lib.mk

[...]
Your patch doesn't compile at this point: (Static build; Shared is still 
stuck on patch [1/3]).

--->8---
== Build drivers/raw/ifpga_rawdev
/home/shreyansh/build/DPDK/00_dpdk/drivers/raw/ifpga_rawdev/Makefile:27: 
/home/shreyansh/build/DPDK/00_dpdk/drivers/raw/ifpga_rawdev/base/Makefile: 
No such file or directory
make[6]: *** No rule to make target 
'/home/shreyansh/build/DPDK/00_dpdk/drivers/raw/ifpga_rawdev/base/Makefile'. 
  Stop.
/home/shreyansh/build/DPDK/00_dpdk/mk/rte.subdir.mk:35: recipe for 
target 'ifpga_rawdev' failed
make[5]: *** [ifpga_rawdev] Error 2
make[5]: *** Waiting for unfinished jobs....
--->8---

Which is because your patch [3/3] contains various definitions which are 
being used in this patch.

Am I missing something?

-
Shreyansh