From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brandeburg, Jesse Date: Fri, 5 Oct 2018 01:11:34 +0000 Subject: [Intel-wired-lan] [next PATCH S97 5/7] i40e: Remove negated logic in if statement and fix comment In-Reply-To: <20181004221830.16212-5-alice.michael@intel.com> References: <20181004221830.16212-1-alice.michael@intel.com> <20181004221830.16212-5-alice.michael@intel.com> Message-ID: <253CF818969A9240AB2054BF91F2C2BC8B2F4390@ORSMSX114.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: There is no comment formatting in this patch, maybe just remove the references to fix comment in title and in text. -----Original Message----- From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Alice Michael Sent: Thursday, October 4, 2018 3:18 PM To: Michael, Alice ; intel-wired-lan at lists.osuosl.org Subject: [Intel-wired-lan] [next PATCH S97 5/7] i40e: Remove negated logic in if statement and fix comment From: Patryk Ma?ek Found by upstream review. It also fixes a minor comment formatting to adhere to networking comment formatting. Signed-off-by: Patryk Ma?ek --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c index f35a26c..2bb116f 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c @@ -4958,8 +4958,8 @@ void i40e_set_ethtool_ops(struct net_device *netdev) struct i40e_netdev_priv *np = netdev_priv(netdev); struct i40e_pf *pf = np->vsi->back; - if (!test_bit(__I40E_RECOVERY_MODE, pf->state)) - netdev->ethtool_ops = &i40e_ethtool_ops; - else + if (test_bit(__I40E_RECOVERY_MODE, pf->state)) netdev->ethtool_ops = &i40e_ethtool_recovery_mode_ops; + else + netdev->ethtool_ops = &i40e_ethtool_ops; } -- 2.9.5 _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan at osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan