From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09379C433EF for ; Wed, 6 Jul 2022 11:58:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229558AbiGFL6j (ORCPT ); Wed, 6 Jul 2022 07:58:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233450AbiGFL6b (ORCPT ); Wed, 6 Jul 2022 07:58:31 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9826123BCA for ; Wed, 6 Jul 2022 04:58:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657108707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1QhWLKEpshviPNDTG+rlONXrogGmGRJzt+OodfxRCiM=; b=Wt9HhEMXXgejYcVhUo1k9DNt84n6hOYFIxN/yZNbsrgKnzvq++3sDGMAdK4OMqlsHyPjnJ KLej0bX582gCC4qikJAylxkVIjQQWBknW3+JAYAepZngMSFP58sP/ZEgwglcKiDRdAdRyC JMtNQuHCSjOIuIJXn9/hB/Bj26vGYuA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-563-wjfukSXlN-yeSNYX2DHFhA-1; Wed, 06 Jul 2022 07:58:22 -0400 X-MC-Unique: wjfukSXlN-yeSNYX2DHFhA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8F8ED3C0D85D; Wed, 6 Jul 2022 11:58:21 +0000 (UTC) Received: from starship (unknown [10.40.194.38]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3AA451121315; Wed, 6 Jul 2022 11:58:19 +0000 (UTC) Message-ID: <253c4296bc328346bcd0571c1ef0f9f85bbc12f4.camel@redhat.com> Subject: Re: [PATCH v2 07/21] KVM: x86: Use DR7_GD macro instead of open coding check in emulator From: Maxim Levitsky To: Sean Christopherson , Paolo Bonzini Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Oliver Upton , Peter Shier Date: Wed, 06 Jul 2022 14:58:18 +0300 In-Reply-To: <20220614204730.3359543-8-seanjc@google.com> References: <20220614204730.3359543-1-seanjc@google.com> <20220614204730.3359543-8-seanjc@google.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2022-06-14 at 20:47 +0000, Sean Christopherson wrote: > Use DR7_GD in the emulator instead of open coding the check, and drop a > comically wrong comment. > > Signed-off-by: Sean Christopherson > --- > arch/x86/kvm/emulate.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c > index 39ea9138224c..bf499716d9d3 100644 > --- a/arch/x86/kvm/emulate.c > +++ b/arch/x86/kvm/emulate.c > @@ -4182,8 +4182,7 @@ static int check_dr7_gd(struct x86_emulate_ctxt *ctxt) > > ctxt->ops->get_dr(ctxt, 7, &dr7); > > - /* Check if DR7.Global_Enable is set */ > - return dr7 & (1 << 13); > + return dr7 & DR7_GD; > } > > static int check_dr_read(struct x86_emulate_ctxt *ctxt) Reviewed-by: Maxim Levitsky Best regards, Maxim Levitsky