All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <t.figa@samsung.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
	linux-samsung-soc@vger.kernel.org, kyungmin.park@samsung.com,
	m.szyprowski@samsung.com, tomasz.figa@gmail.com
Subject: Re: [PATCH] input: keyboard: gpio-keys: Try to parse IRQ from device tree
Date: Fri, 05 Oct 2012 09:59:57 +0200	[thread overview]
Message-ID: <25463817.uuiAvzsyb8@amdc1227> (raw)
In-Reply-To: <20121005062315.GB11112@core.coreip.homeip.net>

Hi Dmitry,

On Thursday 04 of October 2012 23:23:15 Dmitry Torokhov wrote:
> Hi Tomasz,
> 
> On Wed, Oct 03, 2012 at 01:20:00PM +0200, Tomasz Figa wrote:
> > On modern platforms using device tree and non-legacy IRQ domains there
> > is usually no way to perform direct translation between GPIO and IRQ,
> > because the IRQ of interest is not mapped yet into sparse IRQ
> > namespace.
> > 
> > This patch modifies the gpio_keys driver to parse IRQ from device tree
> > and use gpio_to_irq only as a fallback.
> 
> This means that this change would need to be applied to every driver
> that currently maps gpio to IRQ. Why can't gpio_to_irq() be fixed
> instead?
> 

Now when I think of it again, there is a possibility of creating an IRQ 
mapping in .to_irq callback of GPIO chip, if it does not exist yet. This 
should be a better solution indeed. I will send a patch for pinctrl-samsung 
driver adding it.

Please disregard this patch.

Best regards,
-- 
Tomasz Figa
Samsung Poland R&D Center

      reply	other threads:[~2012-10-05  7:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-03 11:20 [PATCH] input: keyboard: gpio-keys: Try to parse IRQ from device tree Tomasz Figa
     [not found] ` <1349263201-422-1-git-send-email-t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-10-05  6:23   ` Dmitry Torokhov
2012-10-05  7:59     ` Tomasz Figa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25463817.uuiAvzsyb8@amdc1227 \
    --to=t.figa@samsung.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.