From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753214AbbHSH2W (ORCPT ); Wed, 19 Aug 2015 03:28:22 -0400 Received: from gloria.sntech.de ([95.129.55.99]:51030 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752950AbbHSH2S (ORCPT ); Wed, 19 Aug 2015 03:28:18 -0400 From: Heiko Stuebner To: Sjoerd Simons Cc: linux-rockchip@lists.infradead.org, Jaroslav Kysela , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Mark Brown , linux-kernel@vger.kernel.org, Kumar Gala , Ian Campbell , Takashi Iwai , Liam Girdwood , Pawel Moll , Rob Herring , Mark Rutland , Russell King , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 2/4] ASoC: rockchip: Add rockchip SPDIF transceiver driver Date: Wed, 19 Aug 2015 09:28:06 +0200 Message-ID: <2559509.ITzpmR5XN3@phil> User-Agent: KMail/4.14.1 (Linux/4.1.0-1-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1439967408.4135.84.camel@collabora.co.uk> References: <1438947854-3743-1-git-send-email-sjoerd.simons@collabora.co.uk> <1463451.tH10lfH9Hm@phil> <1439967408.4135.84.camel@collabora.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sjoerd, Am Mittwoch, 19. August 2015, 08:56:48 schrieb Sjoerd Simons: > Hey Heiko, > > Thanks for the comments, i'm hoping to address them and Marks comments > in a next patch series next week. > > On Tue, 2015-08-18 at 20:25 +0200, Heiko Stuebner wrote: > > > + > > > + spdif->hclk = devm_clk_get(&pdev->dev, "spdif_hclk"); > > > > I guess this could be named just "hclk" - as it is the identifier > > local to the spdif-ip. (Of course in the binding too) > > I'm entirely happy to change that, just wanted to note that the reason > i used spdif_hclk and spidf_clk is for consistency with the rockchip > -i2s binding which uses i2s_hclk ans i2s_mclk. I was also just remembering something Thierry Reding said in the edp thread: "The names are in a per-driver scope, so "dp-phy" is implied by the device tree binding and driver already. You could simply use shorter names such as "phy" and "24m" for example." > However i guess we could update the i2s binding at some poit as well to > follow similar names (with fallbacks to the old one). In general a lot > of the comments yourself and Mark have given actually apply to the > rockchip-i2s code as well so there is some cleanup to do there :) I'm not sure about updating the binding though, as it we'd need to provide backwards-compatibility for the old names as well. So I don't think renaming these will bring much benefit, but we can choose better names for followup drivers like the spdif. I haven't looked to much into the i2s stuff yet. But with me getting a grasp on the fractional dividers and the hardware drivers making it into the asoc tree now, I also plan to give the i2s audio on the Chromebooks a try :-) Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Wed, 19 Aug 2015 09:28:06 +0200 Subject: [PATCH v3 2/4] ASoC: rockchip: Add rockchip SPDIF transceiver driver In-Reply-To: <1439967408.4135.84.camel@collabora.co.uk> References: <1438947854-3743-1-git-send-email-sjoerd.simons@collabora.co.uk> <1463451.tH10lfH9Hm@phil> <1439967408.4135.84.camel@collabora.co.uk> Message-ID: <2559509.ITzpmR5XN3@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Sjoerd, Am Mittwoch, 19. August 2015, 08:56:48 schrieb Sjoerd Simons: > Hey Heiko, > > Thanks for the comments, i'm hoping to address them and Marks comments > in a next patch series next week. > > On Tue, 2015-08-18 at 20:25 +0200, Heiko Stuebner wrote: > > > + > > > + spdif->hclk = devm_clk_get(&pdev->dev, "spdif_hclk"); > > > > I guess this could be named just "hclk" - as it is the identifier > > local to the spdif-ip. (Of course in the binding too) > > I'm entirely happy to change that, just wanted to note that the reason > i used spdif_hclk and spidf_clk is for consistency with the rockchip > -i2s binding which uses i2s_hclk ans i2s_mclk. I was also just remembering something Thierry Reding said in the edp thread: "The names are in a per-driver scope, so "dp-phy" is implied by the device tree binding and driver already. You could simply use shorter names such as "phy" and "24m" for example." > However i guess we could update the i2s binding at some poit as well to > follow similar names (with fallbacks to the old one). In general a lot > of the comments yourself and Mark have given actually apply to the > rockchip-i2s code as well so there is some cleanup to do there :) I'm not sure about updating the binding though, as it we'd need to provide backwards-compatibility for the old names as well. So I don't think renaming these will bring much benefit, but we can choose better names for followup drivers like the spdif. I haven't looked to much into the i2s stuff yet. But with me getting a grasp on the fractional dividers and the hardware drivers making it into the asoc tree now, I also plan to give the i2s audio on the Chromebooks a try :-) Heiko