From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] net/mlx5: add missing return value check
Date: Thu, 28 Mar 2019 18:28:23 +0000
Message-ID: <256192b8-a885-0813-76bc-b38abf102b15@intel.com>
References: <20190321090652.32535-1-alialnu@mellanox.com>
 <VI1PR05MB4224FBAE0B6690810ABED3ADB6420@VI1PR05MB4224.eurprd05.prod.outlook.com>
 <AM0PR0502MB3795D472D3484A7F4CBA3135C35D0@AM0PR0502MB3795.eurprd05.prod.outlook.com>
 <9fa4371f-cf9d-79f8-9868-e45bd882e9c5@intel.com>
 <7e6eeec8-8c0c-4935-2bc9-9b07755e08ea@intel.com>
 <DB7PR05MB4410A39D2BDBC1DAC6860A48D7590@DB7PR05MB4410.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Shahaf Shuler <shahafs@mellanox.com>, Dekel Peled <dekelp@mellanox.com>,
 "dev@dpdk.org" <dev@dpdk.org>
To: Ali Alnubani <alialnu@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id 262C64F91
 for <dev@dpdk.org>; Thu, 28 Mar 2019 19:28:27 +0100 (CET)
In-Reply-To: <DB7PR05MB4410A39D2BDBC1DAC6860A48D7590@DB7PR05MB4410.eurprd05.prod.outlook.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/28/2019 10:29 AM, Ali Alnubani wrote:
> Hi Ferruh,
> 
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Wednesday, March 27, 2019 11:31 AM
>> To: Shahaf Shuler <shahafs@mellanox.com>; Dekel Peled
>> <dekelp@mellanox.com>; Ali Alnubani <alialnu@mellanox.com>;
>> dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: add missing return value check
>>
>> On 3/25/2019 12:02 PM, Ferruh Yigit wrote:
>>> On 3/24/2019 9:26 AM, Shahaf Shuler wrote:
>>>> Thursday, March 21, 2019 11:34 AM, Dekel Peled:
>>>>> Subject: RE: [PATCH] net/mlx5: add missing return value check
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Ali Alnubani
>>>>>> Sent: Thursday, March 21, 2019 11:07 AM
>>>>>> To: dev@dpdk.org
>>>>>> Cc: Shahaf Shuler <shahafs@mellanox.com>; Dekel Peled
>>>>>> <dekelp@mellanox.com>
>>>>>> Subject: [PATCH] net/mlx5: add missing return value check
>>>>>>
>>>>>> Fixes: d86406b965df ("net/mlx5: support new representor naming
>>>>>> format")
>>>>>> Cc: dekelp@mellanox.com
>>>>>>
>>>>>> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
>>>>
>>>> Applied to next-net-mlx, thanks.
>>>>
>>>
>>> Squashed into relevant commit [1] in next-net, thanks.
>>>
>>> [1]
>>> net/mlx5: support new representor naming format
>>>
>>
>> 'main' repo get the original patch without squash, so can't squash now,
>> merged as a incremental patch ...
>>
>> Applied to dpdk-next-net/master, thanks.
> 
> A more detailed commit body:
> 
> This patch fixes the build failure with message:
>     drivers/net/mlx5/mlx5_ethdev.c: In function ‘mlx5_sysfs_switch_info’:
>     drivers/net/mlx5/mlx5_ethdev.c:1381:3: error: ignoring return value
>     of ‘fscanf’, declared with attribute warn_unused_result [-Werror=unused-result]
>     fscanf(file, "%s", port_name);
>     ^
> Which reproduces on Ubuntu 16.04 LTS with
> gcc (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609.
> 
> Fixes: b2f3a3810125 ("net/mlx5: support new representor naming format")
> 
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> Acked-by: Dekel Peled <dekelp@mellanox.com>

Commit log updated in next-net as suggested, thanks.