From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Lamparter Subject: Re: [PATCH v1.1] net: emac: add support for device-tree based PHY discovery and setup Date: Mon, 27 Feb 2017 20:42:15 +0100 Message-ID: <2567253.1QjLrx0r05@debian64> References: <2109609d-c6a7-5c6f-d6aa-657107765778@gmail.com> <20170222.153735.1289514443979947868.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, ivan@de.ibm.com, f.fainelli@gmail.com, andrew@lunn.ch, robh+dt@kernel.org To: David Miller Return-path: Received: from mail-wm0-f46.google.com ([74.125.82.46]:37760 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751454AbdB0TpE (ORCPT ); Mon, 27 Feb 2017 14:45:04 -0500 In-Reply-To: <20170222.153735.1289514443979947868.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Wednesday, February 22, 2017 3:37:35 PM CET David Miller wrote: > From: Christian Lamparter > Date: Mon, 20 Feb 2017 20:10:58 +0100 > > > This patch adds glue-code that allows the EMAC driver to interface > > with the existing dt-supported PHYs in drivers/net/phy. > > > > Because currently, the emac driver maintains a small library of > > supported phys for in a private phy.c file located in the drivers > > directory. > > > > The support is limited to mostly single ethernet transceiver like the: > > CIS8201, BCM5248, ET1011C, Marvell 88E1111 and 88E1112, AR8035. > > > > However, routers like the Netgear WNDR4700 and Cisco Meraki MX60(W) > > have a 5-port switch (AR8327N) attached to the EMAC. The switch chip > > is supported by the qca8k mdio driver, which uses the generic phy > > library. Another reason is that PHYLIB also supports the BCM54610, > > which was used for the Western Digital My Book Live. > > > > This will now also make EMAC select PHYLIB. > > > > Signed-off-by: Christian Lamparter > > Applied, thanks. > Thanks David. I noticed that the DT Documentation patch: "[v1,1/2] dt: emac: document device-tree based phy discovery and setup" is still pending with "Changes Requested": I think this is because of Florian's comment on patch: "[v1,2/2] net: emac: add support for device-tree based PHY discovery and setup" If so, can you please queue this documentation update patch for -next? (I haven't received any comments or complains. If necessary, I can also resent it.) Thanks, Christian